Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | class InterlaceFilterLoaderTest extends WebTestCase |
||
8 | { |
||
9 | public function testCouldBeGetFromContainerAsService() |
||
10 | { |
||
11 | $this->createClient(); |
||
12 | $service = self::$kernel->getContainer()->get('liip_imagine.filter.loader.interlace'); |
||
13 | |||
14 | $this->assertInstanceOf('Liip\ImagineBundle\Imagine\Filter\Loader\InterlaceFilterLoader', $service); |
||
15 | } |
||
16 | } |
||
17 |