WatermarkFilterLoader::load() - Code Metrics - Inspection of "add @Event annotation to let IDEs known event name..." - liip/LiipImagineBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#732)

by 12345

created 2016-05-05 10:14 UTC

WatermarkFilterLoader::load() C

↳ Parent: WatermarkFilterLoader

Complexity

Conditions	15
Paths	80

Size

Total Lines	72
Code Lines	56

Duplication

Lines	16
Ratio	22.22 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	16
loc	72
rs	5.4849
cc	15
eloc	56
nc	80
nop	2

How to fix Long Method Complexity

<?php

namespace Liip\ImagineBundle\Imagine\Filter\Loader;

use Imagine\Image\Box;
use Imagine\Image\Point;
use Imagine\Image\ImageInterface;
use Imagine\Image\ImagineInterface;

class WatermarkFilterLoader implements LoaderInterface
{
    /**
     * @var ImagineInterface
     */
    protected $imagine;

    /**
     * @var string
     */
    protected $rootPath;

    public function __construct(ImagineInterface $imagine, $rootPath)
    {
        $this->imagine = $imagine;
        $this->rootPath = $rootPath;
    }

    /**
     * @see Liip\ImagineBundle\Imagine\Filter\Loader\LoaderInterface::load()
     */
    public function load(ImageInterface $image, array $options = array())
    {
        $options += array(
            'size' => null,
            'position' => 'center',
        );

        if (substr($options['size'], -1) == '%') {
            $options['size'] = substr($options['size'], 0, -1) / 100;
        }

        $watermark = $this->imagine->open($this->rootPath.'/'.$options['image']);

        $size = $image->getSize();
        $watermarkSize = $watermark->getSize();

        // If 'null': Downscale if needed
        if (!$options['size'] && ($size->getWidth() < $watermarkSize->getWidth() || $size->getHeight() < $watermarkSize->getHeight())) {
            $options['size'] = 1.0;
        }

        if ($options['size']) {
            $factor = $options['size'] * min($size->getWidth() / $watermarkSize->getWidth(), $size->getHeight() / $watermarkSize->getHeight());

            $watermark->resize(new Box($watermarkSize->getWidth() * $factor, $watermarkSize->getHeight() * $factor));
            $watermarkSize = $watermark->getSize();
        }

        switch ($options['position']) {
            case 'topleft':
                $x = 0;
                $y = 0;
                break;
            case 'top':
                $x = ($size->getWidth() - $watermarkSize->getWidth()) / 2;
                $y = 0;
                break;
            case 'topright':
                $x = $size->getWidth() - $watermarkSize->getWidth();
                $y = 0;
                break;
            case 'left':
                $x = 0;
                $y = ($size->getHeight() - $watermarkSize->getHeight()) / 2;
                break;
            case 'center':

                $x = ($size->getWidth() - $watermarkSize->getWidth()) / 2;
                $y = ($size->getHeight() - $watermarkSize->getHeight()) / 2;
                break;
            case 'right':

                $x = $size->getWidth() - $watermarkSize->getWidth();
                $y = ($size->getHeight() - $watermarkSize->getHeight()) / 2;
                break;
            case 'bottomleft':
                $x = 0;
                $y = $size->getHeight() - $watermarkSize->getHeight();
                break;
            case 'bottom':

                $x = ($size->getWidth() - $watermarkSize->getWidth()) / 2;
                $y = $size->getHeight() - $watermarkSize->getHeight();
                break;
            case 'bottomright':

                $x = $size->getWidth() - $watermarkSize->getWidth();
                $y = $size->getHeight() - $watermarkSize->getHeight();
                break;
            default:
                throw new \InvalidArgumentException("Unexpected position '{$options['position']}'");
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        }

        return $image->paste($watermark, new Point($x, $y));
    }
}


1		<?php
2
3		namespace Liip\ImagineBundle\Imagine\Filter\Loader;
4
5		use Imagine\Image\Box;
6		use Imagine\Image\Point;
7		use Imagine\Image\ImageInterface;
8		use Imagine\Image\ImagineInterface;
9
10		class WatermarkFilterLoader implements LoaderInterface
11		{
12		/**
13		* @var ImagineInterface
14		*/
15		protected $imagine;
16
17		/**
18		* @var string
19		*/
20		protected $rootPath;
21
22		public function __construct(ImagineInterface $imagine, $rootPath)
23		{
24		$this->imagine = $imagine;
25		$this->rootPath = $rootPath;
26		}
27
28		/**
29		* @see Liip\ImagineBundle\Imagine\Filter\Loader\LoaderInterface::load()
30		*/
31		public function load(ImageInterface $image, array $options = array())
32		{
33		$options += array(
34		'size' => null,
35		'position' => 'center',
36		);
37
38		if (substr($options['size'], -1) == '%') {
39		$options['size'] = substr($options['size'], 0, -1) / 100;
40		}
41
42		$watermark = $this->imagine->open($this->rootPath.'/'.$options['image']);
43
44		$size = $image->getSize();
45		$watermarkSize = $watermark->getSize();
46
47		// If 'null': Downscale if needed
48		if (!$options['size'] && ($size->getWidth() < $watermarkSize->getWidth() \|\| $size->getHeight() < $watermarkSize->getHeight())) {
49		$options['size'] = 1.0;
50		}
51
52		if ($options['size']) {
53		$factor = $options['size'] * min($size->getWidth() / $watermarkSize->getWidth(), $size->getHeight() / $watermarkSize->getHeight());
54
55		$watermark->resize(new Box($watermarkSize->getWidth() * $factor, $watermarkSize->getHeight() * $factor));
56		$watermarkSize = $watermark->getSize();
57		}
58
59		switch ($options['position']) {
60		case 'topleft':
61		$x = 0;
62		$y = 0;
63		break;
64		case 'top':
65		$x = ($size->getWidth() - $watermarkSize->getWidth()) / 2;
66		$y = 0;
67		break;
68		case 'topright':
69		$x = $size->getWidth() - $watermarkSize->getWidth();
70		$y = 0;
71		break;
72		case 'left':
73		$x = 0;
74		$y = ($size->getHeight() - $watermarkSize->getHeight()) / 2;
75		break;
76	View Code Duplication	case 'center':
		0 ignored issues – show Duplication introduced 2015-11-24 10:50 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
77		$x = ($size->getWidth() - $watermarkSize->getWidth()) / 2;
78		$y = ($size->getHeight() - $watermarkSize->getHeight()) / 2;
79		break;
80	View Code Duplication	case 'right':
		0 ignored issues – show Duplication introduced 2015-11-24 10:50 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
81		$x = $size->getWidth() - $watermarkSize->getWidth();
82		$y = ($size->getHeight() - $watermarkSize->getHeight()) / 2;
83		break;
84		case 'bottomleft':
85		$x = 0;
86		$y = $size->getHeight() - $watermarkSize->getHeight();
87		break;
88	View Code Duplication	case 'bottom':
		0 ignored issues – show Duplication introduced 2015-11-24 10:50 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
89		$x = ($size->getWidth() - $watermarkSize->getWidth()) / 2;
90		$y = $size->getHeight() - $watermarkSize->getHeight();
91		break;
92	View Code Duplication	case 'bottomright':
		0 ignored issues – show Duplication introduced 2015-11-24 10:50 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
93		$x = $size->getWidth() - $watermarkSize->getWidth();
94		$y = $size->getHeight() - $watermarkSize->getHeight();
95		break;
96		default:
97		throw new \InvalidArgumentException("Unexpected position '{$options['position']}'");
98		break;
		0 ignored issues – show Unused Code introduced 2015-11-24 10:50 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
99		}
100
101		return $image->paste($watermark, new Point($x, $y));
102		}
103		}
104

liip / LiipImagineBundle

Pull Request — master (#732)

WatermarkFilterLoader::load() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like