Configuration::__construct() - Code Metrics - Inspection of "add @Event annotation to let IDEs known event name..." - liip/LiipImagineBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#732)

by 12345

created 2016-05-05 10:14 UTC

Configuration::__construct() A

↳ Parent: Configuration

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	5
rs	9.4285
cc	1
eloc	3
nc	1
nop	2

<?php

namespace Liip\ImagineBundle\DependencyInjection;

use Liip\ImagineBundle\DependencyInjection\Factory\Loader\LoaderFactoryInterface;
use Liip\ImagineBundle\DependencyInjection\Factory\Resolver\ResolverFactoryInterface;
use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;
use Symfony\Component\Config\Definition\ConfigurationInterface;

class Configuration implements ConfigurationInterface
{
    /**
     * @var ResolverFactoryInterface[]
     */
    protected $resolversFactories;

    /**
     * @var LoaderFactoryInterface[]
     */
    protected $loadersFactories;

    /**
     * @param ResolverFactoryInterface[] $resolversFactories
     * @param LoaderFactoryInterface[]   $loadersFactories
     */
    public function __construct(array $resolversFactories, array $loadersFactories)
    {
        $this->resolversFactories = $resolversFactories;
        $this->loadersFactories = $loadersFactories;
    }

    /**
     * {@inheritdoc}
     */
    public function getConfigTreeBuilder()
    {
        $treeBuilder = new TreeBuilder();
        $rootNode = $treeBuilder->root('liip_imagine', 'array');

        $resolversPrototypeNode = $rootNode
            ->children()
                ->arrayNode('resolvers')
                    ->useAttributeAsKey('name')
                    ->prototype('array')
                        ->performNoDeepMerging()
        ;
        $this->addResolversSections($resolversPrototypeNode);

        $loadersPrototypeNode = $rootNode
            ->children()
                ->arrayNode('loaders')
                    ->useAttributeAsKey('name')
                    ->prototype('array')
        ;
        $this->addLoadersSections($loadersPrototypeNode);

        $rootNode
            ->beforeNormalization()
                ->ifTrue(function ($v) {
                    return
                        empty($v['loaders']) ||
                        empty($v['loaders']['default']) ||
                        empty($v['resolvers']) ||
                        empty($v['resolvers']['default'])
                    ;
                })
                ->then(function ($v) {
                    if (empty($v['loaders'])) {
                        $v['loaders'] = array();
                    }

                    if (false == is_array($v['loaders'])) {

                        throw new \LogicException('Loaders has to be array');
                    }

                    if (false == array_key_exists('default', $v['loaders'])) {

                        $v['loaders']['default'] = array('filesystem' => null);
                    }

                    if (empty($v['resolvers'])) {
                        $v['resolvers'] = array();
                    }

                    if (false == is_array($v['resolvers'])) {

                        throw new \LogicException('Resolvers has to be array');
                    }

                    if (false == array_key_exists('default', $v['resolvers'])) {

                        $v['resolvers']['default'] = array('web_path' => null);
                    }

                    return $v;
                })
            ->end()
        ;

        $rootNode
            ->fixXmlConfig('filter_set', 'filter_sets')
            ->children()
                ->scalarNode('driver')->defaultValue('gd')
                    ->validate()
                        ->ifTrue(function ($v) { return !in_array($v, array('gd', 'imagick', 'gmagick')); })
                        ->thenInvalid('Invalid imagine driver specified: %s')
                    ->end()
                ->end()
                ->scalarNode('cache')->defaultValue('default')->end()
                ->scalarNode('cache_base_path')->defaultValue('')->end()
                ->scalarNode('data_loader')->defaultValue('default')->end()
                ->scalarNode('default_image')->defaultNull()->end()
                ->arrayNode('controller')
                    ->addDefaultsIfNotSet()
                    ->children()
                        ->scalarNode('filter_action')->defaultValue('liip_imagine.controller:filterAction')->end()
                        ->scalarNode('filter_runtime_action')->defaultValue('liip_imagine.controller:filterRuntimeAction')->end()
                    ->end()
                ->end()
                ->arrayNode('filter_sets')
                    ->useAttributeAsKey('name')
                    ->prototype('array')
                        ->fixXmlConfig('filter', 'filters')
                        ->children()
                            ->scalarNode('quality')->defaultValue(100)->end()
                            ->scalarNode('jpeg_quality')->defaultNull()->end()
                            ->scalarNode('png_compression_level')->defaultNull()->end()
                            ->scalarNode('png_compression_filter')->defaultNull()->end()
                            ->scalarNode('format')->defaultNull()->end()
                            ->booleanNode('animated')->defaultFalse()->end()
                            ->scalarNode('cache')->defaultNull()->end()
                            ->scalarNode('data_loader')->defaultNull()->end()
                            ->scalarNode('default_image')->defaultNull()->end()
                            ->arrayNode('filters')
                                ->useAttributeAsKey('name')
                                ->prototype('array')
                                    ->useAttributeAsKey('name')
                                    ->prototype('variable')->end()
                                ->end()
                            ->end()
                            ->arrayNode('post_processors')
                                ->defaultValue(array())
                                ->useAttributeAsKey('name')
                                ->prototype('array')
                                    ->useAttributeAsKey('name')
                                    ->prototype('variable')->end()
                                ->end()
                        ->end()
                    ->end()
                ->end()
            ->end()
        ->end();

        return $treeBuilder;
    }

    /**
     * @param ArrayNodeDefinition $resolversPrototypeNode
     */
    protected function addResolversSections(ArrayNodeDefinition $resolversPrototypeNode)
    {
        foreach ($this->resolversFactories as $factory) {
            $factory->addConfiguration(
                $resolversPrototypeNode->children()->arrayNode($factory->getName())
            );
        }
    }

    /**
     * @param ArrayNodeDefinition $resolversPrototypeNode
     */
    protected function addLoadersSections(ArrayNodeDefinition $resolversPrototypeNode)
    {
        foreach ($this->loadersFactories as $factory) {
            $factory->addConfiguration(
                $resolversPrototypeNode->children()->arrayNode($factory->getName())
            );
        }
    }
}


1		<?php
2
3		namespace Liip\ImagineBundle\DependencyInjection;
4
5		use Liip\ImagineBundle\DependencyInjection\Factory\Loader\LoaderFactoryInterface;
6		use Liip\ImagineBundle\DependencyInjection\Factory\Resolver\ResolverFactoryInterface;
7		use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
8		use Symfony\Component\Config\Definition\Builder\TreeBuilder;
9		use Symfony\Component\Config\Definition\ConfigurationInterface;
10
11		class Configuration implements ConfigurationInterface
12		{
13		/**
14		* @var ResolverFactoryInterface[]
15		*/
16		protected $resolversFactories;
17
18		/**
19		* @var LoaderFactoryInterface[]
20		*/
21		protected $loadersFactories;
22
23		/**
24		* @param ResolverFactoryInterface[] $resolversFactories
25		* @param LoaderFactoryInterface[] $loadersFactories
26		*/
27		public function __construct(array $resolversFactories, array $loadersFactories)
28		{
29		$this->resolversFactories = $resolversFactories;
30		$this->loadersFactories = $loadersFactories;
31		}
32
33		/**
34		* {@inheritdoc}
35		*/
36		public function getConfigTreeBuilder()
37		{
38		$treeBuilder = new TreeBuilder();
39		$rootNode = $treeBuilder->root('liip_imagine', 'array');
40
41		$resolversPrototypeNode = $rootNode
42		->children()
43		->arrayNode('resolvers')
44		->useAttributeAsKey('name')
45		->prototype('array')
46		->performNoDeepMerging()
47		;
48		$this->addResolversSections($resolversPrototypeNode);
49
50		$loadersPrototypeNode = $rootNode
51		->children()
52		->arrayNode('loaders')
53		->useAttributeAsKey('name')
54		->prototype('array')
55		;
56		$this->addLoadersSections($loadersPrototypeNode);
57
58		$rootNode
59		->beforeNormalization()
60		->ifTrue(function ($v) {
61		return
62		empty($v['loaders']) \|\|
63		empty($v['loaders']['default']) \|\|
64		empty($v['resolvers']) \|\|
65		empty($v['resolvers']['default'])
66		;
67		})
68		->then(function ($v) {
69		if (empty($v['loaders'])) {
70		$v['loaders'] = array();
71		}
72
73		if (false == is_array($v['loaders'])) {
		0 ignored issues – show Coding Style Best Practice introduced 2015-11-24 10:50 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
74		throw new \LogicException('Loaders has to be array');
75		}
76
77	View Code Duplication	if (false == array_key_exists('default', $v['loaders'])) {
		0 ignored issues – show Coding Style Best Practice introduced 2015-11-24 10:50 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history... Duplication introduced 2015-11-24 10:50 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
78		$v['loaders']['default'] = array('filesystem' => null);
79		}
80
81		if (empty($v['resolvers'])) {
82		$v['resolvers'] = array();
83		}
84
85		if (false == is_array($v['resolvers'])) {
		0 ignored issues – show Coding Style Best Practice introduced 2015-11-24 10:50 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
86		throw new \LogicException('Resolvers has to be array');
87		}
88
89	View Code Duplication	if (false == array_key_exists('default', $v['resolvers'])) {
		0 ignored issues – show Coding Style Best Practice introduced 2015-11-24 10:50 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history... Duplication introduced 2015-11-24 10:50 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
90		$v['resolvers']['default'] = array('web_path' => null);
91		}
92
93		return $v;
94		})
95		->end()
96		;
97
98		$rootNode
99		->fixXmlConfig('filter_set', 'filter_sets')
100		->children()
101		->scalarNode('driver')->defaultValue('gd')
102		->validate()
103		->ifTrue(function ($v) { return !in_array($v, array('gd', 'imagick', 'gmagick')); })
104		->thenInvalid('Invalid imagine driver specified: %s')
105		->end()
106		->end()
107		->scalarNode('cache')->defaultValue('default')->end()
108		->scalarNode('cache_base_path')->defaultValue('')->end()
109		->scalarNode('data_loader')->defaultValue('default')->end()
110		->scalarNode('default_image')->defaultNull()->end()
111		->arrayNode('controller')
112		->addDefaultsIfNotSet()
113		->children()
114		->scalarNode('filter_action')->defaultValue('liip_imagine.controller:filterAction')->end()
115		->scalarNode('filter_runtime_action')->defaultValue('liip_imagine.controller:filterRuntimeAction')->end()
116		->end()
117		->end()
118		->arrayNode('filter_sets')
119		->useAttributeAsKey('name')
120		->prototype('array')
121		->fixXmlConfig('filter', 'filters')
122		->children()
123		->scalarNode('quality')->defaultValue(100)->end()
124		->scalarNode('jpeg_quality')->defaultNull()->end()
125		->scalarNode('png_compression_level')->defaultNull()->end()
126		->scalarNode('png_compression_filter')->defaultNull()->end()
127		->scalarNode('format')->defaultNull()->end()
128		->booleanNode('animated')->defaultFalse()->end()
129		->scalarNode('cache')->defaultNull()->end()
130		->scalarNode('data_loader')->defaultNull()->end()
131		->scalarNode('default_image')->defaultNull()->end()
132		->arrayNode('filters')
133		->useAttributeAsKey('name')
134		->prototype('array')
135		->useAttributeAsKey('name')
136		->prototype('variable')->end()
137		->end()
138		->end()
139		->arrayNode('post_processors')
140		->defaultValue(array())
141		->useAttributeAsKey('name')
142		->prototype('array')
143		->useAttributeAsKey('name')
144		->prototype('variable')->end()
145		->end()
146		->end()
147		->end()
148		->end()
149		->end()
150		->end();
151
152		return $treeBuilder;
153		}
154
155		/**
156		* @param ArrayNodeDefinition $resolversPrototypeNode
157		*/
158		protected function addResolversSections(ArrayNodeDefinition $resolversPrototypeNode)
159		{
160		foreach ($this->resolversFactories as $factory) {
161		$factory->addConfiguration(
162		$resolversPrototypeNode->children()->arrayNode($factory->getName())
163		);
164		}
165		}
166
167		/**
168		* @param ArrayNodeDefinition $resolversPrototypeNode
169		*/
170		protected function addLoadersSections(ArrayNodeDefinition $resolversPrototypeNode)
171		{
172		foreach ($this->loadersFactories as $factory) {
173		$factory->addConfiguration(
174		$resolversPrototypeNode->children()->arrayNode($factory->getName())
175		);
176		}
177		}
178		}
179

liip / LiipImagineBundle

Pull Request — master (#732)

Configuration::__construct() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like