ResolveCache::jsonDeserialize() - Code Metrics - Inspection of "Merge pull request #919 from makasim/resolve-cache..." - liip/LiipImagineBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.0 ( 09dc0e...a109cf )

by Maksim

created 2017-05-07 15:57 UTC

ResolveCache::jsonDeserialize() A

↳ Parent: ResolveCache

Complexity

Conditions	4
Paths	3

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.2
c	0
b	0
f	0
cc	4
eloc	7
nc	3
nop	1

<?php
namespace Liip\ImagineBundle\Async;

use Enqueue\Util\JSON;

class ResolveCache implements \JsonSerializable
{
    /**
     * @var string
     */
    private $path;

    /**
     * @var array|null|\string[]
     */
    private $filters;

    /**
     * @var bool
     */
    private $force;

    /**
     * @param string $path
     * @param string[]|null $filters
     * @param bool $force
     */
    public function __construct($path, array $filters = null, $force = false)
    {
        $this->path = $path;
        $this->filters = $filters;
        $this->force = $force;
    }

    /**
     * @return string
     */
    public function getPath()
    {
        return $this->path;
    }

    /**
     * @return null|\string[]
     */
    public function getFilters()
    {
        return $this->filters;
    }

    /**
     * @return bool
     */
    public function isForce()
    {
        return $this->force;
    }

    /**
     * {@inheritdoc}
     */
    public function jsonSerialize()
    {
        return array('path' => $this->path, 'filters' => $this->filters, 'force' => $this->force);
    }

    /**
     * @param string $json
     *
     * @return static
     */
    public static function jsonDeserialize($json)
    {
        $data = array_replace(array('path' => null, 'filters' => null, 'force' => false), JSON::decode($json));

        if (false == $data['path']) {
            throw new \LogicException('The message does not contain "path" but it is required.');
        }

        if (false == (is_null($data['filters']) || is_array($data['filters']))) {

            throw new \LogicException('The message filters could be either null or array.');
        }

        return new static($data['path'], $data['filters'], $data['force']);
    }
}


1			<?php
2			namespace Liip\ImagineBundle\Async;
3
4			use Enqueue\Util\JSON;
5
6			class ResolveCache implements \JsonSerializable
7			{
8			/**
9			* @var string
10			*/
11			private $path;
12
13			/**
14			* @var array\|null\|\string[]
15			*/
16			private $filters;
17
18			/**
19			* @var bool
20			*/
21			private $force;
22
23			/**
24			* @param string $path
25			* @param string[]\|null $filters
26			* @param bool $force
27			*/
28			public function __construct($path, array $filters = null, $force = false)
29			{
30			$this->path = $path;
31			$this->filters = $filters;
32			$this->force = $force;
33			}
34
35			/**
36			* @return string
37			*/
38			public function getPath()
39			{
40			return $this->path;
41			}
42
43			/**
44			* @return null\|\string[]
45			*/
46			public function getFilters()
47			{
48			return $this->filters;
49			}
50
51			/**
52			* @return bool
53			*/
54			public function isForce()
55			{
56			return $this->force;
57			}
58
59			/**
60			* {@inheritdoc}
61			*/
62			public function jsonSerialize()
63			{
64			return array('path' => $this->path, 'filters' => $this->filters, 'force' => $this->force);
65			}
66
67			/**
68			* @param string $json
69			*
70			* @return static
71			*/
72			public static function jsonDeserialize($json)
73			{
74			$data = array_replace(array('path' => null, 'filters' => null, 'force' => false), JSON::decode($json));
75
76			if (false == $data['path']) {
77			throw new \LogicException('The message does not contain "path" but it is required.');
78			}
79
80			if (false == (is_null($data['filters']) \|\| is_array($data['filters']))) {
			0 ignored issues – show Coding Style Best Practice introduced 2017-05-04 10:28 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
81			throw new \LogicException('The message filters could be either null or array.');
82			}
83
84			return new static($data['path'], $data['filters'], $data['force']);
85			}
86			}
87

liip / LiipImagineBundle

Push — 1.0 ( 09dc0e...a109cf )

ResolveCache::jsonDeserialize() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like