Liip\ImagineBundle\DependencyInjection\Compiler\NonFunctionalFilterExceptionPass::process()

Complexity

Conditions	8
Paths	12

Size

Total Lines

37

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function process(ContainerBuilder $container)
    {
        $canFiltersStillFunction = $container->hasParameter('kernel.root_dir');
        $throwWarning = function (string $filterName) use ($canFiltersStillFunction) {
            $message = sprintf(
                'The "%s" filter %s in Symfony 5.0. Please use "%s_image" and adapt the "image" option to be relative to the "%%kernel.project_dir%%" instead of "%%kernel.root_dir%%".',
                $filterName,
                $canFiltersStillFunction ? 'is deprecated and will not work' : 'no longer works',
                $filterName
            );

            if ($canFiltersStillFunction) {
                @trigger_error($message, E_USER_DEPRECATED);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            } else {
                throw new \InvalidArgumentException($message);
            }
        };

        $filterSets = $container->getParameter('liip_imagine.filter_sets');
        foreach ($filterSets as $filterSet) {
            foreach ($filterSet['filters'] as $filterName => $filter) {
                if ('paste' === $filterName) {
                    $throwWarning('paste');
                }

                if ('watermark' === $filterName) {
                    $throwWarning('watermark');
                }
            }
        }

        // remove the definitions entirely if kernel.root_dir does not exist
        if (!$canFiltersStillFunction) {
            $container->removeDefinition('liip_imagine.filter.loader.watermark');
            $container->removeDefinition('liip_imagine.filter.loader.paste');
        }
    }
}