RunParatestCommand::configure() - Code Metrics - Inspection of "Merge pull request #547 from phillipsb22/documenta..." - liip/LiipFunctionalTestBundle - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( d3f723...421eba )

by Alexis

created 2019-11-21 13:11 UTC

RunParatestCommand::configure() A

↳ Parent: RunParatestCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	0
cts	8
cp	0
rs	9.9666
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	2

<?php

declare(strict_types=1);

/*
 * This file is part of the Liip/FunctionalTestBundle
 *
 * (c) Lukas Kahwe Smith <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Liip\FunctionalTestBundle\Command;

use Symfony\Bundle\FrameworkBundle\Console\Application;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\DependencyInjection\ContainerAwareInterface;
use Symfony\Component\DependencyInjection\ContainerAwareTrait;
use Symfony\Component\Process\Process;

/**
 * Command used to update the project.
 */
class RunParatestCommand extends Command implements ContainerAwareInterface
{
    use ContainerAwareTrait;

    private $output;

    private $process;

    private $testDbPath;

    private $phpunit;

    /**
     * Configuration of the command.
     */
    protected function configure(): void
    {
        $this
            ->setName('paratest:run')
            ->setDescription('Run phpunit tests with multiple processes')
            // Pass arguments from this command "paratest:run" to the paratest command.
            ->addArgument('options', InputArgument::OPTIONAL, 'Options')
        ;
    }

    protected function prepare(): void
    {
        $this->phpunit = $this->container->getParameter('liip_functional_test.paratest.phpunit');
        $this->process = $this->container->getParameter('liip_functional_test.paratest.process');

        $this->testDbPath = $this->container->get('kernel')->getCacheDir();
        $this->output->writeln("Cleaning old dbs in $this->testDbPath ...");
        $createDirProcess = new Process('mkdir -p '.$this->testDbPath);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $createDirProcess->run();
        $cleanProcess = new Process("rm -fr $this->testDbPath/dbTest.db $this->testDbPath/dbTest*.db*");
        $cleanProcess->run();
        $this->output->writeln("Creating Schema in $this->testDbPath ...");
        $application = new Application($this->container->get('kernel'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $input = new ArrayInput(['doctrine:schema:create', '--env' => 'test']);
        $application->run($input, $this->output);

        $this->output->writeln('Initial schema created');
        $input = new ArrayInput([
            'doctrine:fixtures:load',
            '-n' => '',
            '--env' => 'test',
        ]);
        $application->run($input, $this->output);

        $this->output->writeln('Initial schema populated, duplicating....');
        for ($a = 0; $a < $this->process; ++$a) {
            $test = new Process("cp $this->testDbPath/dbTest.db ".$this->testDbPath."/dbTest$a.db");
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $test->run();
        }
    }

    /**
     * Content of the command.
     *
     * @param InputInterface  $input
     * @param OutputInterface $output
     */
    protected function execute(InputInterface $input, OutputInterface $output): void
    {
        $this->output = $output;
        $this->prepare();
        if (true !== is_file('vendor/bin/paratest')) {
            $this->output->writeln('Error : Install paratest first');
        } else {
            $this->output->writeln('Done...Running test.');
            $runProcess = new Process('vendor/bin/paratest '.
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                '-c phpunit.xml.dist '.
                '--phpunit '.$this->phpunit.' '.
                '--runner WrapRunner '.
                '-p '.$this->process.' '.
                $input->getArgument('options')
            );
            $runProcess->run(function ($type, $buffer) use ($output): void {
                $output->write($buffer);
            });
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Liip/FunctionalTestBundle
7			*
8			* (c) Lukas Kahwe Smith <[email protected]>
9			*
10			* This source file is subject to the MIT license that is bundled
11			* with this source code in the file LICENSE.
12			*/
13
14			namespace Liip\FunctionalTestBundle\Command;
15
16			use Symfony\Bundle\FrameworkBundle\Console\Application;
17			use Symfony\Component\Console\Command\Command;
18			use Symfony\Component\Console\Input\ArrayInput;
19			use Symfony\Component\Console\Input\InputArgument;
20			use Symfony\Component\Console\Input\InputInterface;
21			use Symfony\Component\Console\Output\OutputInterface;
22			use Symfony\Component\DependencyInjection\ContainerAwareInterface;
23			use Symfony\Component\DependencyInjection\ContainerAwareTrait;
24			use Symfony\Component\Process\Process;
25
26			/**
27			* Command used to update the project.
28			*/
29			class RunParatestCommand extends Command implements ContainerAwareInterface
30			{
31			use ContainerAwareTrait;
32
33			private $output;
34
35			private $process;
36
37			private $testDbPath;
38
39			private $phpunit;
40
41			/**
42			* Configuration of the command.
43			*/
44			protected function configure(): void
45			{
46			$this
47			->setName('paratest:run')
48			->setDescription('Run phpunit tests with multiple processes')
49			// Pass arguments from this command "paratest:run" to the paratest command.
50			->addArgument('options', InputArgument::OPTIONAL, 'Options')
51			;
52			}
53
54			protected function prepare(): void
55			{
56			$this->phpunit = $this->container->getParameter('liip_functional_test.paratest.phpunit');
57			$this->process = $this->container->getParameter('liip_functional_test.paratest.process');
58
59			$this->testDbPath = $this->container->get('kernel')->getCacheDir();
60			$this->output->writeln("Cleaning old dbs in $this->testDbPath ...");
61			$createDirProcess = new Process('mkdir -p '.$this->testDbPath);
			0 ignored issues – show Documentation introduced 2019-05-10 22:21 UTC by Report Bug Copy Issue Report `'mkdir -p ' . $this->testDbPath` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
62			$createDirProcess->run();
63			$cleanProcess = new Process("rm -fr $this->testDbPath/dbTest.db $this->testDbPath/dbTest.db");
64			$cleanProcess->run();
65			$this->output->writeln("Creating Schema in $this->testDbPath ...");
66			$application = new Application($this->container->get('kernel'));
			0 ignored issues – show Documentation introduced 2019-09-06 22:22 UTC by Report Bug Copy Issue Report `$this->container->get('kernel')` is of type `object\|null`, but the function expects a `object<Symfony\Component...Kernel\KernelInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
67			$input = new ArrayInput(['doctrine:schema:create', '--env' => 'test']);
68			$application->run($input, $this->output);
69
70			$this->output->writeln('Initial schema created');
71			$input = new ArrayInput([
72			'doctrine:fixtures:load',
73			'-n' => '',
74			'--env' => 'test',
75			]);
76			$application->run($input, $this->output);
77
78			$this->output->writeln('Initial schema populated, duplicating....');
79			for ($a = 0; $a < $this->process; ++$a) {
80			$test = new Process("cp $this->testDbPath/dbTest.db ".$this->testDbPath."/dbTest$a.db");
			0 ignored issues – show Documentation introduced 2019-05-10 22:21 UTC by Report Bug Copy Issue Report `"cp {$this->testDbPath}/...Path . "/dbTest{$a}.db"` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
81			$test->run();
82			}
83			}
84
85			/**
86			* Content of the command.
87			*
88			* @param InputInterface $input
89			* @param OutputInterface $output
90			*/
91			protected function execute(InputInterface $input, OutputInterface $output): void
92			{
93			$this->output = $output;
94			$this->prepare();
95			if (true !== is_file('vendor/bin/paratest')) {
96			$this->output->writeln('Error : Install paratest first');
97			} else {
98			$this->output->writeln('Done...Running test.');
99			$runProcess = new Process('vendor/bin/paratest '.
			0 ignored issues – show Documentation introduced 2019-05-10 22:21 UTC by Report Bug Copy Issue Report `'vendor/bin/paratest ' ....>getArgument('options')` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
100			'-c phpunit.xml.dist '.
101			'--phpunit '.$this->phpunit.' '.
102			'--runner WrapRunner '.
103			'-p '.$this->process.' '.
104			$input->getArgument('options')
105			);
106			$runProcess->run(function ($type, $buffer) use ($output): void {
107			$output->write($buffer);
108			});
109			}
110			}
111			}
112

liip / LiipFunctionalTestBundle

Push — master ( d3f723...421eba )

RunParatestCommand::configure() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like