QueryCountClientSymfony3Trait::request() - Code Metrics - Inspection of "Merge pull request #549 from liip/don-t-install-mo..." - liip/LiipFunctionalTestBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 421eba...09fd73 )

by Alexis

created 2019-11-21 15:50 UTC

QueryCountClientSymfony3Trait::request() A

↳ Parent: QueryCountClientSymfony3Trait

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	14
Ratio	100 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	14
loc	14
ccs	4
cts	4
cp	1
rs	9.7998
c	0
b	0
f	0
cc	1
nc	1
nop	7
crap	1

<?php

declare(strict_types=1);

/*
 * This file is part of the Liip/FunctionalTestBundle
 *
 * (c) Lukas Kahwe Smith <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Liip\FunctionalTestBundle;

/**
 * @author Sullivan Senechal <[email protected]>
 *
 * @internal
 */
trait QueryCountClientSymfony3Trait

{
    public function request(
        $method,
        $uri,
        array $parameters = [],
        array $files = [],
        array $server = [],
        $content = null,
        $changeHistory = true
    ) {
        $crawler = parent::request($method, $uri, $parameters, $files, $server, $content, $changeHistory);
        $this->checkQueryCount();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $crawler;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Liip/FunctionalTestBundle
7			*
8			* (c) Lukas Kahwe Smith <[email protected]>
9			*
10			* This source file is subject to the MIT license that is bundled
11			* with this source code in the file LICENSE.
12			*/
13
14			namespace Liip\FunctionalTestBundle;
15
16			/**
17			* @author Sullivan Senechal <[email protected]>
18			*
19			* @internal
20			*/
21		View Code Duplication	trait QueryCountClientSymfony3Trait
			0 ignored issues – show Duplication introduced 2019-07-08 21:21 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22			{
23	5		public function request(
24			$method,
25			$uri,
26			array $parameters = [],
27			array $files = [],
28			array $server = [],
29			$content = null,
30			$changeHistory = true
31			) {
32	5		$crawler = parent::request($method, $uri, $parameters, $files, $server, $content, $changeHistory);
33	5		$this->checkQueryCount();
			0 ignored issues – show Bug introduced 2019-07-08 21:21 UTC by Report Bug Copy Issue Report It seems like `checkQueryCount()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
34
35	3		return $crawler;
36			}
37			}
38

liip / LiipFunctionalTestBundle

Push — master ( 421eba...09fd73 )

QueryCountClientSymfony3Trait::request() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like