QueryCountClient::request() - Code Metrics - Inspection of "Merge pull request #236 from alexislefebvre/fix-bu..." - liip/LiipFunctionalTestBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b65e46...1382ed )

by Lukas Kahwe

created 2016-02-02 21:30 UTC

QueryCountClient::request() B

↳ Parent: QueryCountClient

Complexity

Conditions	2
Paths	2

Size

Total Lines	27
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	27
ccs	8
cts	8
cp	1
rs	8.8571
cc	2
eloc	19
nc	2
nop	7
crap	2

<?php

namespace Liip\FunctionalTestBundle;

use Symfony\Bundle\FrameworkBundle\Client;

class QueryCountClient extends Client
{
    /** @var QueryCounter */
    private $queryCounter;

    public function setQueryCounter(QueryCounter $queryCounter)
    {
        $this->queryCounter = $queryCounter;
    }

    public function request(
        $method,
        $uri,
        array $parameters = array(),
        array $files = array(),
        array $server = array(),
        $content = null,
        $changeHistory = true
    ) {
        $crawler = parent::request($method, $uri, $parameters, $files, $server, $content, $changeHistory);

        if ($this->getProfile()) {
            $this->queryCounter->checkQueryCount(
                $this->getProfile()->getCollector('db')->getQueryCount()
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            );
        } else {
            // @codeCoverageIgnoreStart
            echo "\n".
                'Profiler is disabled, it must be enabled for the '.
                'Query Counter. '.
                'See https://github.com/liip/LiipFunctionalTestBundle#query-counter'.
                "\n";
            // @codeCoverageIgnoreEnd
        }

        return $crawler;
    }
}


1		<?php
2
3		namespace Liip\FunctionalTestBundle;
4
5		use Symfony\Bundle\FrameworkBundle\Client;
6
7		class QueryCountClient extends Client
8		{
9		/** @var QueryCounter */
10		private $queryCounter;
11
12	11	public function setQueryCounter(QueryCounter $queryCounter)
13		{
14	11	$this->queryCounter = $queryCounter;
15	11	}
16
17	5	public function request(
18		$method,
19		$uri,
20		array $parameters = array(),
21		array $files = array(),
22		array $server = array(),
23		$content = null,
24		$changeHistory = true
25		) {
26	5	$crawler = parent::request($method, $uri, $parameters, $files, $server, $content, $changeHistory);
27
28	5	if ($this->getProfile()) {
29	5	$this->queryCounter->checkQueryCount(
30	5	$this->getProfile()->getCollector('db')->getQueryCount()
		0 ignored issues – show Bug introduced 2016-01-08 23:36 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\HttpKe...\DataCollectorInterface` as the method `getQueryCount()` does only exist in the following implementations of said interface: `Doctrine\Bundle\Doctrine...r\DoctrineDataCollector`, `Symfony\Bridge\Doctrine\...r\DoctrineDataCollector`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
31	5	);
32	3	} else {
33		// @codeCoverageIgnoreStart
34		echo "\n".
35		'Profiler is disabled, it must be enabled for the '.
36		'Query Counter. '.
37		'See https://github.com/liip/LiipFunctionalTestBundle#query-counter'.
38		"\n";
39		// @codeCoverageIgnoreEnd
40		}
41
42	3	return $crawler;
43		}
44		}
45

liip / LiipFunctionalTestBundle

Push — master ( b65e46...1382ed )

QueryCountClient::request() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like