Linder\Controller\IpVerifierController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	indexAction()	0	22	2

<?php

namespace Linder\Controller;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;
use Linder\Model\IpVerifier;

/**
 * A controller that handles a get request
 * and returns if its a valid ip or not.
 * @return Object
 */
class IpVerifierController implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;

    /**
     * This is the index method action, it handles:
     *
     * @return object
     */
    public function indexAction() : object
    {
        $page = $this->di->get("page");

        $ip = $this->di->request->getGet("ip") ?: $this->di->request->getServer("REMOTE_ADDR");

Accessing request on the interface Psr\Container\ContainerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $res = $this->di->get("ipverifier")->getJson($ip);

        $data = [
            "ip" => $ip,
            "domain" => $res["domain"],
            "protocol" => $res["type"],
            "lat" => $res["latitude"],
            "lon" => $res["longitude"],
            "country" => $res["country_name"],
            "city" => $res["city"]
        ];

        $page->add("ipverifier/main", $data);

        return $page->render([
            "title" => "Ipverifier",
        ]);
    }
}