lightspeeddevelopment /
wetu-importer
| Total Complexity | 47 |
| Total Lines | 262 |
| Duplicated Lines | 0 % |
| Changes | 12 | ||
| Bugs | 0 | Features | 0 |
Complex classes like Cron often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Cron, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 17 | class Cron { |
||
| 18 | |||
| 19 | /** |
||
| 20 | * Holds class instance |
||
| 21 | * |
||
| 22 | * @since 1.0.0 |
||
| 23 | * |
||
| 24 | * @var object|Module_Template |
||
|
|
|||
| 25 | */ |
||
| 26 | protected static $instance = null; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * Initialize the plugin by setting localization, filters, and administration functions. |
||
| 30 | * |
||
| 31 | * @since 1.0.0 |
||
| 32 | * |
||
| 33 | * @access private |
||
| 34 | */ |
||
| 35 | public function __construct() { |
||
| 36 | add_filter( 'cron_schedules', array( $this, 'register_schedule' ), 10, 1 ); |
||
| 37 | add_action( 'lsx_wetu_importer_settings_before', array( $this, 'watch_for_trigger' ), 200 ); |
||
| 38 | add_action( 'lsx_wetu_accommodation_images_cron', array( $this, 'process' ), 10, 1 ); |
||
| 39 | add_action( 'lsx_wetu_accommodation_images_sync', array( $this, 'cron_callback' ), 10, 1 ); |
||
| 40 | add_filter( 'cmb_meta_boxes', array( $this, 'custom_image_metabox' ), 10, 1 ); |
||
| 41 | } |
||
| 42 | |||
| 43 | /** |
||
| 44 | * Return an instance of this class. |
||
| 45 | * |
||
| 46 | * @since 1.0.0 |
||
| 47 | * |
||
| 48 | * @return object Cron() A single instance of this class. |
||
| 49 | */ |
||
| 50 | public static function get_instance() { |
||
| 51 | // If the single instance hasn't been set, set it now. |
||
| 52 | if ( null === self::$instance ) { |
||
| 53 | self::$instance = new self(); |
||
| 54 | } |
||
| 55 | return self::$instance; |
||
| 56 | } |
||
| 57 | |||
| 58 | public function custom_image_metabox( &$meta_boxes ) { |
||
| 59 | |||
| 60 | $fields = array( |
||
| 61 | /** |
||
| 62 | * Single Checkbox Field. |
||
| 63 | */ |
||
| 64 | array( |
||
| 65 | 'id' => 'field-checkbox', |
||
| 66 | 'name' => 'Checkbox field', |
||
| 67 | 'type' => 'checkbox', |
||
| 68 | ), |
||
| 69 | ); |
||
| 70 | /** |
||
| 71 | * Metabox instantiation. |
||
| 72 | */ |
||
| 73 | $meta_boxes[] = array( |
||
| 74 | 'title' => __( 'WETU Settings', 'lsx-wetu-importer' ), |
||
| 75 | 'pages' => 'accommodation', |
||
| 76 | 'fields' => $fields, |
||
| 77 | ); |
||
| 78 | return $meta_boxes; |
||
| 79 | } |
||
| 80 | |||
| 81 | /** |
||
| 82 | * Registers a 5 min schedule for us to use. |
||
| 83 | * |
||
| 84 | * @param array $schedules |
||
| 85 | * @return array |
||
| 86 | */ |
||
| 87 | public function register_schedule( $schedules ) { |
||
| 88 | $schedules['wetu-5-minutes'] = array( |
||
| 89 | 'interval' => 5 * MINUTE_IN_SECONDS, |
||
| 90 | 'display' => __( 'Every 5 minutes', 'lsx-wetu-importer' ), |
||
| 91 | ); |
||
| 92 | return $schedules; |
||
| 93 | } |
||
| 94 | |||
| 95 | /** |
||
| 96 | * Watches for changes in the button triggers. |
||
| 97 | * |
||
| 98 | * @return void |
||
| 99 | */ |
||
| 100 | public function watch_for_trigger() { |
||
| 101 | |||
| 102 | if ( isset( $_GET['page'] ) && 'lsx-wetu-importer' === $_GET['page'] && isset( $_GET['tab'] ) && 'settings' === $_GET['tab'] ) { |
||
| 103 | $options = lsx_wetu_get_options(); |
||
| 104 | |||
| 105 | // Check what state the option is in. |
||
| 106 | $accommodation_cron = 'deactivate'; |
||
| 107 | if ( isset( $options['accommodation_images_cron'] ) && '' !== $options['accommodation_images_cron'] ) { |
||
| 108 | $accommodation_cron = 'activate'; |
||
| 109 | } |
||
| 110 | |||
| 111 | // Check what state the cron is in. |
||
| 112 | $scheduled = false; |
||
| 113 | if ( wp_next_scheduled( 'lsx_wetu_accommodation_images_cron' ) ) { |
||
| 114 | $scheduled = true; |
||
| 115 | } |
||
| 116 | |||
| 117 | // If activate and its not running. |
||
| 118 | if ( false === $scheduled && 'activate' === $accommodation_cron ) { |
||
| 119 | $schedule = 'weekly'; |
||
| 120 | $this->schedule( 'lsx_wetu_accommodation_images_cron', $schedule ); |
||
| 121 | } elseif ( true === $scheduled && 'deactivate' === $accommodation_cron ) { |
||
| 122 | $this->deactivate(); |
||
| 123 | } |
||
| 124 | } |
||
| 125 | } |
||
| 126 | |||
| 127 | /** |
||
| 128 | * Remove our cron from the shedule. |
||
| 129 | * |
||
| 130 | * @return void |
||
| 131 | */ |
||
| 132 | public function deactivate( $task = 'lsx_wetu_accommodation_images_cron' ) { |
||
| 133 | wp_clear_scheduled_hook( $task, array( $task ) ); |
||
| 134 | } |
||
| 135 | |||
| 136 | /** |
||
| 137 | * This function will schedule the cron event. |
||
| 138 | * |
||
| 139 | * @param string $task |
||
| 140 | * @param string $schedule |
||
| 141 | * @param string $time |
||
| 142 | * @return void |
||
| 143 | */ |
||
| 144 | public function schedule( $task = 'lsx_wetu_accommodation_images_cron', $schedule = 'weekly', $time = 'Sunday 10pm' ) { |
||
| 145 | $args = array( $task ); |
||
| 146 | if ( '' === $time ) { |
||
| 147 | $time = time(); |
||
| 148 | } |
||
| 149 | |||
| 150 | if ( isset( $_GET['accommodation_images_cron_featured'] ) && '' !== $_GET['accommodation_images_cron_featured'] ) { |
||
| 151 | $args[] = 'featured_image'; |
||
| 152 | } |
||
| 153 | wp_schedule_event( $time, $schedule, $task, $args ); |
||
| 154 | } |
||
| 155 | |||
| 156 | /** |
||
| 157 | * This is the function that will be triggered by the cron event. |
||
| 158 | * |
||
| 159 | * @return void |
||
| 160 | */ |
||
| 161 | public function process( $task = '' ) { |
||
| 162 | switch ( $task ) { |
||
| 163 | case 'lsx_wetu_accommodation_images_cron': |
||
| 164 | $this->register_accommodation_images_sync(); |
||
| 165 | break; |
||
| 166 | |||
| 167 | default: |
||
| 168 | break; |
||
| 169 | } |
||
| 170 | } |
||
| 171 | |||
| 172 | /** |
||
| 173 | * This is the function that will be triggered by the cron event. |
||
| 174 | * |
||
| 175 | * @return void |
||
| 176 | */ |
||
| 177 | public function register_accommodation_images_sync() { |
||
| 178 | $time = strtotime( '+5 min' ); |
||
| 179 | if ( ! wp_next_scheduled( 'lsx_wetu_accommodation_images_sync' ) ) { |
||
| 180 | $this->load_items_to_sync( 'accommodation_images' ); |
||
| 181 | $this->schedule( 'lsx_wetu_accommodation_images_sync', 'wetu-5-minutes', $time ); |
||
| 182 | } |
||
| 183 | } |
||
| 184 | |||
| 185 | /** |
||
| 186 | * This is the function that will be triggered by the cron event. |
||
| 187 | * |
||
| 188 | * @return void |
||
| 189 | */ |
||
| 190 | public function cron_callback( $task = '', $featured_image = '' ) { |
||
| 191 | $has_accommodation = get_option( $task ); |
||
| 192 | if ( false !== $has_accommodation && ! empty( $has_accommodation ) ) { |
||
| 193 | $next_time = array_slice( $has_accommodation, 5 ); |
||
| 194 | $this_time = array_slice( $has_accommodation, 0, 4 ); |
||
| 195 | |||
| 196 | $api_key = $this->get_api_key(); |
||
| 197 | $url = 'https://wetu.com/API/Pins/' . $api_key . '/Get?all=include&ids='; |
||
| 198 | |||
| 199 | // Run through the current items. |
||
| 200 | foreach ( $this_time as $accommodation ) { |
||
| 201 | $wetu_id = get_post_meta( $accommodation, 'lsx_wetu_id', true ); |
||
| 202 | $last_date = get_post_meta( $accommodation, 'lsx_wetu_modified_date', true ); |
||
| 203 | |||
| 204 | $accommodation_info = wp_remote_get( $url . $wetu_id ); |
||
| 205 | if ( ! empty( $accommodation_info ) && isset( $accommodation_info['response'] ) && isset( $accommodation_info['response']['code'] ) && 200 === $accommodation_info['response']['code'] ) { |
||
| 206 | $adata = json_decode( $accommodation_info['body'], true ); |
||
| 207 | |||
| 208 | if ( isset( $adata[0] ) && isset( $adata[0]['last_modified'] ) && '' !== $adata[0]['last_modified'] ) { |
||
| 209 | $modified_time = strtotime( $adata[0]['last_modified'] ); |
||
| 210 | if ( $modified_time > $last_date ) { |
||
| 211 | $accommodation_importer = new \LSX_WETU_Importer_Accommodation(); |
||
| 212 | $accommodation_importer->create_main_gallery( $adata, $accommodation ); |
||
| 213 | if ( '' !== $featured_image ) { |
||
| 214 | $accommodation_importer->set_featured_image( $adata, $accommodation ); |
||
| 215 | } |
||
| 216 | update_post_meta( $accommodation, 'lsx_wetu_modified_date', $modified_time, $last_date ); |
||
| 217 | } |
||
| 218 | } |
||
| 219 | } |
||
| 220 | } |
||
| 221 | |||
| 222 | // Save the values for next time. |
||
| 223 | if ( ! empty( $next_time ) ) { |
||
| 224 | update_option( $task, $next_time ); |
||
| 225 | } else { |
||
| 226 | delete_option( $task ); |
||
| 227 | $this->deactivate( $task ); |
||
| 228 | } |
||
| 229 | } else { |
||
| 230 | $this->deactivate( $task ); |
||
| 231 | update_option( 'lsx_wetu_nexttime', $task ); |
||
| 232 | } |
||
| 233 | } |
||
| 234 | |||
| 235 | /** |
||
| 236 | * This will grab the accommodation ids and load them up into an option field. |
||
| 237 | * |
||
| 238 | * @param string $task |
||
| 239 | * @return void |
||
| 240 | */ |
||
| 241 | public function load_items_to_sync( $task = 'accommodation_images' ) { |
||
| 259 | } |
||
| 260 | } |
||
| 261 | |||
| 262 | /** |
||
| 263 | * Gets the API key stored in the options table. |
||
| 264 | * |
||
| 265 | * @return string |
||
| 266 | */ |
||
| 267 | public function get_api_key() { |
||
| 279 | } |
||
| 280 | } |
||
| 281 | Cron::get_instance(); |
||
| 282 |
Loading history...
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths