LSX_WETU_Importer_Banner_Integration

Complexity

Total Complexity

32

Size/Duplication

Total Lines	279
Duplicated Lines	0 %

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
B	display_page()	0	129	7
B	sync_new_banner()	0	31	8
B	attach_external_image2()	0	52	11
A	format_filename()	0	17	4
A	format_wetu_url()	0	2	1

<?php

This file is missing a doc comment.

/**

Missing short description in doc comment

 * @package   LSX_WETU_Importer_Banner_Integration
 * @author    LightSpeed
 * @license   GPL-2.0+
 * @link
 * @copyright 2016 LightSpeed
 **/

There must be no blank lines after the class comment

class LSX_WETU_Importer_Banner_Integration extends LSX_WETU_Importer {

	/**
	 * The url to list items from WETU
	 *
	 * @since 0.0.1
	 *
	 * @var      string
	 */
	public $tab_slug = 'banners';

	/**
	 * Initialize the plugin by setting localization, filters, and administration functions.
	 *
	 * @since 1.0.0
	 *
	 * @access private
	 */
	public function __construct() {

Expected 2 blank lines before function; 1 found

		add_action( 'wp_ajax_lsx_import_sync_banners', array( $this, 'sync_new_banner' ) );
		add_action( 'wp_ajax_nopriv_lsx_import_sync_banners', array( $this, 'sync_new_banner' ) );
	}

Expected 1 blank line before closing function brace; 0 found

Expected 2 blank lines after function; 1 found

	/**
	 * Display the importer administration screen
	 */
	public function display_page() {
		?>
		<div class="wrap">
			<h2><?php esc_html_e( 'Download new banners straight from WETU', 'lsx-wetu-importer' ); ?></h2>

			<form method="get" action="" id="banners-filter">
				<input type="hidden" name="post_type" class="post_type" value="<?php echo esc_attr( $this->tab_slug ); ?>" />

			   <div class="ajax-loader-small" style="display:none;width:100%;text-align:center;">

Found precision alignment of 3 spaces.

					<img style="width:32px;" src="<?php echo esc_url( LSX_WETU_IMPORTER_URL . 'assets/images/ajaxloader.gif' ); ?>" />
				</div>

				<table class="wp-list-table widefat fixed posts">
					<thead>
						<tr>
							<th style="" class="manage-column column-cb check-column" id="cb" scope="col">
								<label for="cb-select-all-1" class="screen-reader-text">Select All</label>
								<input type="checkbox" id="cb-select-all-1">
							</th>
							<th style="width:15%" class="manage-column column-title " id="title" scope="col">Title</th>
							<th style="" class="manage-column column-date" id="date" scope="col">Images</th>
						</tr>
					</thead>

					<?php
						$accommodation_args = array(
							'post_type'      => 'accommodation',
							'post_status'    => array( 'publish', 'pending', 'draft', 'future', 'private' ),
							'nopagin'        => 'true',
							'posts_per_page' => '1000',

Detected high pagination limit, posts_per_page is set to 1000

							'meta_query'     => array(

Detected usage of meta_query, possible slow query.

								'relation' => 'AND',
								array(
									'key'     => 'lsx_wetu_id',
									'compare' => 'EXISTS',
								),
								array(
									'key'     => 'image_group',
									'compare' => 'EXISTS',
								),
								array(
									'key'     => 'image_group',
									'value'   => 'a:1:{s:12:"banner_image";a:0:{}}',
									'compare' => '!=',
								),
							),
						);
						$accommodation      = new WP_Query( $accommodation_args );
						?>

					<tbody id="the-list">
						<?php
						if ( $accommodation->have_posts() ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

							while ( $accommodation->have_posts() ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

								$accommodation->the_post();
								?>
									<tr class="post-<?php the_ID(); ?> type-tour status-none" id="post-<?php the_ID(); ?>">
									<?php
									$banner_size_appropriate = false;
									$min_width               = '1920';
									$min_height              = '500';

									$img_group = get_post_meta( get_the_ID(), 'image_group', true );

It seems like get_the_ID() can also be of type false; however, parameter $post_id of get_post_meta() does only seem to accept integer, maybe add an additional type check?

									$thumbnails_html = false;

									if ( false !== $img_group ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

										foreach ( $img_group['banner_image'] as $banner_image ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

											$large       = wp_get_attachment_image_src( $banner_image, 'full' );
											$real_width  = $large[1];
											$real_height = $large[2];

											$status = 'optimized';
											if ( $real_width < intval( $real_width ) ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

												$status = 'width not enough.';
											}

											$thumbnail         = wp_get_attachment_image_src( $banner_image, 'thumbnail' );
											$thumbnails_html[] = '
													<div style="display:block;float:left;">
														<img src="' . $thumbnail[0] . '" />
														<p style="text-align:center;">' . $real_width . 'px by ' . $real_height . 'px</p>
													</div>';
										}
									}
									?>
									<th class="check-column" scope="row">
										<label for="cb-select-<?php the_ID(); ?>" class="screen-reader-text"></label>
										<input type="checkbox" data-identifier="<?php the_ID(); ?>" value="<?php the_ID(); ?>" name="post[]" id="cb-select-<?php the_ID(); ?>">
										</th>

										<td class="post-title page-title column-title">
									<?php
									echo '<a href="' . esc_url( admin_url( '/post.php?post=' . get_the_ID() . '&action=edit' ) ) . '" target="_blank">';

Are you sure get_the_ID() of type false|integer can be used in concatenation?

									the_title();
									echo '</a>';
									?>
										</td>

										<td colspan="2" class="thumbnails column-thumbnails">
									<?php
									if ( false !== $thumbnails_html ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

										echo wp_kses_post( implode( '', $thumbnails_html ) );
									} else {
										echo '<p>There was an error retrieving your images.</p>';
									}
									?>
										</td>
									</tr>
								<?php
							}
						}
						?>
					</tbody>

					<tfoot>
						<tr>
							<th style="" class="manage-column column-cb check-column" id="cb" scope="col">
								<label for="cb-select-all-1" class="screen-reader-text">Select All</label>
								<input type="checkbox" id="cb-select-all-1">
							</th>
							<th style="width:15%;" class="manage-column column-title " id="title" scope="col">Title</th>
							<th style="" class="manage-column column-date" id="date" scope="col">Images</th>
						</tr>
					</tfoot>

				</table>

				<p><input class="button button-primary download" type="button" value="<?php esc_html_e( 'Download new Banners', 'lsx-wetu-importer' ); ?>" />
				</p>
			</form>
		</div>
		<?php
	}

Expected 1 blank line before closing function brace; 0 found

Expected 2 blank lines after function; 1 found

	/**
	 * Creates the main gallery data
	 */
	public function sync_new_banner() {
		check_ajax_referer( 'lsx_wetu_ajax_action', 'security' );
		if ( isset( $_POST['action'] ) && 'lsx_import_sync_banners' === $_POST['action'] && isset( $_POST['post_id'] ) ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

Blank line found at start of control structure

			$post_id       = sanitize_text_field( $_POST['post_id'] );

$_POST data not unslashed before sanitization. Use wp_unslash() or similar

			$banners       = get_post_meta( $post_id, 'image_group', true );
			$this->wetu_id = get_post_meta( $post_id, 'lsx_wetu_id', true );

			$new_banner_array = false;
			$array_index      = 0;

			foreach ( $banners['banner_image'] as $banner_image ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

				$image_id = $this->attach_external_image2( $this->format_wetu_url( $banner_image ), array(), $post_id );
				if ( null !== $image_id && '' !== $image_id ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

					$new_banner_array['banner_image'][ 'cmb-field-' . $array_index ] = $image_id;
					$array_index++;
				}
			}

			if ( false !== $new_banner_array ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

				delete_post_meta( $post_id, 'image_group' );
				add_post_meta( $post_id, 'image_group', $new_banner_array, true );
				echo true;
			} else {
				echo false;
			}
		} else {
			echo false;
		}

		die();

Using exit here is not recommended.

	}

Expected 1 blank line before closing function brace; 0 found

Expected 2 blank lines after function; 1 found

	/**

Doc comment for parameter "$post_id" missing

	 * formats the url

Doc comment short description must start with a capital letter

	 */
	public function format_wetu_url( $post_id ) {
		return 'https://wetu.com/ImageHandler/c1920x800/' . $this->wetu_id . '/' . $this->format_filename( $post_id );

Are you sure $this->format_filename($post_id) of type false|string can be used in concatenation?

	}

Expected 1 blank line before closing function brace; 0 found

Expected 2 blank lines after function; 1 found

	/**

Doc comment for parameter "$post_id" missing

	 * formats the filename

Doc comment short description must start with a capital letter

	 */
	public function format_filename( $post_id ) {
		$base = str_replace( '_', ' ', get_the_title( $post_id ) );
		$base = rawurlencode( $base );
		$type = get_post_mime_type( $post_id );

		switch ( $type ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

			case 'image/jpeg':
				return $base . '.jpg';
			break;
			case 'image/png':
				return $base . '.png';
			break;
			case 'image/gif':
				return $base . '.gif';
			break;
			default:
				return false;
		}
	}

Expected 1 blank line before closing function brace; 0 found

Expected 2 blank lines after function; 1 found

	public function attach_external_image2( $url = null, $post_data = array(), $post_id = '' ) {

Missing doc comment for function attach_external_image2()

		if ( ! $url ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

			return new WP_Error( 'missing', 'Need a valid URL' ); }

No blank line found after control structure

		$att_id = false;

		require_once ABSPATH . 'wp-admin/includes/file.php';
		require_once ABSPATH . 'wp-admin/includes/media.php';
		require_once ABSPATH . 'wp-admin/includes/image.php';

		$tmp   = tempnam( '/tmp', 'FOO' );
		$image = wp_remote_get( $url );

		if ( ! empty( $image ) && isset( $image['response'] ) && isset( $image['response']['code'] ) && 200 === $image['response']['code'] ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

			file_put_contents( $tmp, $image['body'] );

File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: file_put_contents()

			chmod( $tmp, '777' );

			preg_match( '/[^\?]+\.(tif|TIFF|jpg|JPG|jpe|JPE|jpeg|JPEG|gif|GIF|png|PNG|pdf|PDF|bmp|BMP)/', $url, $matches );
			$url_filename = basename( $matches[0] );
			$url_filename = str_replace( '%20', '_', $url_filename );
			// extract filename from url for title.
			$url_type = wp_check_filetype( $url_filename );

			// assemble file data (should be built like $_FILES since wp_handle_sideload() will be using).
			$file_array['tmp_name'] = $tmp;

			if ( ! empty( $filename ) && ' ' != $filename ) {

Expected 0 spaces after opening bracket; 1 found

Found: !=. Use strict comparisons (=== or !==).

Expected 0 spaces before closing bracket; 1 found

				$file_array['name'] = $filename . '.' . $url_type['ext'];
			} else {
				$file_array['name'] = $url_filename;
			}

			// set additional wp_posts columns.
			if ( empty( $post_data['post_title'] ) ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

				$url_filename            = str_replace( '%20', ' ', $url_filename );
				$post_data['post_title'] = basename( $url_filename, '.' . $url_type['ext'] );
			}

			// make sure gets tied to parent.
			if ( empty( $post_data['post_parent'] ) ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

				$post_data['post_parent'] = $post_id;
			}

			// do the validation and storage stuff.
			$att_id = media_handle_sideload( $file_array, $post_id, null, $post_data );

			// If error storing permanently, unlink.
			if ( is_wp_error( $att_id ) ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

				unlink( $file_array['tmp_name'] );
				return false;
			}
		}

No blank line found after control structure

		return $att_id;
	}

Expected 1 blank line before closing function brace; 0 found

Expected 2 blank lines after function; 0 found

}