LSX_TO_Vehicles_Frontend

Complexity

Total Complexity

25

Size/Duplication

Total Lines	129
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	single_content_bottom()	0	14	4
A	get_videos_link()	0	13	5
B	get_gallery_link()	0	18	10
A	wp_head()	0	3	2
A	page_links()	0	10	2
A	__construct()	0	21	2

<?php
/**
 * LSX_TO_Vehicles_Frontend
 *
 * @package   LSX_TO_Vehicles_Frontend
 * @author    LightSpeed
 * @license   GPL-3.0+
 * @link
 * @copyright 2016 LightSpeedDevelopment
 */

/**
 * Main plugin class.
 *
 * @package LSX_TO_Vehicles_Frontend
 * @author  LightSpeed
 */

There must be no blank lines after the class comment

class LSX_TO_Vehicles_Frontend extends LSX_TO_Vehicles {

	/**
	 * Holds the $page_links array while its being built on the single team page.
	 *
	 * @var array
	 */
	public $page_links = false;

	/**
	 * Holds the array of options.
	 *
	 * @var array
	 */
	public $options = false;

	/**
	 * Constructor
	 */
	public function __construct() {

Expected 2 blank lines before function; 1 found

		$this->set_vars();

		add_action( 'wp_head', array( $this, 'wp_head' ), 20, 1 );

		//add_filter( 'lsx_to_entry_class', array( $this, 'entry_class' ) );

60% of this comment could be valid code. Did you maybe forget this after debugging?

No space found before comment text; expected "// add_filter( 'lsx_to_entry_class', array( $this, 'entry_class' ) );" but found "//add_filter( 'lsx_to_entry_class', array( $this, 'entry_class' ) );"

		//add_action( 'init', array( $this, 'init' ) );

No space found before comment text; expected "// add_action( 'init', array( $this, 'init' ) );" but found "//add_action( 'init', array( $this, 'init' ) );"

Inline comments must end in full-stops, exclamation marks, or question marks

		if ( ! class_exists( 'LSX_TO_Template_Redirects' ) ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

			require_once( LSX_TO_VEHICLES_PATH . 'classes/class-lsx-to-template-redirects.php' );

"require_once" is a statement not a function; no parentheses are required

		}

No blank line found after control structure

		$this->redirects = new LSX_TO_Template_Redirects( LSX_TO_VEHICLES_PATH, array_keys( $this->post_types ) );

The property redirects does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		add_action( 'lsx_vehicle_content', array( $this->redirects, 'content_part' ), 10, 2 );

		add_filter( 'lsx_to_page_navigation', array( $this, 'page_links' ) );

		//add_action( 'lsx_entry_top', array( $this, 'archive_entry_top' ), 15 );

61% of this comment could be valid code. Did you maybe forget this after debugging?

No space found before comment text; expected "// add_action( 'lsx_entry_top', array( $this, 'archive_entry_top' ), 15 );" but found "//add_action( 'lsx_entry_top', array( $this, 'archive_entry_top' ), 15 );"

		//add_action( 'lsx_entry_bottom', array( $this, 'archive_entry_bottom' ) );

No space found before comment text; expected "// add_action( 'lsx_entry_bottom', array( $this, 'archive_entry_bottom' ) );" but found "//add_action( 'lsx_entry_bottom', array( $this, 'archive_entry_bottom' ) );"

Inline comments must end in full-stops, exclamation marks, or question marks

		add_action( 'lsx_content_bottom', array( $this, 'single_content_bottom' ) );

		add_action( 'lsx_banner_allowed_post_types', array( $this, 'theme_allowed_post_type_banners' ) );
	}

Expected 1 blank line before closing function brace; 0 found

Expected 2 blank lines after function; 1 found

	function wp_head() {

It is generally recommended to explicitly declare the visibility for methods.

Missing doc comment for function wp_head()

It is recommend to declare an explicit visibility for wp_head.

		if ( is_singular( 'vehicle' ) ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

			remove_action( 'lsx_entry_bottom', 'lsx_to_single_entry_bottom' );
		}
	}

Expected 1 blank line before closing function brace; 0 found

Expected 2 blank lines after function; 1 found

	/**
	 * Adds the template tags to the bottom of the single review
	 */
	public function single_content_bottom() {
		if ( is_singular( 'vehicle' ) ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

			// lsx_to_review_accommodation();

75% of this comment could be valid code. Did you maybe forget this after debugging?

Inline comments must end in full-stops, exclamation marks, or question marks

			// lsx_to_review_tour();

75% of this comment could be valid code. Did you maybe forget this after debugging?

Inline comments must end in full-stops, exclamation marks, or question marks

			// lsx_to_review_destination();

75% of this comment could be valid code. Did you maybe forget this after debugging?

Inline comments must end in full-stops, exclamation marks, or question marks

			lsx_to_gallery( '<section id="gallery" class="lsx-to-section lsx-to-collapse-section"><h2 class="lsx-to-section-title lsx-to-collapse-title lsx-title" data-toggle="collapse" data-target="#collapse-gallery">' . esc_html__( 'Gallery', 'to-reviews' ) . '</h2><div id="collapse-gallery" class="collapse in"><div class="collapse-inner">', '</div></div></section>' );

			if ( function_exists( 'lsx_to_videos' ) ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

				lsx_to_videos( '<section id="videos" class="lsx-to-section lsx-to-collapse-section"><h2 class="lsx-to-section-title lsx-to-collapse-title lsx-title" data-toggle="collapse" data-target="#collapse-videos">' . esc_html__( 'Videos', 'to-reviews' ) . '</h2><div id="collapse-videos" class="collapse in"><div class="collapse-inner">', '</div></div></section>' );
			} elseif ( class_exists( 'Envira_Videos' ) ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

				lsx_to_envira_videos( '<section id="videos" class="lsx-to-section lsx-to-collapse-section"><h2 class="lsx-to-section-title lsx-to-collapse-title lsx-title" data-toggle="collapse" data-target="#collapse-videos">' . esc_html__( 'Videos', 'to-reviews' ) . '</h2><div id="collapse-videos" class="collapse in"><div class="collapse-inner">', '</div></div></section>' );
			} //lsx_to_review_posts();

75% of this comment could be valid code. Did you maybe forget this after debugging?

		}
	}

Expected 1 blank line before closing function brace; 0 found

Expected 2 blank lines after function; 1 found

	/**

Doc comment for parameter "$page_links" missing

	 * Adds our navigation links to the team single post
	 *
	 * @param $page_links array

Missing parameter name

	 * @return $page_links array

The doc comment $page_links at position 0 could not be parsed: Unknown type name '$page_links' at position 0 in $page_links.

	 */
	public function page_links( $page_links ) {
		if ( is_singular( 'vehicle' ) ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

			$this->page_links = $page_links;
			$this->get_gallery_link();
			$this->get_videos_link();

			$page_links = $this->page_links;
		}

		return $page_links;
	}

Expected 1 blank line before closing function brace; 0 found

Expected 2 blank lines after function; 1 found

	/**
	 * Tests for the Gallery and returns a link for the section
	 */
	public function get_gallery_link() {
		$gallery_ids = get_post_meta( get_the_ID(), 'gallery', false );

It seems like get_the_ID() can also be of type false; however, parameter $post_id of get_post_meta() does only seem to accept integer, maybe add an additional type check?

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

		$envira_gallery = get_post_meta( get_the_ID(), 'envira_gallery', true );

		if ( ( ! empty( $gallery_ids ) && is_array( $gallery_ids ) ) || ( function_exists( 'envira_gallery' ) && ! empty( $envira_gallery ) && false === lsx_to_enable_envira_banner() ) ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

			if ( function_exists( 'envira_gallery' ) && ! empty( $envira_gallery ) && false === lsx_to_enable_envira_banner() ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

				// Envira Gallery.
				$this->page_links['gallery'] = esc_html__( 'Gallery', 'to-vehicles' );
				return;
			} else {
				if ( function_exists( 'envira_dynamic' ) ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

					// Envira Gallery - Dynamic.
					$this->page_links['gallery'] = esc_html__( 'Gallery', 'to-vehicles' );
					return;
				} else {
					// WordPress Gallery.
					$this->page_links['gallery'] = esc_html__( 'Gallery', 'to-vehicles' );
					return;
				}
			}
		}
	}

Expected 1 blank line before closing function brace; 0 found

Expected 2 blank lines after function; 1 found

	/**
	 * Tests for the Videos and returns a link for the section
	 */
	public function get_videos_link() {
		$videos_id = false;

		if ( class_exists( 'Envira_Videos' ) ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

			$videos_id = get_post_meta( get_the_ID(), 'envira_video', true );

It seems like get_the_ID() can also be of type false; however, parameter $post_id of get_post_meta() does only seem to accept integer, maybe add an additional type check?

		}

		if ( empty( $videos_id ) && function_exists( 'lsx_to_videos' ) ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

			$videos_id = get_post_meta( get_the_ID(), 'videos', true );
		}

		if ( ! empty( $videos_id ) ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

			$this->page_links['videos'] = esc_html__( 'Videos', 'to-vehicles' );
		}
	}

Expected 1 blank line before closing function brace; 0 found

Expected 2 blank lines after function; 1 found

}
new LSX_TO_Vehicles_Frontend();