Issues in class-lsx-walker-comment.php (master) - Issues in master - lightspeeddevelopment/lsx - Measure and Improve Code Quality continuously with Scrutinizer

Issues (461)

Security Analysis not enabled

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/classes/class-lsx-walker-comment.php (16 issues)

Labels

Severity

<?php
/**
 * LSX functions and definitions - Comment Walker.
 *
 * @package    lsx
 * @subpackage comment
 */

if ( ! defined( 'ABSPATH' ) ) {
	exit;
}

if ( ! class_exists( 'Walker_Comment' ) ) {
	return;
}

if ( ! class_exists( 'LSX_Walker_Comment' ) ) :

	/**
	 * Use Bootstrap's media object for listing comments.
	 *
	 * @link http://getbootstrap.com/components/#media
	 *
	 * @package    lsx
	 * @subpackage comment
	 */
	class LSX_Walker_Comment extends Walker_Comment {

		function start_lvl( &$output, $depth = 0, $args = array() ) {

			$GLOBALS['comment_depth'] = $depth + 1; ?>

			<ul <?php comment_class( 'media media-reply unstyled list-unstyled comment-' . get_comment_ID() ); ?>>
			<?php
		}

		function end_lvl( &$output, $depth = 0, $args = array() ) {

			$GLOBALS['comment_depth'] = $depth + 1;

			echo '</ul>';
		}

		function start_el( &$output, $comment, $depth = 0, $args = array(), $id = 0 ) {

			++$depth;
			$GLOBALS['comment_depth'] = $depth;

			$GLOBALS['comment']       = $comment;


			if ( ! empty( $args['callback'] ) ) {
				call_user_func( $args['callback'], $comment, $args, $depth );
				return;
			}
			?>

			<li id="comment-<?php comment_ID(); ?>" <?php comment_class( 'media comment-' . get_comment_ID() ); ?>>
			<?php get_template_part( 'comment' ); ?>
			<?php
		}

		function end_el( &$output, $comment, $depth = 0, $args = array() ) {

			if ( ! empty( $args['end-callback'] ) ) {
				call_user_func( $args['end-callback'], $comment, $args, $depth );
				return;
			}

			echo "</div></li>\n";
		}

	}

endif;


1			<?php
2			/**
3			* LSX functions and definitions - Comment Walker.
4			*
5			* @package lsx
6			* @subpackage comment
7			*/
8
9			if ( ! defined( 'ABSPATH' ) ) {
10			exit;
11			}
12
13			if ( ! class_exists( 'Walker_Comment' ) ) {
14			return;
15			}
16
17			if ( ! class_exists( 'LSX_Walker_Comment' ) ) :
18
19			/**
20			* Use Bootstrap's media object for listing comments.
21			*
22			* @link http://getbootstrap.com/components/#media
23			*
24			* @package lsx
25			* @subpackage comment
26			*/
27			class LSX_Walker_Comment extends Walker_Comment {
28
29			function start_lvl( &$output, $depth = 0, $args = array() ) {
			0 ignored issues – show Best Practice introduced 2020-08-14 10:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Coding Style Documentation introduced 2020-08-20 08:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Missing doc comment for function start_lvl() Loading history... Comprehensibility Best Practice introduced 2020-08-20 08:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is recommend to declare an explicit visibility for `start_lvl`. Generally, we recommend to declare visibility for all methods in your source code. This has the advantage of clearly communication to other developers, and also yourself, how this method should be consumed. If you are not sure which visibility to choose, it is a good idea to start with the most restrictive visibility, and then raise visibility as needed, i.e. start with `private`, and only raise it to `protected` if a sub-class needs to have access, or `public` if an external class needs access. Loading history...
30			$GLOBALS['comment_depth'] = $depth + 1; ?>
			0 ignored issues – show introduced 2020-08-20 08:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Overriding WordPress globals is prohibited. Found assignment to $GLOBALS['comment_depth'] Loading history...
31			<ul <?php comment_class( 'media media-reply unstyled list-unstyled comment-' . get_comment_ID() ); ?>>
32			<?php
33			}
34
35			function end_lvl( &$output, $depth = 0, $args = array() ) {
			0 ignored issues – show Best Practice introduced 2020-08-14 10:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Coding Style Documentation introduced 2020-08-20 08:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Missing doc comment for function end_lvl() Loading history... Comprehensibility Best Practice introduced 2020-08-20 08:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is recommend to declare an explicit visibility for `end_lvl`. Generally, we recommend to declare visibility for all methods in your source code. This has the advantage of clearly communication to other developers, and also yourself, how this method should be consumed. If you are not sure which visibility to choose, it is a good idea to start with the most restrictive visibility, and then raise visibility as needed, i.e. start with `private`, and only raise it to `protected` if a sub-class needs to have access, or `public` if an external class needs access. Loading history...
36			$GLOBALS['comment_depth'] = $depth + 1;
			0 ignored issues – show introduced 2020-08-20 08:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Overriding WordPress globals is prohibited. Found assignment to $GLOBALS['comment_depth'] Loading history...
37			echo '</ul>';
38			}
39
40			function start_el( &$output, $comment, $depth = 0, $args = array(), $id = 0 ) {
			0 ignored issues – show Best Practice introduced 2020-08-14 10:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Coding Style Documentation introduced 2020-08-20 08:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Missing doc comment for function start_el() Loading history... Comprehensibility Best Practice introduced 2020-08-20 08:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is recommend to declare an explicit visibility for `start_el`. Generally, we recommend to declare visibility for all methods in your source code. This has the advantage of clearly communication to other developers, and also yourself, how this method should be consumed. If you are not sure which visibility to choose, it is a good idea to start with the most restrictive visibility, and then raise visibility as needed, i.e. start with `private`, and only raise it to `protected` if a sub-class needs to have access, or `public` if an external class needs access. Loading history...
41			++$depth;
42			$GLOBALS['comment_depth'] = $depth;
			0 ignored issues – show introduced 2020-08-20 08:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Overriding WordPress globals is prohibited. Found assignment to $GLOBALS['comment_depth'] Loading history...
43			$GLOBALS['comment'] = $comment;
			0 ignored issues – show introduced 2020-08-20 08:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Overriding WordPress globals is prohibited. Found assignment to $GLOBALS['comment'] Loading history...
44
45			if ( ! empty( $args['callback'] ) ) {
46			call_user_func( $args['callback'], $comment, $args, $depth );
47			return;
48			}
49			?>
50
51			<li id="comment-<?php comment_ID(); ?>" <?php comment_class( 'media comment-' . get_comment_ID() ); ?>>
52			<?php get_template_part( 'comment' ); ?>
53			<?php
54			}
55
56			function end_el( &$output, $comment, $depth = 0, $args = array() ) {
			0 ignored issues – show Best Practice introduced 2020-08-14 10:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Coding Style Documentation introduced 2020-08-20 08:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Missing doc comment for function end_el() Loading history... Comprehensibility Best Practice introduced 2020-08-20 08:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is recommend to declare an explicit visibility for `end_el`. Generally, we recommend to declare visibility for all methods in your source code. This has the advantage of clearly communication to other developers, and also yourself, how this method should be consumed. If you are not sure which visibility to choose, it is a good idea to start with the most restrictive visibility, and then raise visibility as needed, i.e. start with `private`, and only raise it to `protected` if a sub-class needs to have access, or `public` if an external class needs access. Loading history...
57			if ( ! empty( $args['end-callback'] ) ) {
58			call_user_func( $args['end-callback'], $comment, $args, $depth );
59			return;
60			}
61
62			echo "</div></li>\n";
63			}
64
65			}
66
67			endif;
68

lightspeeddevelopment / lsx

Issues (461)

Security Analysis not enabled

includes/classes/class-lsx-walker-comment.php (16 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like