lightspeeddevelopment / lsx-sharing

classes/class-sharing.php

<?php
/**
 * LSX_Sharing
 *
 * @package lsx-sharing
 */

There must be exactly one blank line after the file comment

namespace lsx\sharing;

/**
 * LSX Sharing class.
 *
 * @package lsx-sharing
 */
class Sharing {


    /**
     * Holds class instance
     *
     * @since 1.0.0
     *
     * @var object \lsx\search\Sharing()
     */
    protected static $instance = null;

Expected 1 blank line(s) before first member var; 2 found

    /**
     * Holds class instance
     *
     * @since 1.0.0
     *
     * @var object \lsx\search\classes\Admin()
     */
    public $admin = false;

    /**
     * If we are using the new options or not.
     *
     * @var boolean
     */
    public $is_new_options = false;

    /**
     * The options for the plugin.
     *
     * @var array
     */
    public $options = array();

    /**
     * Constructor.
     */
    public function __construct() {

Expected 2 blank lines before function; 1 found

         add_action('init', array( $this, 'set_options' ), 50);

Found precision alignment of 1 spaces.

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

        $this->load_vendors();
        $this->load_includes();
        $this->load_classes();
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

    /**
     * Return an instance of this class.
     *
     * @since 1.0.0
     *
     * @return object \lsx\member_directory\search\Admin()    A single instance of this class.
     */
    public static function get_instance() {
         // If the single instance hasn't been set, set it now.

Found precision alignment of 1 spaces.

        if ( null === self::$instance ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

            self::$instance = new self();
        }

No blank line found after control structure

        return self::$instance;
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

    /**
     * Loads the plugin functions.
     */
    private function load_vendors() {
         // Configure custom fields.

Found precision alignment of 1 spaces.

        if ( ! class_exists('CMB2') ) {

Expected 0 spaces after opening bracket; 1 found

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

Expected 0 spaces before closing bracket; 1 found

            include_once LSX_SHARING_PATH . 'vendor/CMB2/init.php';
        }
    }

Expected 2 blank lines after function; 0 found

Expected 1 blank line before closing function brace; 0 found

    /**
     * Loads the plugin functions.
     */
    private function load_includes() {
         include_once LSX_SHARING_PATH . '/includes/functions.php';

Found precision alignment of 1 spaces.

    }

Expected 2 blank lines after function; 0 found

Expected 1 blank line before closing function brace; 0 found

    /**
     * Loads the plugin functions.
     */
    private function load_classes() {
         include_once LSX_SHARING_PATH . '/classes/class-admin.php';

Found precision alignment of 1 spaces.

        global $lsx_sharing_admin;
        $this->admin = \lsx\sharing\classes\Admin::get_instance();
        $lsx_sharing_admin;

        include_once LSX_SHARING_PATH . '/classes/class-frontend.php';
        $this->frontend = \lsx\sharing\classes\Frontend::get_instance();

The property frontend does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        global $lsx_sharing;
        $lsx_sharing = $this->frontend->output;

        include_once LSX_SHARING_PATH . '/classes/deprecated/class-lsx-sharing.php';
    }

Expected 2 blank lines after function; 0 found

Expected 1 blank line before closing function brace; 0 found

    /**
     * Set options.
     */
    public function set_options() {
         if ( function_exists('tour_operator') ) {

Found precision alignment of 1 spaces.

Expected 0 spaces after opening bracket; 1 found

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

Expected 0 spaces before closing bracket; 1 found

            $this->options = get_option('_lsx-to_settings', false);

It seems like get_option('_lsx-to_settings', false) can also be of type false. However, the property $options is declared as type array. Maybe add an additional type check?

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

        } else {

Closing brace indented incorrectly; expected 9 spaces, found 8

            $this->options = get_option('_lsx_settings', false);

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

            if ( false === $this->options ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

                $this->options = get_option('_lsx_lsx-settings', false);

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

            }
        }

        $new_options = get_option('lsx-sharing-settings');

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

        if ( ! empty($new_options) ) {

Expected 0 spaces after opening bracket; 1 found

Expected 1 spaces after opening parenthesis; 0 found

Expected 1 spaces before closing parenthesis; 0 found

Expected 0 spaces before closing bracket; 1 found

            if ( '' !== $new_options && false !== $new_options ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

                $this->is_new_options = true;
                $this->options        = $new_options;
            }
        }
    }

Expected 2 blank lines after function; 0 found

Expected 1 blank line before closing function brace; 0 found

}