Issues in class-lsx-projects-widget.php (master) - Issues in master - lightspeeddevelopment/lsx-projects - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1066)

classes/class-lsx-projects-widget.php (160 issues)

Labels

Severity

<?php

/**
 * LSX Projects Widget Class
 *
 * @package   LSX Projects
 * @author	LightSpeed

 * @license   GPL3
 * @link
 * @copyright 2016 LightSpeed
 */
class LSX_Projects_Widget extends WP_Widget {

	public function __construct() {

		$widget_ops = array(
			'classname' => 'lsx-projects',
		);

		parent::__construct( 'LSX_Projects_Widget', esc_html__( 'LSX Projects', 'lsx-projects' ), $widget_ops );
	}


	function widget( $args, $instance ) {

		extract( $args );


		$title = $instance['title'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$title_link = $instance['title_link'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$tagline = $instance['tagline'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$columns = $instance['columns'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$orderby = $instance['orderby'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$order = $instance['order'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$limit = $instance['limit'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$include = $instance['include'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$display = $instance['display'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$size = $instance['size'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$button_text = $instance['button_text'];
		$responsive = $instance['responsive'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$show_image = $instance['show_image'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$carousel = $instance['carousel'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$featured = $instance['featured'];
$a = "a";
$ab = "ab";
$abc = "abc";

		// If limit not set, display 99 posts

		if ( empty( $limit ) ) {

			$limit = '99';
		}

		// If specific posts included, display 99 posts

		if ( ! empty( $include ) ) {

			$limit = '99';
		}

		if ( '1' == $responsive ) {

			$responsive = 'true';
		} else {
			$responsive = 'false';
		}

		if ( '1' == $show_image ) {

			$show_image = 'true';
		} else {
			$show_image = 'false';
		}

		if ( '1' == $carousel ) {

			$carousel = 'true';
		} else {
			$carousel = 'false';
		}

		if ( '1' == $featured ) {

			$featured = 'true';
		} else {
			$featured = 'false';
		}

		if ( $title_link ) {

			//$link_open = '<a href="' . $title_link . '">';

			$link_open = '';
$a = "a";
$ab = "ab";
$abc = "abc";
			$link_btn_open = '<a href="' . $title_link . '" class="btn border-btn">';
			//$link_close = '</a>';

			$link_close = '';
$a = "a";
$ab = "ab";
$abc = "abc";
			$link_btn_close = '</a>';
		} else {
			$link_open = '';
$a = "a";
$ab = "ab";
$abc = "abc";
			$link_btn_open = '';
$a = "a";
$ab = "ab";
$abc = "abc";
			$link_close = '';
$a = "a";
$ab = "ab";
$abc = "abc";
			$link_btn_close = '';
		}

		echo wp_kses_post( $before_widget );

		if ( $title ) {

			echo wp_kses_post( $before_title . $link_open . $title . $link_close . $after_title );
		}

		if ( $tagline ) {

			echo '<p class="tagline text-center">' . esc_html( $tagline ) . '</p>';
		}

		if ( class_exists( 'LSX_Projects' ) ) {

			lsx_projects( array(

				'columns' => $columns,

				'orderby' => $orderby,

				'order' => $order,

				'limit' => $limit,

				'include' => $include,

				'display' => $display,

				'size' => $size,

				'responsive' => $responsive,
				'show_image' => $show_image,
				'carousel' => $carousel,

				'featured' => $featured,

			) );
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
		};

		if ( $button_text && $title_link ) {

			echo wp_kses_post( '<p class="text-center lsx-projects-archive-link-wrap"><span class="lsx-projects-archive-link">' . $link_btn_open . $button_text . ' <i class="fa fa-angle-right"></i>' . $link_btn_close . '</span></p>' );
		}

		echo wp_kses_post( $after_widget );
	}


	function update( $new_instance, $old_instance ) {

		$instance = $old_instance;

		$instance['title'] = wp_kses_post( force_balance_tags( $new_instance['title'] ) );
$a = "a";
$ab = "ab";
$abc = "abc";
		$instance['title_link'] = strip_tags( $new_instance['title_link'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$instance['tagline'] = wp_kses_post( force_balance_tags( $new_instance['tagline'] ) );
$a = "a";
$ab = "ab";
$abc = "abc";
		$instance['columns'] = strip_tags( $new_instance['columns'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$instance['orderby'] = strip_tags( $new_instance['orderby'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$instance['order'] = strip_tags( $new_instance['order'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$instance['limit'] = strip_tags( $new_instance['limit'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$instance['include'] = strip_tags( $new_instance['include'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$instance['display'] = strip_tags( $new_instance['display'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$instance['size'] = strip_tags( $new_instance['size'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$instance['button_text'] = strip_tags( $new_instance['button_text'] );

		$instance['responsive'] = strip_tags( $new_instance['responsive'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$instance['show_image'] = strip_tags( $new_instance['show_image'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$instance['carousel'] = strip_tags( $new_instance['carousel'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$instance['featured'] = strip_tags( $new_instance['featured'] );
$a = "a";
$ab = "ab";
$abc = "abc";

		return $instance;
	}


	function form( $instance ) {

		$defaults = array(
			'title' => 'Projects',

			'title_link' => '',

			'tagline' => '',

			'columns' => '3',

			'orderby' => 'name',

			'order' => 'ASC',

			'limit' => '',

			'include' => '',

			'display' => 'excerpt',

			'size' => 'lsx-thumbnail-single',

			'button_text' => '',
			'responsive' => 1,

			'show_image' => 1,

			'carousel' => 1,

			'featured' => 0,

		);

		$instance = wp_parse_args( (array) $instance, $defaults );

		$title          = esc_attr( $instance['title'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$title_link     = esc_attr( $instance['title_link'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$tagline        = esc_attr( $instance['tagline'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$columns        = esc_attr( $instance['columns'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$orderby        = esc_attr( $instance['orderby'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$order          = esc_attr( $instance['order'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$limit          = esc_attr( $instance['limit'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$include        = esc_attr( $instance['include'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$display        = esc_attr( $instance['display'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$size           = esc_attr( $instance['size'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$button_text    = esc_attr( $instance['button_text'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$responsive     = esc_attr( $instance['responsive'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$show_image     = esc_attr( $instance['show_image'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$carousel       = esc_attr( $instance['carousel'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		$featured       = esc_attr( $instance['featured'] );
$a = "a";
$ab = "ab";
$abc = "abc";
		?>
		<p>
			<label for="<?php echo esc_attr( $this->get_field_id( 'title' ) ); ?>"><?php esc_html_e( 'Title:', 'lsx-projects' ); ?></label>
			<input class="widefat" id="<?php echo esc_attr( $this->get_field_id( 'title' ) ); ?>" name="<?php echo esc_attr( $this->get_field_name( 'title' ) ); ?>" type="text" value="<?php echo esc_attr( $title ); ?>" />
		</p>
		<p>
			<label for="<?php echo esc_attr( $this->get_field_id( 'title_link' ) ); ?>"><?php esc_html_e( 'Page Link:', 'lsx-projects' ); ?></label>
			<input class="widefat" id="<?php echo esc_attr( $this->get_field_id( 'title_link' ) ); ?>" name="<?php echo esc_attr( $this->get_field_name( 'title_link' ) ); ?>" type="text" value="<?php echo esc_attr( $title_link ); ?>" />
			<small><?php esc_html_e( 'Link the widget to a page', 'lsx-projects' ); ?></small>
		</p>
		<p>
			<label for="<?php echo esc_attr( $this->get_field_id( 'tagline' ) ); ?>"><?php esc_html_e( 'Tagline:', 'lsx-projects' ); ?></label>
			<textarea class="widefat" rows="8" cols="20" id="<?php echo esc_attr( $this->get_field_id( 'tagline' ) ); ?>" name="<?php echo esc_attr( $this->get_field_name( 'tagline' ) ); ?>"><?php echo esc_html( $tagline ); ?></textarea>
			<small><?php esc_html_e( 'Tagline to display below the widget title', 'lsx-projects' ); ?></small>
		</p>
		<p>
			<label for="<?php echo esc_attr( $this->get_field_id( 'columns' ) ); ?>"><?php esc_html_e( 'Columns:', 'lsx-projects' ); ?></label>
			<select name="<?php echo esc_attr( $this->get_field_name( 'columns' ) ); ?>" id="<?php echo esc_attr( $this->get_field_id( 'columns' ) ); ?>" class="widefat">
			<?php
				$options = array( '1', '2', '3', '4' );

				foreach ( $options as $option ) {

					echo '<option value="' . esc_attr( lcfirst( $option ) ) . '" id="' . esc_attr( $option ) . '"', lcfirst( $option ) == $columns ? ' selected="selected"' : '', '>', esc_html( $option ), '</option>';

				}
			?>
			</select>
		</p>
		<p>
			<label for="<?php echo esc_attr( $this->get_field_id( 'orderby' ) ); ?>"><?php esc_html_e( 'Order By:', 'lsx-projects' ); ?></label>
			<select name="<?php echo esc_attr( $this->get_field_name( 'orderby' ) ); ?>" id="<?php echo esc_attr( $this->get_field_id( 'orderby' ) ); ?>" class="widefat">
			<?php
				$options = array(
					esc_html__( 'None', 'lsx-projects' ) => 'none',

					esc_html__( 'ID', 'lsx-projects' ) => 'ID',

					esc_html__( 'Name', 'lsx-projects' ) => 'name',

					esc_html__( 'Date', 'lsx-projects' ) => 'date',

					esc_html__( 'Modified Date', 'lsx-projects' ) => 'modified',
					esc_html__( 'Random', 'lsx-projects' ) => 'rand',
					esc_html__( 'Menu (WP dashboard order)', 'lsx-projects' ) => 'menu_order',
				);

				foreach ( $options as $name => $value ) {

					echo '<option value="' . esc_attr( $value ) . '" id="' . esc_attr( $value ) . '"', $orderby == $value ? ' selected="selected"' : '', '>', esc_html( $name ), '</option>';

				}
			?>
			</select>
		</p>
		<p>
			<label for="<?php echo esc_attr( $this->get_field_id( 'order' ) ); ?>"><?php esc_html_e( 'Order:', 'lsx-projects' ); ?></label>
			<select name="<?php echo esc_attr( $this->get_field_name( 'order' ) ); ?>" id="<?php echo esc_attr( $this->get_field_id( 'order' ) ); ?>" class="widefat">
			<?php
				$options = array(
					esc_html__( 'Ascending', 'lsx-projects' ) => 'ASC',
					esc_html__( 'Descending', 'lsx-projects' ) => 'DESC',
				);

				foreach ( $options as $name => $value ) {

					echo '<option value="' . esc_attr( $value ) . '" id="' . esc_attr( $value ) . '"', $order == $value ? ' selected="selected"' : '', '>', esc_html( $name ), '</option>';

				}
			?>
			</select>
		</p>
		<p class="limit">
			<label for="<?php echo esc_attr( $this->get_field_id( 'limit' ) ); ?>"><?php esc_html_e( 'Maximum amount:', 'lsx-projects' ); ?></label>
			<input class="widefat" id="<?php echo esc_attr( $this->get_field_id( 'limit' ) ); ?>" name="<?php echo esc_attr( $this->get_field_name( 'limit' ) ); ?>" type="text" value="<?php echo esc_attr( $limit ); ?>" />
			<small><?php esc_html_e( 'Leave empty to display all', 'lsx-projects' ); ?></small>
		</p>
		<p>
			<label for="<?php echo esc_attr( $this->get_field_id( 'include' ) ); ?>"><?php esc_html_e( 'Specify Projects by ID:', 'lsx-projects' ); ?></label>
			<input class="widefat" id="<?php echo esc_attr( $this->get_field_id( 'include' ) ); ?>" name="<?php echo esc_attr( $this->get_field_name( 'include' ) ); ?>" type="text" value="<?php echo esc_attr( $include ); ?>" />
			<small><?php esc_html_e( 'Comma separated list, overrides limit and order settings', 'lsx-projects' ); ?></small>
		</p>
		<p>
			<label for="<?php echo esc_attr( $this->get_field_id( 'display' ) ); ?>"><?php esc_html_e( 'Display:', 'lsx-projects' ); ?></label>
			<select name="<?php echo esc_attr( $this->get_field_name( 'display' ) ); ?>" id="<?php echo esc_attr( $this->get_field_id( 'display' ) ); ?>" class="widefat">
			<?php
				$options = array(
					esc_html__( 'Excerpt', 'lsx-projects' ) => 'excerpt',
					esc_html__( 'Full Content', 'lsx-projects' ) => 'full',
				);

				foreach ( $options as $name => $value ) {

					echo '<option value="' . esc_attr( $value ) . '" id="' . esc_attr( $value ) . '"', $display == $value ? ' selected="selected"' : '', '>', esc_html( $name ), '</option>';

				}
			?>
			</select>
		</p>
		<p>
			<label for="<?php echo esc_attr( $this->get_field_id( 'size' ) ); ?>"><?php esc_html_e( 'Image size:', 'lsx-projects' ); ?></label>
			<input class="widefat" id="<?php echo esc_attr( $this->get_field_id( 'size' ) ); ?>" name="<?php echo esc_attr( $this->get_field_name( 'size' ) ); ?>" type="text" value="<?php echo esc_attr( $size ); ?>" />
		</p>
		<p>
			<label for="<?php echo esc_attr( $this->get_field_id( 'button_text' ) ); ?>"><?php esc_html_e( 'Button "view all" text:', 'lsx-projects' ); ?></label>
			<input class="widefat" id="<?php echo esc_attr( $this->get_field_id( 'button_text' ) ); ?>" name="<?php echo esc_attr( $this->get_field_name( 'button_text' ) ); ?>" type="text" value="<?php echo esc_attr( $button_text ); ?>" />
			<small><?php esc_html_e( 'Leave empty to not display the button', 'lsx-projects' ); ?></small>
		</p>
		<p>
			<input id="<?php echo esc_attr( $this->get_field_id( 'show_image' ) ); ?>" name="<?php echo esc_attr( $this->get_field_name( 'show_image' ) ); ?>" type="checkbox" value="1" <?php checked( '1', $show_image ); ?> />
			<label for="<?php echo esc_attr( $this->get_field_id( 'show_image' ) ); ?>"><?php esc_html_e( 'Display Images', 'lsx-projects' ); ?></label>
		</p>
		<p>
			<input id="<?php echo esc_attr( $this->get_field_id( 'responsive' ) ); ?>" name="<?php echo esc_attr( $this->get_field_name( 'responsive' ) ); ?>" type="checkbox" value="1" <?php checked( '1', $responsive ); ?> />
			<label for="<?php echo esc_attr( $this->get_field_id( 'responsive' ) ); ?>"><?php esc_html_e( 'Responsive Images', 'lsx-projects' ); ?></label>
		</p>
		<p>
			<input id="<?php echo esc_attr( $this->get_field_id( 'carousel' ) ); ?>" name="<?php echo esc_attr( $this->get_field_name( 'carousel' ) ); ?>" type="checkbox" value="1" <?php checked( '1', $carousel ); ?> />
			<label for="<?php echo esc_attr( $this->get_field_id( 'carousel' ) ); ?>"><?php esc_html_e( 'Carousel', 'lsx-projects' ); ?></label>
		</p>
		<p>
			<input id="<?php echo esc_attr( $this->get_field_id( 'featured' ) ); ?>" name="<?php echo esc_attr( $this->get_field_name( 'featured' ) ); ?>" type="checkbox" value="1" <?php checked( '1', $featured ); ?> />
			<label for="<?php echo esc_attr( $this->get_field_id( 'featured' ) ); ?>"><?php esc_html_e( 'Featured posts', 'lsx-projects' ); ?></label>
		</p>
		<?php
	}


}

function lsx_projects_register_widget() {

	return register_widget( 'LSX_Projects_Widget' );
}

add_action( 'widgets_init', 'lsx_projects_register_widget' );


1			<?php
			0 ignored issues – show Coding Style introduced 2020-08-28 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this This file is missing a doc comment. Loading history...
2			/**
3			* LSX Projects Widget Class
4			*
5			* @package LSX Projects
6			* @author LightSpeed
			0 ignored issues – show introduced 2020-08-28 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Spaces must be used for mid-line alignment; tabs are not allowed Loading history...
7			* @license GPL3
8			* @link
9			* @copyright 2016 LightSpeed
10			*/
11			class LSX_Projects_Widget extends WP_Widget {
12
13			public function __construct() {
			0 ignored issues – show Coding Style Documentation introduced 2020-08-28 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Missing doc comment for function __construct() Loading history... Coding Style introduced 2020-08-28 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Expected 2 blank lines before function; 1 found Loading history...
14			$widget_ops = array(
15			'classname' => 'lsx-projects',
16			);
17
18			parent::__construct( 'LSX_Projects_Widget', esc_html__( 'LSX Projects', 'lsx-projects' ), $widget_ops );
19			}
			0 ignored issues – show Coding Style introduced 2020-08-28 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Expected 1 blank line before closing function brace; 0 found Loading history... Coding Style introduced 2020-08-28 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Expected 2 blank lines after function; 1 found Loading history...
20
21			function widget( $args, $instance ) {
			0 ignored issues – show Best Practice introduced 2020-08-14 21:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Coding Style Documentation introduced 2020-08-28 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Missing doc comment for function widget() Loading history... Comprehensibility Best Practice introduced 2020-08-28 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is recommend to declare an explicit visibility for `widget`. Generally, we recommend to declare visibility for all methods in your source code. This has the advantage of clearly communication to other developers, and also yourself, how this method should be consumed. If you are not sure which visibility to choose, it is a good idea to start with the most restrictive visibility, and then raise visibility as needed, i.e. start with `private`, and only raise it to `protected` if a sub-class needs to have access, or `public` if an external class needs access. Loading history...
22			extract( $args );
			0 ignored issues – show introduced 2020-08-28 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this extract() usage is highly discouraged, due to the complexity and unintended issues it might cause. Loading history...
23
24			$title = $instance['title'];
			0 ignored issues – show Coding Style introduced 2020-08-28 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
25			$title_link = $instance['title_link'];
			0 ignored issues – show Coding Style introduced 2020-08-28 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
26			$tagline = $instance['tagline'];
			0 ignored issues – show Coding Style introduced 2020-08-28 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
27			$columns = $instance['columns'];
			0 ignored issues – show Coding Style introduced 2020-08-28 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
28			$orderby = $instance['orderby'];
			0 ignored issues – show Coding Style introduced 2020-08-28 11:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
29			$order = $instance['order'];

lightspeeddevelopment / lsx-projects

Issues (1066)

classes/class-lsx-projects-widget.php (160 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like