lightspeeddevelopment / lsx-health-plan

templates/tab-content-recipes.php

<?php
/**
 * Template used to display post content on single pages.
 *
 * @package lsx-health-plan
 */
?>

<?php lsx_entry_before(); ?>
<article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>

	<?php lsx_entry_top(); ?>

	<div class="entry-meta">
		<?php lsx_post_meta_single_bottom(); ?>
	</div><!-- .entry-meta -->

	<div class="entry-content">
		<?php
			//the_content();

			wp_link_pages( array(
				'before'      => '<div class="lsx-postnav-wrapper"><div class="lsx-postnav">',
				'after'       => '</div></div>',
				'link_before' => '<span>',
				'link_after'  => '</span>',
			) );
		?>
		<div class="single-plan-inner recipes-content">
			<div class="single-plan-section-title recipes-plan title-lined">
				<?php lsx_get_svg_icon( 'recipes.svg' ); ?>
				<h2><?php esc_html_e( 'Recipes', 'lsx-health-plan' ); ?> <span class="blue-title"><?php the_title(); ?></span></h2>
			</div>
			<div class="recipes">
			<div class="row eating-row">
			<?php
			$connected_recipes = get_post_meta( get_the_ID(), 'connected_recipes', true );

It seems like get_the_ID() can also be of type false; however, parameter $post_id of get_post_meta() does only seem to accept integer, maybe add an additional type check?

			if ( empty( $connected_recipes ) ) {
				$options = \lsx_health_plan\functions\get_option( 'all' );
				if ( isset( $options['connected_recipes'] ) && '' !== $options['connected_recipes'] && ! empty( $options['connected_recipes'] ) ) {
					$connected_recipes = $options['connected_recipes'];
					if ( ! array( $connected_recipes ) ) {
						$connected_recipes = array( $connected_recipes );
					}
				}
			}
			$args    = array(
				'orderby'   => 'date',
				'order'     => 'DESC',
				'post_type' => 'recipe',
				'post__in'  => $connected_recipes,
			);
			$recipes = new WP_Query( $args );

			if ( $recipes->have_posts() ) {
				while ( $recipes->have_posts() ) {
					$recipes->the_post();
					$post_id = get_the_id();

					?>
					<div class="col-md-4 recipe-column">
						<div class="content-box box-shadow">
							<h3 class="recipe-title title-lined"><?php the_title(); ?></h3>
							<?php lsx_health_plan_recipe_data(); ?>
							<a href="<?php echo esc_url( get_permalink() ); ?>" class="btn btn-full"><?php esc_html_e( 'View Recipe', 'lsx-health-plan' ); ?></a>

It seems like get_permalink() can also be of type false; however, parameter $url of esc_url() does only seem to accept string, maybe add an additional type check?

						</div>
					</div>
				<?php
				}
			}
			?>
			<?php wp_reset_postdata(); ?>
			</div>
			</div>
		</div>
	</div><!-- .entry-content -->

	<?php lsx_entry_bottom(); ?>

</article><!-- #post-## -->

<?php