lightspeeddevelopment / lsx-health-plan

templates/featured-videos.php

<?php
/**
 * LSX Videos Shortcode.
 *
 * @package lsx-health-plan
 */

$args   = array(
	'orderby'        => 'date',
	'order'          => 'DESC',
	'post_type'      => 'video',
	'posts_per_page' => 3,
	'meta_key'       => 'video_featured_video',

Detected usage of meta_key, possible slow query.

	'meta_compare'   => 'EXISTS',
);
$videos = new WP_Query( $args );
?>

<div id="lsx-videos-shortcode" class="daily-plan-block">
	<h2 class="title-lined"><?php esc_html_e( 'Featured Workout', 'lsx-health-plan' ); ?></h2>
	<div class="lsx-videos-shortcode lsx-videos-slider slick-slider slick-dotted slick-has-arrows" data-slick="{'slidesToShow': 1, 'slidesToScroll': 1}" >
		<?php
		if ( $videos->have_posts() ) :

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

			while ( $videos->have_posts() ) :

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

				$videos->the_post();

				$featured = get_post_meta( get_the_ID(), 'video_featured_video', true );

It seems like get_the_ID() can also be of type false; however, parameter $post_id of get_post_meta() does only seem to accept integer, maybe add an additional type check?

				$giphy    = get_post_meta( get_the_ID(), 'video_giphy_source', true );
				$youtube  = esc_url( get_post_meta( get_the_ID(), 'video_youtube_source', 1 ) );
				?>
				<div class="lsx-videos-slot">
					<div class="row">
						<div class="col-md-4">
							<h4 class="lsx-videos-title"><?php the_title(); ?></h4>
							<?php the_content(); ?>
						</div>
						<div class="col-md-8">
							<?php
							if ( ! empty( $giphy ) ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

								echo $giphy; // WPCS: XSS OK.

Using the WPCS native whitelist comments is deprecated. Please use the PHPCS native "phpcs:ignore Standard.Category.SniffName.ErrorCode" annotations instead. Found: // WPCS: XSS OK.

							} elseif ( ! empty( $youtube ) ) {

Expected 0 spaces after opening bracket; 1 found

Expected 0 spaces before closing bracket; 1 found

								echo wp_oembed_get( $youtube ); // WPCS: XSS OK.

Are you sure wp_oembed_get($youtube) of type false|string can be used in echo?

Using the WPCS native whitelist comments is deprecated. Please use the PHPCS native "phpcs:ignore Standard.Category.SniffName.ErrorCode" annotations instead. Found: // WPCS: XSS OK.

							}
							?>
						</div>
					</div>
				</div>
		<?php endwhile; ?>

Closing brace indented incorrectly; expected 12 spaces, found 8

		<?php endif; ?>
		<?php wp_reset_postdata(); ?>
	</div>
</div>