Inspection of "testing the workout tab" - lightspeeddevelopment/lsx-health-plan - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — add/multiplan ( dea22a...7aa48d )

by Virginia

created 2020-09-24 14:42 UTC

Status

Indentation +38 added lines, -38 removed lines patch added patch discarded remove patch

@@ -8,10 +8,10 @@  discard block
 block discarded – undo
 
 $warm_up = get_post_meta( get_the_ID(), 'plan_warmup', true );
 if ( false === $warm_up || '' === $warm_up ) {
-	$options = \lsx_health_plan\functions\get_option( 'all' );
-	if ( isset( $options['plan_warmup'] ) && '' !== $options['plan_warmup'] && ! empty( $options['plan_warmup'] ) ) {
-		$warm_up = $options['plan_warmup'];
-	}
+     $options = \lsx_health_plan\functions\get_option( 'all' );
+     if ( isset( $options['plan_warmup'] ) && '' !== $options['plan_warmup'] && ! empty( $options['plan_warmup'] ) ) {
+          $warm_up = $options['plan_warmup'];
+     }
 }
 
 ?>
@@ -19,30 +19,30 @@  discard block
 block discarded – undo
 <?php
 
 if ( false !== $warm_up && '' !== $warm_up ) {
-	if ( ! is_array( $warm_up ) ) {
-		$warm_up = array( $warm_up );
-	}
+     if ( ! is_array( $warm_up ) ) {
+          $warm_up = array( $warm_up );
+     }
 
-	$warmup_type  = array( 'page', 'workout', 'exercise' );
-	$warmup_query = new WP_Query(
-		array(
-			'post__in'  => $warm_up,
-			'post_type' => $warmup_type,
-		)
-	);
+     $warmup_type  = array( 'page', 'workout', 'exercise' );
+     $warmup_query = new WP_Query(
+          array(
+               'post__in'  => $warm_up,
+               'post_type' => $warmup_type,
+          )
+     );
 
-	if ( $warmup_query->have_posts() ) {
-		while ( $warmup_query->have_posts() ) {
-			$warmup_query->the_post();
-			lsx_entry_before();
-			if ( 'workout' === get_post_type() ) {
-				$connected_workouts = array( get_the_ID() );
-				?>
+     if ( $warmup_query->have_posts() ) {
+          while ( $warmup_query->have_posts() ) {
+               $warmup_query->the_post();
+               lsx_entry_before();
+               if ( 'workout' === get_post_type() ) {
+                    $connected_workouts = array( get_the_ID() );
+                    ?>
 				<article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
 					<?php lsx_entry_top(); ?>
 					<?php
-						the_content();
-					?>
+                              the_content();
+                         ?>
 					<div class="entry-content">
 						<div class="single-plan-inner warmup-content">
 							<div class="single-plan-section-title warmup-plan title-lined">
@@ -54,9 +54,9 @@  discard block
 block discarded – undo
 					<?php lsx_entry_bottom(); ?>
 				</article><!-- #post-## -->
 				<?php
-				lsx_health_plan_workout_sets();
-			} else {
-				?>
+                    lsx_health_plan_workout_sets();
+               } else {
+                    ?>
 				<article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
 					<?php lsx_entry_top(); ?>
 					<div class="entry-content">
@@ -66,24 +66,24 @@  discard block
 block discarded – undo
 								<h2><?php esc_html_e( 'Warm Up', 'lsx-health-plan' ); ?></h2>
 							</div>
 						<?php
-							the_content();
-							wp_link_pages( array(
-								'before'      => '<div class="lsx-postnav-wrapper"><div class="lsx-postnav">',
-								'after'       => '</div></div>',
-								'link_before' => '<span>',
-								'link_after'  => '</span>',
-							) );
-						?>
+                                   the_content();
+                                   wp_link_pages( array(
+                                        'before'      => '<div class="lsx-postnav-wrapper"><div class="lsx-postnav">',
+                                        'after'       => '</div></div>',
+                                        'link_before' => '<span>',
+                                        'link_after'  => '</span>',
+                                   ) );
+                              ?>
 						</div>
 					</div><!-- .entry-content -->
 					<?php lsx_entry_bottom(); ?>
 				</article><!-- #post-## -->
 				<?php
-			}
+               }
 
-		}
-		wp_reset_postdata();
-	}
+          }
+          wp_reset_postdata();
+     }
 }
 ?>
 </div>

Please login to merge, or discard this patch.

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

@@ -6,10 +6,10 @@  discard block
 block discarded – undo
  */
 global $group_name, $connected_workouts, $shortcode_args;
 
-$warm_up = get_post_meta( get_the_ID(), 'plan_warmup', true );
-if ( false === $warm_up || '' === $warm_up ) {
-	$options = \lsx_health_plan\functions\get_option( 'all' );
-	if ( isset( $options['plan_warmup'] ) && '' !== $options['plan_warmup'] && ! empty( $options['plan_warmup'] ) ) {
+$warm_up = get_post_meta(get_the_ID(), 'plan_warmup', true);
+if (false === $warm_up || '' === $warm_up) {
+	$options = \lsx_health_plan\functions\get_option('all');
+	if (isset($options['plan_warmup']) && '' !== $options['plan_warmup'] && ! empty($options['plan_warmup'])) {
 		$warm_up = $options['plan_warmup'];
 	}
 }
@@ -18,12 +18,12 @@  discard block
 block discarded – undo
 <div class="warmup-container">
 <?php
 
-if ( false !== $warm_up && '' !== $warm_up ) {
-	if ( ! is_array( $warm_up ) ) {
-		$warm_up = array( $warm_up );
+if (false !== $warm_up && '' !== $warm_up) {
+	if ( ! is_array($warm_up)) {
+		$warm_up = array($warm_up);
 	}
 
-	$warmup_type  = array( 'page', 'workout', 'exercise' );
+	$warmup_type  = array('page', 'workout', 'exercise');
 	$warmup_query = new WP_Query(
 		array(
 			'post__in'  => $warm_up,
@@ -31,12 +31,12 @@  discard block
 block discarded – undo
 		)
 	);
 
-	if ( $warmup_query->have_posts() ) {
-		while ( $warmup_query->have_posts() ) {
+	if ($warmup_query->have_posts()) {
+		while ($warmup_query->have_posts()) {
 			$warmup_query->the_post();
 			lsx_entry_before();
-			if ( 'workout' === get_post_type() ) {
-				$connected_workouts = array( get_the_ID() );
+			if ('workout' === get_post_type()) {
+				$connected_workouts = array(get_the_ID());
 				?>
 				<article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
 					<?php lsx_entry_top(); ?>
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
 					<div class="entry-content">
 						<div class="single-plan-inner warmup-content">
 							<div class="single-plan-section-title warmup-plan title-lined">
-								<?php lsx_get_svg_icon( 'warm.svg' ); ?>
-								<h2><?php esc_html_e( 'Warm Up', 'lsx-health-plan' ); ?></h2>
+								<?php lsx_get_svg_icon('warm.svg'); ?>
+								<h2><?php esc_html_e('Warm Up', 'lsx-health-plan'); ?></h2>
 							</div>
 						</div>
 					</div><!-- .entry-content -->
@@ -62,17 +62,17 @@  discard block
 block discarded – undo
 					<div class="entry-content">
 						<div class="single-plan-inner warmup-content">
 							<div class="single-plan-section-title warmup-plan title-lined">
-								<?php lsx_get_svg_icon( 'warm.svg' ); ?>
-								<h2><?php esc_html_e( 'Warm Up', 'lsx-health-plan' ); ?></h2>
+								<?php lsx_get_svg_icon('warm.svg'); ?>
+								<h2><?php esc_html_e('Warm Up', 'lsx-health-plan'); ?></h2>
 							</div>
 						<?php
 							the_content();
-							wp_link_pages( array(
+							wp_link_pages(array(
 								'before'      => '<div class="lsx-postnav-wrapper"><div class="lsx-postnav">',
 								'after'       => '</div></div>',
 								'link_before' => '<span>',
 								'link_after'  => '</span>',
-							) );
+							));
 						?>
 						</div>
 					</div><!-- .entry-content -->

Please login to merge, or discard this patch.

		@@ -8,10 +8,10 @@ discard block
		block discarded – undo
8	8
9	9	$warm_up = get_post_meta( get_the_ID(), 'plan_warmup', true );
10	10	if ( false === $warm_up \|\| '' === $warm_up ) {
11		- $options = \lsx_health_plan\functions\get_option( 'all' );
12		- if ( isset( $options['plan_warmup'] ) && '' !== $options['plan_warmup'] && ! empty( $options['plan_warmup'] ) ) {
13		- $warm_up = $options['plan_warmup'];
14		- }
	11	+ $options = \lsx_health_plan\functions\get_option( 'all' );
	12	+ if ( isset( $options['plan_warmup'] ) && '' !== $options['plan_warmup'] && ! empty( $options['plan_warmup'] ) ) {
	13	+ $warm_up = $options['plan_warmup'];
	14	+ }
15	15	}
16	16
17	17	?>
		@@ -19,30 +19,30 @@ discard block
		block discarded – undo
19	19	<?php
20	20
21	21	if ( false !== $warm_up && '' !== $warm_up ) {
22		- if ( ! is_array( $warm_up ) ) {
23		- $warm_up = array( $warm_up );
24		- }
	22	+ if ( ! is_array( $warm_up ) ) {
	23	+ $warm_up = array( $warm_up );
	24	+ }
25	25
26		- $warmup_type = array( 'page', 'workout', 'exercise' );
27		- $warmup_query = new WP_Query(
28		- array(
29		- 'post__in' => $warm_up,
30		- 'post_type' => $warmup_type,
31		- )
32		- );
	26	+ $warmup_type = array( 'page', 'workout', 'exercise' );
	27	+ $warmup_query = new WP_Query(
	28	+ array(
	29	+ 'post__in' => $warm_up,
	30	+ 'post_type' => $warmup_type,
	31	+ )
	32	+ );
33	33
34		- if ( $warmup_query->have_posts() ) {
35		- while ( $warmup_query->have_posts() ) {
36		- $warmup_query->the_post();
37		- lsx_entry_before();
38		- if ( 'workout' === get_post_type() ) {
39		- $connected_workouts = array( get_the_ID() );
40		- ?>
	34	+ if ( $warmup_query->have_posts() ) {
	35	+ while ( $warmup_query->have_posts() ) {
	36	+ $warmup_query->the_post();
	37	+ lsx_entry_before();
	38	+ if ( 'workout' === get_post_type() ) {
	39	+ $connected_workouts = array( get_the_ID() );
	40	+ ?>
41	41	<article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
42	42	<?php lsx_entry_top(); ?>
43	43	<?php
44		- the_content();
45		- ?>
	44	+ the_content();
	45	+ ?>
46	46	<div class="entry-content">
47	47	<div class="single-plan-inner warmup-content">
48	48	<div class="single-plan-section-title warmup-plan title-lined">
		@@ -54,9 +54,9 @@ discard block
		block discarded – undo
54	54	<?php lsx_entry_bottom(); ?>
55	55	</article><!-- #post-## -->
56	56	<?php
57		- lsx_health_plan_workout_sets();
58		- } else {
59		- ?>
	57	+ lsx_health_plan_workout_sets();
	58	+ } else {
	59	+ ?>
60	60	<article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
61	61	<?php lsx_entry_top(); ?>
62	62	<div class="entry-content">
		@@ -66,24 +66,24 @@ discard block
		block discarded – undo
66	66	<h2><?php esc_html_e( 'Warm Up', 'lsx-health-plan' ); ?></h2>
67	67	</div>
68	68	<?php
69		- the_content();
70		- wp_link_pages( array(
71		- 'before' => '<div class="lsx-postnav-wrapper"><div class="lsx-postnav">',
72		- 'after' => '</div></div>',
73		- 'link_before' => '<span>',
74		- 'link_after' => '</span>',
75		- ) );
76		- ?>
	69	+ the_content();
	70	+ wp_link_pages( array(
	71	+ 'before' => '<div class="lsx-postnav-wrapper"><div class="lsx-postnav">',
	72	+ 'after' => '</div></div>',
	73	+ 'link_before' => '<span>',
	74	+ 'link_after' => '</span>',
	75	+ ) );
	76	+ ?>
77	77	</div>
78	78	</div><!-- .entry-content -->
79	79	<?php lsx_entry_bottom(); ?>
80	80	</article><!-- #post-## -->
81	81	<?php
82		- }
	82	+ }
83	83
84		- }
85		- wp_reset_postdata();
86		- }
	84	+ }
	85	+ wp_reset_postdata();
	86	+ }
87	87	}
88	88	?>
89	89	</div>

		@@ -6,10 +6,10 @@ discard block
		block discarded – undo
6	6	*/
7	7	global $group_name, $connected_workouts, $shortcode_args;
8	8
9		-$warm_up = get_post_meta( get_the_ID(), 'plan_warmup', true );
10		-if ( false === $warm_up \|\| '' === $warm_up ) {
11		- $options = \lsx_health_plan\functions\get_option( 'all' );
12		- if ( isset( $options['plan_warmup'] ) && '' !== $options['plan_warmup'] && ! empty( $options['plan_warmup'] ) ) {
	9	+$warm_up = get_post_meta(get_the_ID(), 'plan_warmup', true);
	10	+if (false === $warm_up \|\| '' === $warm_up) {
	11	+ $options = \lsx_health_plan\functions\get_option('all');
	12	+ if (isset($options['plan_warmup']) && '' !== $options['plan_warmup'] && ! empty($options['plan_warmup'])) {
13	13	$warm_up = $options['plan_warmup'];
14	14	}
15	15	}
		@@ -18,12 +18,12 @@ discard block
		block discarded – undo
18	18	<div class="warmup-container">
19	19	<?php
20	20
21		-if ( false !== $warm_up && '' !== $warm_up ) {
22		- if ( ! is_array( $warm_up ) ) {
23		- $warm_up = array( $warm_up );
	21	+if (false !== $warm_up && '' !== $warm_up) {
	22	+ if ( ! is_array($warm_up)) {
	23	+ $warm_up = array($warm_up);
24	24	}
25	25
26		- $warmup_type = array( 'page', 'workout', 'exercise' );
	26	+ $warmup_type = array('page', 'workout', 'exercise');
27	27	$warmup_query = new WP_Query(
28	28	array(
29	29	'post__in' => $warm_up,
		@@ -31,12 +31,12 @@ discard block
		block discarded – undo
31	31	)
32	32	);
33	33
34		- if ( $warmup_query->have_posts() ) {
35		- while ( $warmup_query->have_posts() ) {
	34	+ if ($warmup_query->have_posts()) {
	35	+ while ($warmup_query->have_posts()) {
36	36	$warmup_query->the_post();
37	37	lsx_entry_before();
38		- if ( 'workout' === get_post_type() ) {
39		- $connected_workouts = array( get_the_ID() );
	38	+ if ('workout' === get_post_type()) {
	39	+ $connected_workouts = array(get_the_ID());
40	40	?>
41	41	<article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
42	42	<?php lsx_entry_top(); ?>
		@@ -46,8 +46,8 @@ discard block
		block discarded – undo
46	46	<div class="entry-content">
47	47	<div class="single-plan-inner warmup-content">
48	48	<div class="single-plan-section-title warmup-plan title-lined">
49		- <?php lsx_get_svg_icon( 'warm.svg' ); ?>
50		- <h2><?php esc_html_e( 'Warm Up', 'lsx-health-plan' ); ?></h2>
	49	+ <?php lsx_get_svg_icon('warm.svg'); ?>
	50	+ <h2><?php esc_html_e('Warm Up', 'lsx-health-plan'); ?></h2>
51	51	</div>
52	52	</div>
53	53	</div><!-- .entry-content -->
		@@ -62,17 +62,17 @@ discard block
		block discarded – undo
62	62	<div class="entry-content">
63	63	<div class="single-plan-inner warmup-content">
64	64	<div class="single-plan-section-title warmup-plan title-lined">
65		- <?php lsx_get_svg_icon( 'warm.svg' ); ?>
66		- <h2><?php esc_html_e( 'Warm Up', 'lsx-health-plan' ); ?></h2>
	65	+ <?php lsx_get_svg_icon('warm.svg'); ?>
	66	+ <h2><?php esc_html_e('Warm Up', 'lsx-health-plan'); ?></h2>
67	67	</div>
68	68	<?php
69	69	the_content();
70		- wp_link_pages( array(
	70	+ wp_link_pages(array(
71	71	'before' => '<div class="lsx-postnav-wrapper"><div class="lsx-postnav">',
72	72	'after' => '</div></div>',
73	73	'link_before' => '<span>',
74	74	'link_after' => '</span>',
75		- ) );
	75	+ ));
76	76	?>
77	77	</div>
78	78	</div><!-- .entry-content -->

lightspeeddevelopment / lsx-health-plan

Push — add/multiplan ( dea22a...7aa48d )

Status

Category

Indentation +38 added lines, -38 removed lines patch added patch discarded remove patch

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch