Completed
Push — master ( 3ba758...b5e37b )
by Liaw
02:27
created
LightSaml/Tests/Action/Profile/Outbound/AuthnRequest/ACSUrlActionTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
         $endpointResolverMock->expects($this->once())
41 41
             ->method('resolve')
42 42
             ->with($this->isInstanceOf(CriteriaSet::class), $this->isType('array'))
43
-            ->willReturnCallback(function (CriteriaSet $criteriaSet, array $candidates) {
43
+            ->willReturnCallback(function(CriteriaSet $criteriaSet, array $candidates) {
44 44
                 $this->assertTrue($criteriaSet->has(DescriptorTypeCriteria::class));
45 45
                 $this->assertEquals(SpSsoDescriptor::class, $criteriaSet->getSingle(DescriptorTypeCriteria::class)->getDescriptorType());
46 46
 
Please login to merge, or discard this patch.
Tests/Action/Profile/Outbound/Message/SaveRequestStateActionTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
         $requestStateStoreMock->expects($this->once())
29 29
             ->method('set')
30 30
             ->with($this->isInstanceOf(RequestState::class))
31
-            ->willReturnCallback(function (RequestState $requestState) use ($id) {
31
+            ->willReturnCallback(function(RequestState $requestState) use ($id) {
32 32
                 $this->assertEquals($id, $requestState->getId());
33 33
             })
34 34
         ;
Please login to merge, or discard this patch.
tests/LightSaml/Tests/Context/AbstractContextTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -222,7 +222,7 @@
 block discarded – undo
222 222
         $profileContext->addSubContext('assertion_01', $assertionSubContext01 = new AssertionContext());
223 223
         $assertionSubContext01->addSubContext('rs', new RequestStateContext());
224 224
 
225
-        $actual = (string)$profileContext;
225
+        $actual = (string) $profileContext;
226 226
 
227 227
         $expected = <<<EOT
228 228
 {
Please login to merge, or discard this patch.
tests/LightSaml/Tests/Functional/Bridge/Pimple/ProfileTest.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -198,14 +198,14 @@  discard block
 block discarded – undo
198 198
         // SYSTEM
199 199
         $buildContainer->getPimple()->register(new \LightSaml\Bridge\Pimple\Container\Factory\SystemContainerProvider(true));
200 200
         if ($timeProvider) {
201
-            $pimple[SystemContainer::TIME_PROVIDER] = function () use ($timeProvider) {
201
+            $pimple[SystemContainer::TIME_PROVIDER] = function() use ($timeProvider) {
202 202
                 return $timeProvider;
203 203
             };
204 204
         }
205 205
 
206 206
         // PARTY
207 207
         $buildContainer->getPimple()->register(new \LightSaml\Bridge\Pimple\Container\Factory\PartyContainerProvider());
208
-        $pimple[PartyContainer::IDP_ENTITY_DESCRIPTOR] = function () {
208
+        $pimple[PartyContainer::IDP_ENTITY_DESCRIPTOR] = function() {
209 209
             $idpProvider = new \LightSaml\Store\EntityDescriptor\FixedEntityDescriptorStore();
210 210
             $idpProvider->add(
211 211
                 \LightSaml\Model\Metadata\EntitiesDescriptor::load(__DIR__.'/../../../../../../web/sp/testshib-providers.xml')
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
             )
228 228
         );
229 229
         if ($inResponseTo) {
230
-            $pimple[StoreContainer::REQUEST_STATE_STORE] = function () use ($inResponseTo) {
230
+            $pimple[StoreContainer::REQUEST_STATE_STORE] = function() use ($inResponseTo) {
231 231
                 $store = new RequestStateArrayStore();
232 232
                 $store->set(new RequestState($inResponseTo));
233 233
 
Please login to merge, or discard this patch.
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -164,6 +164,9 @@
 block discarded – undo
164 164
         $this->assertInstanceOf(\LightSaml\Store\EntityDescriptor\EntityDescriptorStoreInterface::class, $buildContainer->getPartyContainer()->getSpEntityDescriptorStore());
165 165
     }
166 166
 
167
+    /**
168
+     * @param string $inResponseTo
169
+     */
167 170
     private function getBuildContainer($inResponseTo = null, TimeProviderInterface $timeProvider = null)
168 171
     {
169 172
         $buildContainer = new BuildContainer($pimple = new Container());
Please login to merge, or discard this patch.
tests/LightSaml/Tests/Store/Request/RequestStateSessionStoreTest.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
 
20 20
         $sessionMock->method('set')
21 21
             ->with('main_saml_request_state_', $this->isType('array'))
22
-            ->willReturnCallback(function ($name, $value) use ($requestState) {
22
+            ->willReturnCallback(function($name, $value) use ($requestState) {
23 23
                 $this->assertArrayHasKey('aaa', $value);
24 24
                 $this->assertSame($requestState, $value['aaa']);
25 25
             });
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace LightSaml\Tests\Store\Request;
4 4
 
5
-use LightSaml\Meta\ParameterBag;
6 5
 use LightSaml\State\Request\RequestState;
7 6
 use LightSaml\Store\Request\RequestStateSessionStore;
8 7
 use LightSaml\Tests\BaseTestCase;
Please login to merge, or discard this patch.
tests/LightSaml/Tests/HelperTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -113,7 +113,7 @@
 block discarded – undo
113 113
         $this->assertEquals(43, strlen($id));
114 114
 
115 115
         $arr = array();
116
-        for ($i = 0; $i<strlen($id); $i++) {
116
+        for ($i = 0; $i < strlen($id); $i++) {
117 117
             $ch = $id[$i];
118 118
             $arr[$ch] = true;
119 119
         }
Please login to merge, or discard this patch.
src/LightSaml/Model/Protocol/LogoutRequest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
     }
53 53
 
54 54
     /**
55
-     * @param int|\DateTime|string $notOnOrAfter
55
+     * @param \DateTime $notOnOrAfter
56 56
      *
57 57
      * @return LogoutRequest
58 58
      */
Please login to merge, or discard this patch.
tests/LightSaml/Tests/Model/Protocol/ResponseTest.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -18,8 +18,6 @@
 block discarded – undo
18 18
 use LightSaml\Model\Assertion\SubjectConfirmation;
19 19
 use LightSaml\Model\Assertion\SubjectConfirmationData;
20 20
 use LightSaml\Model\Protocol\Response;
21
-use LightSaml\Model\Protocol\Status;
22
-use LightSaml\Model\Protocol\StatusCode;
23 21
 use LightSaml\Model\XmlDSig\SignatureWriter;
24 22
 use LightSaml\SamlConstants;
25 23
 use LightSaml\Credential\KeyHelper;
Please login to merge, or discard this patch.
src/LightSaml/Model/Protocol/AuthnRequest.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
     protected $subject;
57 57
 
58 58
     /**
59
-     * @param Subject|null $subject
59
+     * @param Subject $subject
60 60
      *
61 61
      * @return AuthnRequest
62 62
      */
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
     }
117 117
 
118 118
     /**
119
-     * @param NameIDPolicy|null $nameIDPolicy
119
+     * @param NameIDPolicy $nameIDPolicy
120 120
      *
121 121
      * @return AuthnRequest
122 122
      */
Please login to merge, or discard this patch.