lightSAML / lightSAML

src/LightSaml/Bridge/Pimple/Container/Factory/OwnContainerProvider.php

Spacing +2 added lines, -2 removed lines

@@ -61,11 +61,11 @@
      */
     public function register(Container $pimple)
     {
-        $pimple[OwnContainer::OWN_CREDENTIALS] = function () {
+        $pimple[OwnContainer::OWN_CREDENTIALS] = function() {
             return $this->ownCredentials;
         };
 
-        $pimple[OwnContainer::OWN_ENTITY_DESCRIPTOR_PROVIDER] = function () {
+        $pimple[OwnContainer::OWN_ENTITY_DESCRIPTOR_PROVIDER] = function() {
             return $this->ownEntityDescriptorProvider;
         };
     }

src/LightSaml/Bridge/Pimple/Container/Factory/PartyContainerProvider.php

Spacing +3 added lines, -3 removed lines

@@ -25,15 +25,15 @@
      */
     public function register(Container $pimple)
     {
-        $pimple[PartyContainer::IDP_ENTITY_DESCRIPTOR] = function () {
+        $pimple[PartyContainer::IDP_ENTITY_DESCRIPTOR] = function() {
             return new FixedEntityDescriptorStore();
         };
 
-        $pimple[PartyContainer::SP_ENTITY_DESCRIPTOR] = function () {
+        $pimple[PartyContainer::SP_ENTITY_DESCRIPTOR] = function() {
             return new FixedEntityDescriptorStore();
         };
 
-        $pimple[PartyContainer::TRUST_OPTIONS_STORE] = function () {
+        $pimple[PartyContainer::TRUST_OPTIONS_STORE] = function() {
             return new FixedTrustOptionsStore(new TrustOptions());
         };
     }

src/LightSaml/Resolver/Signature/OwnSignatureResolver.php

Spacing +2 added lines, -2 removed lines

@@ -70,10 +70,10 @@
             ->add(new EntityIdCriteria($entityDescriptor->getEntityID()))
             ->add(new UsageCriteria(UsageType::SIGNING))
             ->add(new X509CredentialCriteria())
-            ->addIf(ProfileContext::ROLE_IDP === $profileContext->getOwnRole(), function () {
+            ->addIf(ProfileContext::ROLE_IDP === $profileContext->getOwnRole(), function() {
                 return new MetadataCriteria(MetadataCriteria::TYPE_IDP, SamlConstants::VERSION_20);
             })
-            ->addIf(ProfileContext::ROLE_SP === $profileContext->getOwnRole(), function () {
+            ->addIf(ProfileContext::ROLE_SP === $profileContext->getOwnRole(), function() {
                 return new MetadataCriteria(MetadataCriteria::TYPE_SP, SamlConstants::VERSION_20);
             })
         ;

autoload.php

Spacing +3 added lines, -3 removed lines

@@ -1,8 +1,8 @@
 <?php

 

 // if library is in dev environement with its own vendor, include its autoload

-if(file_exists(__DIR__ . '/vendor'))

-    require_once __DIR__ . '/vendor/autoload.php';

+if (file_exists(__DIR__.'/vendor'))

+    require_once __DIR__.'/vendor/autoload.php';

 // if library is in vendor of another project, include the global autolaod

 else

-    require_once __DIR__ . '/../../autoload.php';

+    require_once __DIR__.'/../../autoload.php';

Braces +6 added lines, -4 removed lines

@@ -1,8 +1,10 @@
 <?php

 

 // if library is in dev environement with its own vendor, include its autoload

-if(file_exists(__DIR__ . '/vendor'))

-    require_once __DIR__ . '/vendor/autoload.php';

+if(file_exists(__DIR__ . '/vendor')) {
+    require_once __DIR__ . '/vendor/autoload.php';
+}
 // if library is in vendor of another project, include the global autolaod

-else

-    require_once __DIR__ . '/../../autoload.php';

+else {
+    require_once __DIR__ . '/../../autoload.php';
+}

tests/LightSaml/Tests/Action/ActionLogWrapperTest.php

Spacing +2 added lines, -2 removed lines

@@ -17,10 +17,10 @@
             ->method('execute')
             ->with($context);
 
-        $loggerMock  = $this->getLoggerMock();
+        $loggerMock = $this->getLoggerMock();
         $loggerMock->expects($this->once())
             ->method('debug')
-            ->willReturnCallback(function ($pMessage, $pContext) use ($action, $context) {
+            ->willReturnCallback(function($pMessage, $pContext) use ($action, $context) {
                 $expectedMessage = sprintf('Executing action "%s"', get_class($action));
                 $this->assertEquals($expectedMessage, $pMessage);
                 $this->assertArrayHasKey('context', $pContext);

Doc Comments +2 added lines, -2 removed lines

@@ -38,7 +38,7 @@ 
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|ActionInterface
+     * @return ActionInterface
      */
     private function getActionMock()
     {
@@ -46,7 +46,7 @@ 
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|\LightSaml\Context\ContextInterface
+     * @return \LightSaml\Context\ContextInterface
      */
     private function getContextMock()
     {

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use LightSaml\Action\ActionInterface;
 use LightSaml\Action\ActionLogWrapper;
 use LightSaml\Tests\BaseTestCase;
-use Psr\Log\LoggerInterface;
 
 class ActionLogWrapperTest extends BaseTestCase
 {

tests/LightSaml/Tests/Action/WrappedActionTest.php

Spacing +3 added lines, -3 removed lines

@@ -23,7 +23,7 @@ 
         $wrapper->expects($this->once())
             ->method('beforeAction')
             ->with($context)
-            ->willReturnCallback(function () use (&$beforeCalled, &$executeCalled, &$afterCalled) {
+            ->willReturnCallback(function() use (&$beforeCalled, &$executeCalled, &$afterCalled) {
                 $this->assertFalse($beforeCalled, 'beforeAction already called - should be called only once');
                 $this->assertFalse($executeCalled, 'execute should not been executed before beforeAction');
                 $this->assertFalse($afterCalled, 'afterAction should be executed before beforeAction');
@@ -33,7 +33,7 @@ 
         $action->expects($this->once())
             ->method('execute')
             ->with($context)
-            ->willReturnCallback(function () use (&$beforeCalled, &$executeCalled, &$afterCalled) {
+            ->willReturnCallback(function() use (&$beforeCalled, &$executeCalled, &$afterCalled) {
                 $this->assertTrue($beforeCalled, 'beforeAction should have been called');
                 $this->assertFalse($executeCalled, 'execute already called - should be executed only once');
                 $this->assertFalse($afterCalled, 'afterAction should be executed before beforeAction');
@@ -43,7 +43,7 @@ 
         $wrapper->expects($this->once())
             ->method('afterAction')
             ->with($context)
-            ->willReturnCallback(function () use (&$beforeCalled, &$executeCalled, &$afterCalled) {
+            ->willReturnCallback(function() use (&$beforeCalled, &$executeCalled, &$afterCalled) {
                 $this->assertTrue($beforeCalled, 'beforeAction should have been called');
                 $this->assertTrue($executeCalled, 'execute should be executed before afterAction');
                 $this->assertFalse($afterCalled, 'afterAction already called - should be executed only once');

tests/LightSaml/Tests/Action/CatchableErrorActionTest.php

Spacing +2 added lines, -2 removed lines

@@ -19,7 +19,7 @@ 
 
     public function test_execute_calls_first_action()
     {
-        $mainAction =  new CatchableErrorAction(
+        $mainAction = new CatchableErrorAction(
             $firstAction = $this->getActionMock(),
             $secondAction = $this->getActionMock()
         );
@@ -35,7 +35,7 @@ 
 
     public function test_execute_calls_second_action_if_first_throws_exception_and_add_exception_to_context()
     {
-        $mainAction =  new CatchableErrorAction(
+        $mainAction = new CatchableErrorAction(
             $firstAction = $this->getActionMock(),
             $secondAction = $this->getActionMock()
         );

Doc Comments +2 added lines, -2 removed lines

@@ -59,7 +59,7 @@ 
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|\LightSaml\Action\ActionInterface
+     * @return ActionInterface
      */
     private function getActionMock()
     {
@@ -67,7 +67,7 @@ 
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|\LightSaml\Context\ContextInterface
+     * @return ContextInterface
      */
     private function getContextMock()
     {

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use LightSaml\Context\AbstractContext;
 use LightSaml\Context\ContextInterface;
 use LightSaml\Context\Profile\ExceptionContext;
-use LightSaml\Context\Profile\ProfileContext;
 use LightSaml\Context\Profile\ProfileContexts;
 use LightSaml\Tests\BaseTestCase;
 

tests/LightSaml/Tests/Action/Profile/Inbound/Message/AbstractDestinationValidatorActionTest.php

Indentation +2 added lines, -2 removed lines

@@ -63,8 +63,8 @@
     public function makes_descriptor_type_criteria_for_own_role_provider()
     {
         return [
-           [ProfileContext::ROLE_IDP, IdpSsoDescriptor::class],
-           [ProfileContext::ROLE_SP, SpSsoDescriptor::class],
+            [ProfileContext::ROLE_IDP, IdpSsoDescriptor::class],
+            [ProfileContext::ROLE_SP, SpSsoDescriptor::class],
         ];
     }
 

Spacing +1 added lines, -1 removed lines

@@ -82,7 +82,7 @@
 
         $endpointResolverMock->expects($this->once())
             ->method('resolve')
-            ->willReturnCallback(function (CriteriaSet $criteriaSet, array $endpoints) use ($descriptorType, $expectedDestination) {
+            ->willReturnCallback(function(CriteriaSet $criteriaSet, array $endpoints) use ($descriptorType, $expectedDestination) {
                 $this->assertTrue($criteriaSet->has(LocationCriteria::class));
                 $arr = $criteriaSet->get(LocationCriteria::class);
                 $this->assertCount(1, $arr);

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 use LightSaml\Profile\Profiles;
 use LightSaml\Resolver\Endpoint\Criteria\DescriptorTypeCriteria;
 use LightSaml\Resolver\Endpoint\Criteria\LocationCriteria;
-use LightSaml\Resolver\Endpoint\EndpointResolverInterface;
 use LightSaml\Tests\BaseTestCase;
 
 class AbstractDestinationValidatorActionTest extends BaseTestCase

tests/LightSaml/Tests/Action/Profile/Inbound/Message/DestinationValidatorAuthnRequestActionTest.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
 
         $endpointResolverMock->expects($this->once())
             ->method('resolve')
-            ->willReturnCallback(function (CriteriaSet $criteriaSet, array $endpoints) {
+            ->willReturnCallback(function(CriteriaSet $criteriaSet, array $endpoints) {
                 $this->assertTrue($criteriaSet->has(ServiceTypeCriteria::class));
                 $arr = $criteriaSet->get(ServiceTypeCriteria::class);
                 $this->assertCount(1, $arr);

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 use LightSaml\Model\Protocol\AuthnRequest;
 use LightSaml\Profile\Profiles;
 use LightSaml\Resolver\Endpoint\Criteria\ServiceTypeCriteria;
-use LightSaml\Resolver\Endpoint\EndpointResolverInterface;
 use LightSaml\Tests\BaseTestCase;
 
 class DestinationValidatorAuthnRequestActionTest extends BaseTestCase