LightSaml\Idp\Action\Assertion\Outbound\AttributeAction

Complexity

Total Complexity

4

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	doExecute()	0	11	3

<?php

/*
 * This file is part of the LightSAML-IDP package.
 *
 * (c) Milos Tomic <tmilos@lightsaml.com>
 *
 * This source file is subject to the GPL-3 license that is bundled
 * with this source code in the file LICENSE.
 */

namespace LightSaml\Idp\Action\Assertion\Outbound;

use LightSaml\Action\Assertion\AbstractAssertionAction;
use LightSaml\Context\Profile\AssertionContext;
use LightSaml\Model\Assertion\AttributeStatement;
use LightSaml\Provider\Attribute\AttributeValueProviderInterface;
use Psr\Log\LoggerInterface;

/**
 * Creates AttributeStatement and sets attribute values provided by given attribute value provider.
 */
class AttributeAction extends AbstractAssertionAction
{
    /** @var AttributeValueProviderInterface */
    protected $attributeValueProvider;

    /**
     * @param LoggerInterface                 $logger
     * @param AttributeValueProviderInterface $attributeValueProvider
     */
    public function __construct(LoggerInterface $logger, AttributeValueProviderInterface $attributeValueProvider)
    {
        parent::__construct($logger);

        $this->attributeValueProvider = $attributeValueProvider;
    }

    /**
     * @param AssertionContext $context
     *
     * @return void
     */
    protected function doExecute(AssertionContext $context)
    {
        $attributes = $this->attributeValueProvider->getValues($context);
        if ($attributes) {

The expression $attributes of type LightSaml\Model\Assertion\Attribute[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $attributeStatement = new AttributeStatement();
            $context->getAssertion()->addItem($attributeStatement);
            foreach ($attributes as $attribute) {
                $attributeStatement->addAttribute($attribute);
            }
        }
    }
}