Lifeboat\Tests\ConnectorTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	19
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	testServiceFactory()	0	13	3

<?php

namespace Lifeboat\Tests;

use Lifeboat\App;
use Lifeboat\Client;
use Lifeboat\Exceptions\BadMethodException;
use Lifeboat\Exceptions\InvalidArgumentException;
use Lifeboat\Factory\ClassMap;
use Lifeboat\Utils\Utils;

class ConnectorTest extends TestCase {

    /**
     * @test
     * @covers \Lifeboat\Connector::__get
     */
    public function testServiceFactory()
    {
        $client = new Client('mock', 'mock');

        foreach (ClassMap::SERVICES as $service => $class) {
            $this->assertInstanceOf($class, $client->$service);
        }

        try {
            $client->not_existant;

The property not_existant does not exist on Lifeboat\Client. Since you implemented __get, consider adding a @property annotation.

            $this->fail('Connector::__get should have thrown an error for a service that does not exist');
        } catch (BadMethodException $e) {}

Consider adding a comment why this CATCH block is empty.

    }
}