Type::apply() - Code Metrics - libreworks/caridea-validate - Measure and Improve Code Quality continuously with Scrutinizer

Type::apply() B
last analyzed 2018-01-28 20:13 UTC

↳ Parent: Type

Complexity

Conditions	7
Paths	9

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	7.0957

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	7
cts	8
cp	0.875
rs	8.2222
c	0
b	0
f	0
cc	7
eloc	7
nc	9
nop	2
crap	7.0957

<?php
declare(strict_types=1);
/**
 * Caridea
 *
 * Licensed under the Apache License, Version 2.0 (the "License"); you may not
 * use this file except in compliance with the License. You may obtain a copy of
 * the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
 * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 * License for the specific language governing permissions and limitations under
 * the License.
 *
 * @copyright 2015-2018 LibreWorks contributors
 * @license   Apache-2.0
 */
namespace Caridea\Validate\Rule;

use Caridea\Validate\Parser;

/**
 * Compares values to some type
 *
 * @copyright 2015-2018 LibreWorks contributors
 * @license   Apache-2.0
 */
class Type implements \Caridea\Validate\Rule
{
    /**
     * @var string The operator type
     */
    private $operator;

    /**
     * Creates a new CompareRule.
     *
     * @param string $operator The operator type
     */
    protected function __construct(string $operator)
    {
        $this->operator = $operator;
    }

    /**
     * {@inheritDoc}
     */
    public function apply($value, $data = []): ?array
    {
        switch ($this->operator) {
            case "string":
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                return is_scalar($value) ? null : ['FORMAT_ERROR'];
            case "object":
                return is_object($value) || (is_array($value) && Parser::isAssociative($value)) ?
                    null : ['FORMAT_ERROR'];
        }
    }

    /**
     * Gets a rule that matches a value against another value.
     *
     * @return \Caridea\Validate\Rule\Type the created rule
     */
    public static function string(): Type
    {
        return new Type('string');
    }

    /**
     * Gets a rule that matches a value against a list of accepted values.
     *
     * @return \Caridea\Validate\Rule\Compare the created rule
     */
    public static function anyObject(): Type
    {
        return new Type('object');
    }
}


1		<?php
2		declare(strict_types=1);
3		/**
4		* Caridea
5		*
6		* Licensed under the Apache License, Version 2.0 (the "License"); you may not
7		* use this file except in compliance with the License. You may obtain a copy of
8		* the License at
9		*
10		* http://www.apache.org/licenses/LICENSE-2.0
11		*
12		* Unless required by applicable law or agreed to in writing, software
13		* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
14		* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
15		* License for the specific language governing permissions and limitations under
16		* the License.
17		*
18		* @copyright 2015-2018 LibreWorks contributors
19		* @license Apache-2.0
20		*/
21		namespace Caridea\Validate\Rule;
22
23		use Caridea\Validate\Parser;
24
25		/**
26		* Compares values to some type
27		*
28		* @copyright 2015-2018 LibreWorks contributors
29		* @license Apache-2.0
30		*/
31		class Type implements \Caridea\Validate\Rule
32		{
33		/**
34		* @var string The operator type
35		*/
36		private $operator;
37
38		/**
39		* Creates a new CompareRule.
40		*
41		* @param string $operator The operator type
42		*/
43	2	protected function __construct(string $operator)
44		{
45	2	$this->operator = $operator;
46	2	}
47
48		/**
49		* {@inheritDoc}
50		*/
51	2	public function apply($value, $data = []): ?array
52		{
53	2	switch ($this->operator) {
54	2	case "string":
		0 ignored issues – show Coding Style introduced 2018-01-28 20:13 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
55	1	return is_scalar($value) ? null : ['FORMAT_ERROR'];
56	1	case "object":
57	1	return is_object($value) \|\| (is_array($value) && Parser::isAssociative($value)) ?
58	1	null : ['FORMAT_ERROR'];
59		}
60		}
61
62		/**
63		* Gets a rule that matches a value against another value.
64		*
65		* @return \Caridea\Validate\Rule\Type the created rule
66		*/
67	1	public static function string(): Type
68		{
69	1	return new Type('string');
70		}
71
72		/**
73		* Gets a rule that matches a value against a list of accepted values.
74		*
75		* @return \Caridea\Validate\Rule\Compare the created rule
76		*/
77	1	public static function anyObject(): Type
78		{
79	1	return new Type('object');
80		}
81		}
82

libreworks / caridea-validate

Type::apply() B last analyzed 2018-01-28 20:13 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Type::apply() B
last analyzed 2018-01-28 20:13 UTC