Caridea\Http\AcceptTypes

Complexity

Total Complexity

12

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	3
C	preferred()	0	22	9

<?php
declare(strict_types=1);
/**
 * Caridea
 *
 * Licensed under the Apache License, Version 2.0 (the "License"); you may not
 * use this file except in compliance with the License. You may obtain a copy of
 * the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
 * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 * License for the specific language governing permissions and limitations under
 * the License.
 *
 * @copyright 2015-2018 LibreWorks contributors
 * @license   Apache-2.0
 */
namespace Caridea\Http;

/**
 * Provides utilities for working with the HTTP Accept header.
 *
 * @copyright 2015-2018 LibreWorks contributors
 * @license   Apache-2.0
 */
class AcceptTypes
{
    /**
     * @var \SplPriorityQueue
     */
    private $types;

    /**
     * Creates a new AcceptTypes.
     *
     * @param array $server The server variables. (e.g. `$_SERVER`)
     */
    public function __construct(array $server)
    {
        $this->types = new \SplPriorityQueue();
        if (isset($server['HTTP_ACCEPT'])) {
            foreach (preg_split('#,\s*#', $server['HTTP_ACCEPT']) as $accept) {
                $split = array_pad(preg_split('#;\s*q=#', $accept, 2), 2, 1.0);
                $this->types->insert($split[0], (float)$split[1]);
            }
        }
    }

    /**
     * Returns the most preferred MIME type out of the provided list.
     *
     * This method will iterate through the stored MIME types in preferred order
     * and attempt to match them to those provided.
     *
     * Say for example the HTTP Accept header was:
     * `text/html,application/xhtml+xml,application/xml;q=0.9,text/*;q=0.8`.
     *
     * ```php
     * // will return 'text/html'
     * $types->preferred(['text/css', 'text/html', 'application/javascript']);
     * // will return 'application/xml'
     * $types->preferred(['application/xml', 'text/css', 'application/json']);
     * // will return 'text/plain'
     * $types->preferred(['text/plain', 'text/css', 'application/json']);
     * // will return null
     * $types->preferred(['application/json', 'application/octet-stream']);
     * // will return null
     * $types->preferred([]);
     * ```
     *
     * @param string[] $types The MIME types to compare
     * @return string|null The most preferred MIME type or null
     */
    public function preferred(array $types): ?string
    {
        if (empty($types)) {
            return null;
        }
        foreach ($this->types as $type) {
            if (in_array($type, $types, true)) {
                return $type;
            } elseif ('*/*' == $type) {
                return current($types);

The expression current($types); of type string|false adds false to the return on line 86 which is incompatible with the return type documented by Caridea\Http\AcceptTypes::preferred of type string|null. It seems like you forgot to handle an error condition.

            } elseif (strlen($type) > 2 && substr($type, -2, 2) == '/*') {
                $prefix = substr($type, 0, strpos($type, '/') + 1);
                $plen = strlen($prefix);
                foreach ($types as $t) {
                    if (strncmp($prefix, $t, $plen) === 0) {
                        return $t;
                    }
                }
            }
        }
        return null;
    }
}