Completed
Pull Request — develop (#57)
by Tony
06:31
created
app/Settings/DatabaseRepository.php 2 patches
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -32,11 +32,17 @@  discard block
 block discarded – undo
32 32
 {
33 33
     // 'config_name', 'config_value'
34 34
 
35
+    /**
36
+     * @param string $key
37
+     */
35 38
     public function has($key)
36 39
     {
37 40
         return DbConfig::exactKey($key)->exists();
38 41
     }
39 42
 
43
+    /**
44
+     * @param string $key
45
+     */
40 46
     public function get($key, $default = null)
41 47
     {
42 48
         $results = DbConfig::key($key)->get(['config_name', 'config_value']);
@@ -100,6 +106,9 @@  discard block
 block discarded – undo
100 106
         return $ret;
101 107
     }
102 108
 
109
+    /**
110
+     * @param \Illuminate\Database\Eloquent\Collection $objs
111
+     */
103 112
     private function objsToArray($objs)
104 113
     {
105 114
         $ret = array();
Please login to merge, or discard this patch.
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -42,8 +42,7 @@  discard block
 block discarded – undo
42 42
         $results = DbConfig::key($key)->get(['config_name', 'config_value']);
43 43
         if (count($results) > 1) {
44 44
             return $this->collectionToArray($results);
45
-        }
46
-        elseif (count($results) == 1) {
45
+        } elseif (count($results) == 1) {
47 46
             $entry = $results->first();
48 47
             if($entry->config_name != $key) { //FIXME: better test
49 48
                 // trim the prefix
@@ -53,8 +52,7 @@  discard block
 block discarded – undo
53 52
 
54 53
             $value = $entry->config_value;
55 54
             return is_null($value) ? $default : $value;
56
-        }
57
-        else {
55
+        } else {
58 56
             return $default;
59 57
         }
60 58
     }
Please login to merge, or discard this patch.
app/Settings/Settings.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -48,8 +48,7 @@  discard block
 block discarded – undo
48 48
             foreach ($value as $k => $v) {
49 49
                 $this->database->set($k, $v);
50 50
             }
51
-        }
52
-        else {
51
+        } else {
53 52
             $this->database->set($key, $value);
54 53
         }
55 54
         return $value;
@@ -70,8 +69,7 @@  discard block
 block discarded – undo
70 69
             $currentPath = array_merge($path, array($key));
71 70
             if (is_array($val)) {
72 71
                 $result = array_merge($result, self::recursive_keys($val, $prefix, $currentPath));
73
-            }
74
-            else {
72
+            } else {
75 73
                 $result[$prefix . join('.', $currentPath)] = $val;
76 74
             }
77 75
         }
@@ -90,8 +88,7 @@  discard block
 block discarded – undo
90 88
                 if (!is_null($config)) {
91 89
                     $value = array_replace_recursive($config, $value);
92 90
                 }
93
-            }
94
-            elseif (is_null($value)) {
91
+            } elseif (is_null($value)) {
95 92
                 return Config::get('config.' . $key);
96 93
             }
97 94
 
Please login to merge, or discard this patch.