librenms /
librenmsv2
| Conditions | 4 |
| Paths | 4 |
| Total Lines | 58 |
| Code Lines | 50 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 29 | protected function buildRRDGraphParams() |
||
| 30 | { |
||
| 31 | if (isset($this->input->id) && is_numeric($this->input->id)) { |
||
| 32 | $port_ids = explode(',', $this->input->id); |
||
| 33 | $ports = $this->device->ports()->whereIn('port_id', $port_ids)->get(); |
||
| 34 | } else { |
||
| 35 | $ports = $this->device->ports()->get(); |
||
| 36 | } |
||
| 37 | $headers = []; |
||
| 38 | $defs = " COMMENT:' Now Avg Max' COMMENT:' \\n' "; |
||
| 39 | |||
| 40 | foreach ($ports as $port) { |
||
| 41 | $port_id = $port->port_id; |
||
| 42 | $rrd_file = get_port_rrdfile_path($this->device, $port->port_id); |
||
| 43 | $defs .= " DEF:outoctets$port_id=$rrd_file:OUTOCTETS:AVERAGE \ |
||
| 44 | DEF:inoctets$port_id=$rrd_file:INOCTETS:AVERAGE \ |
||
| 45 | DEF:outoctets_max$port_id=$rrd_file:OUTOCTETS:MAX \ |
||
| 46 | DEF:inoctets_max$port_id=$rrd_file:INOCTETS:MAX \ |
||
| 47 | CDEF:octets$port_id=inoctets$port_id,outoctets$port_id,+ \ |
||
| 48 | CDEF:doutoctets$port_id=outoctets$port_id,-1,* \ |
||
| 49 | CDEF:outbits$port_id=outoctets$port_id,8,* \ |
||
| 50 | CDEF:outbits_max$port_id=outoctets_max$port_id,8,* \ |
||
| 51 | CDEF:doutoctets_max$port_id=outoctets_max$port_id,-1,* \ |
||
| 52 | CDEF:doutbits$port_id=doutoctets$port_id,8,* \ |
||
| 53 | CDEF:doutbits_max$port_id=doutoctets_max$port_id,8,* \ |
||
| 54 | CDEF:inbits$port_id=inoctets$port_id,8,* \ |
||
| 55 | CDEF:inbits_max$port_id=inoctets_max$port_id,8,* \ |
||
| 56 | VDEF:totin$port_id=inoctets$port_id,TOTAL \ |
||
| 57 | VDEF:totout$port_id=outoctets$port_id,TOTAL \ |
||
| 58 | VDEF:tot$port_id=octets$port_id,TOTAL COMMENT:' \\n' \ |
||
| 59 | VDEF:95thin$port_id=inbits$port_id,95,PERCENT \ |
||
| 60 | VDEF:95thout$port_id=outbits$port_id,95,PERCENT \ |
||
| 61 | CDEF:d95thoutn$port_id=doutbits$port_id,-1,* \ |
||
| 62 | VDEF:d95thoutn95$port_id=d95thoutn$port_id,95,PERCENT \ |
||
| 63 | CDEF:d95thoutn95n$port_id=doutbits$port_id,doutbits$port_id,-,d95thoutn95$port_id,-1,*,+ \ |
||
| 64 | VDEF:d95thout$port_id=d95thoutn95n$port_id,FIRST \ |
||
| 65 | AREA:inbits_max$port_id#D7FFC7: \ |
||
| 66 | AREA:inbits$port_id#90B040: \ |
||
| 67 | LINE:inbits$port_id#608720:'In " . str_pad($port['ifDescr'], 6) . "' \ |
||
| 68 | GPRINT:inbits$port_id:LAST:%6.2lf%s \ |
||
| 69 | GPRINT:inbits$port_id:AVERAGE:%6.2lf%s \ |
||
| 70 | GPRINT:inbits_max$port_id:MAX:%6.2lf%s \ |
||
| 71 | AREA:doutbits_max$port_id#E0E0FF: \ |
||
| 72 | AREA:doutbits$port_id#8080C0: COMMENT:' \\n' \ |
||
| 73 | LINE:doutbits$port_id#606090:'Out ' \ |
||
| 74 | GPRINT:outbits$port_id:LAST:%6.2lf%s \ |
||
| 75 | GPRINT:outbits$port_id:AVERAGE:%6.2lf%s \ |
||
| 76 | GPRINT:outbits_max$port_id:MAX:%6.2lf%s COMMENT:'\n' \ |
||
| 77 | LINE1:95thin$port_id#aa0000 \ |
||
| 78 | LINE1:d95thout$port_id#aa0000"; |
||
| 79 | } |
||
| 80 | |||
| 81 | return [ |
||
| 82 | 'headers' => $headers, |
||
| 83 | 'defs' => $defs, |
||
| 84 | ]; |
||
| 85 | |||
| 86 | } |
||
| 87 | |||
| 123 |
Classes in PHP are usually named in CamelCase.
In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. The whole name starts with a capital letter as well.
Thus the name database provider becomes
DatabaseProvider.