NotificationController::update() - Code Metrics - Inspection of "Added notifications pages and api calls" - librenms/librenmsv2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#38)

by Neil

created 2016-03-01 01:43 UTC

NotificationController::update() A

↳ Parent: NotificationController

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	5
rs	9.4285
cc	1
eloc	2
nc	1
nop	3

<?php

namespace App\Http\Controllers;

use Dingo\Api\Http;
use Dingo\Api\Routing\Helpers;
use Illuminate\Http\Request;
use JavaScript;

class NotificationController extends Controller
{
    use Helpers;

    /**
     * Constructor
     */
    public function __construct() {
        $this->middleware('auth');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request, $type = null)

    {
        $notifications = $this->api->be(auth()->user())->get('/api/notifications/'.$type);


        if ($type === 'archive')
        {
            $page   = '';
            $button = ' notifications';
            $bg     = 'maroon';
        }
        else {
            $page   = 'archive';
            $button = ' archive';
            $bg     = 'blue';
        }

        return view('notifications.list', ['notifications' => $notifications, 'page' => $page, 'button' => $button, 'bg' => $bg, "type" => $type]);
    }

    public function update(Request $request, $id, $action)

    {

        return response()->json($this->api->be(auth()->user())->patch('/api/notifications/'.$id.'/'.$action));

    }

}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use Dingo\Api\Http;
6			use Dingo\Api\Routing\Helpers;
7			use Illuminate\Http\Request;
8			use JavaScript;
9
10			class NotificationController extends Controller
11			{
12			use Helpers;
13
14			/**
15			* Constructor
16			*/
17			public function __construct() {
18			$this->middleware('auth');
19			}
20
21			/**
22			* Display a listing of the resource.
23			*
24			* @return \Illuminate\Http\Response
25			*/
26			public function index(Request $request, $type = null)
			1 ignored issue – show Unused Code introduced 2016-03-01 01:02 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
27			{
28			$notifications = $this->api->be(auth()->user())->get('/api/notifications/'.$type);
			0 ignored issues – show Bug introduced 2016-03-01 01:02 UTC by Report Bug Copy Issue Report The method `user()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
29
30			if ($type === 'archive')
31			{
32			$page = '';
33			$button = ' notifications';
34			$bg = 'maroon';
35			}
36			else {
37			$page = 'archive';
38			$button = ' archive';
39			$bg = 'blue';
40			}
41
42			return view('notifications.list', ['notifications' => $notifications, 'page' => $page, 'button' => $button, 'bg' => $bg, "type" => $type]);
43			}
44
45			public function update(Request $request, $id, $action)
			1 ignored issue – show Unused Code introduced 2016-03-01 01:02 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
46			{
47
48			return response()->json($this->api->be(auth()->user())->patch('/api/notifications/'.$id.'/'.$action));
			0 ignored issues – show Bug introduced 2016-03-01 01:02 UTC by Report Bug Copy Issue Report The method `user()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
49			}
50
51			}
52

librenms / librenmsv2

Pull Request — develop (#38)

NotificationController::update() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like