Completed
Pull Request — develop (#124)
by Tony
03:18
created

UserDeviceController::destroy()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 7
Code Lines 5

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
c 1
b 0
f 0
dl 0
loc 7
rs 9.4285
cc 1
eloc 5
nc 1
nop 3
1
<?php
2
/**
3
 * UserDeviceController.php
4
 *
5
 * Controls the user device relationship
6
 *
7
 * This program is free software: you can redistribute it and/or modify
8
 * it under the terms of the GNU General Public License as published by
9
 * the Free Software Foundation, either version 3 of the License, or
10
 * (at your option) any later version.
11
 *
12
 * This program is distributed in the hope that it will be useful,
13
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
15
 * GNU General Public License for more details.
16
 *
17
 * You should have received a copy of the GNU General Public License
18
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
19
 *
20
 * @package    LibreNMS
21
 * @link       http://librenms.org
22
 * @copyright  2016 Tony Murray
23
 * @author     Tony Murray <[email protected]>
24
 */
25
26
namespace App\Http\Controllers;
27
28
use App\Http\Requests;
29
use App\Http\Requests\AdminOnlyRequest;
30
use App\Models\Device;
31
use App\Models\User;
32
33
class UserDeviceController extends Controller
34
{
35
    public function create(AdminOnlyRequest $request, $user_id)
36
    {
37
        $user = User::with('devices')->find($user_id);
38
39
        return view('users.devices-create')->withUser($user);
40
    }
41
42
    /**
43
     * @param AdminOnlyRequest $request
44
     * @param $user_id
45
     * @return mixed
46
     */
47
    public function store(AdminOnlyRequest $request, $user_id)
48
    {
49
        $user = User::find($user_id);
50
51
        $device_ids = $request->input('devices');
52
        if (count($device_ids) == 0) {
53
            return redirect()->back();
54
        }
55
56
        foreach ($device_ids as $device_id) {
0 ignored issues
show
Bug introduced by
The expression $device_ids of type string|array is not guaranteed to be traversable. How about adding an additional type check?

There are different options of fixing this problem.

  1. If you want to be on the safe side, you can add an additional type-check:

    $collection = json_decode($data, true);
    if ( ! is_array($collection)) {
        throw new \RuntimeException('$collection must be an array.');
    }
    
    foreach ($collection as $item) { /** ... */ }
    
  2. If you are sure that the expression is traversable, you might want to add a doc comment cast to improve IDE auto-completion and static analysis:

    /** @var array $collection */
    $collection = json_decode($data, true);
    
    foreach ($collection as $item) { /** .. */ }
    
  3. Mark the issue as a false-positive: Just hover the remove button, in the top-right corner of this issue for more options.

Loading history...
57
            $device = Device::find($device_id);
58
            $user->devices()->attach($device);
59
        }
60
        return redirect()->back()->with(['type' => 'success', 'message' => trans('user.text.devicesadded')]);
61
    }
62
63
    /**
64
     * @param AdminOnlyRequest $request
65
     * @param $user_id
66
     * @param $device_id
67
     * @return mixed
68
     */
69
    public function destroy(AdminOnlyRequest $request, $user_id, $device_id)
70
    {
71
        $user = User::find($user_id);
72
        $device = Device::find($device_id);
73
        $user->devices()->detach($device);
74
        return redirect()->back()->with(['type' => 'success', 'message' => trans('user.text.deviceremoved', ['hostname' => $device->hostname])]);
75
    }
76
}
77