App\Api\Controllers\DashboardWidgetController

Complexity

Total Complexity

13

Size/Duplication

Total Lines	135
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	6

Test Coverage

Coverage

18.75%

Importance

Changes	4
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	index()	0	4	1
A	create()	0	4	1
A	store()	0	20	2
A	show()	0	6	1
A	edit()	0	4	1
A	update()	0	23	3
A	destroy()	0	10	2
A	get_content()	0	5	1

<?php

namespace App\Api\Controllers;

use App\Models\Dashboard;
use App\Models\UsersWidgets;
use App\Models\Widgets;
use Dingo\Api\Http;
use Dingo\Api\Routing\Helpers;
use Illuminate\Http\Request;

class DashboardWidgetController extends Controller
{

    use Helpers;

    public function __construct() {

    }

    /**
     * Display a listing of all authorized devices
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\Response|null?

     */
    public function index(Request $request)
    {
        //
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\Response|null?

     */
    public function create()
    {
        //
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $row                         = Dashboard::find($request->dashboard_id)->widgets()->max('row') + 1;
        $user_widget                 = new UsersWidgets;
        $user_widget->user_id        = $request->user()->user_id;
        $user_widget->widget_id      = $request->widget_id;

The property widget_id does not seem to exist in Illuminate\Http\Request.

        $user_widget->col            = $request->col;

The property col does not seem to exist in Illuminate\Http\Request.

        $user_widget->row            = $row;
        $user_widget->size_x         = $request->size_x;

The property size_x does not seem to exist in Illuminate\Http\Request.

        $user_widget->size_y         = $request->size_y;

The property size_y does not seem to exist in Illuminate\Http\Request.

        $user_widget->title          = $request->title;

The property title does not seem to exist in Illuminate\Http\Request.

        $user_widget->dashboard_id   = $request->dashboard_id;

The property dashboard_id does not seem to exist in Illuminate\Http\Request.

        if ($user_widget->save())
        {
            return $this->response->array(array('statusText' => 'OK', 'user_widget_id' => $user_widget->user_widget_id));
        }
        else {
            return $this->response->errorInternal();
        }
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response

Should the return type not be array?

     */
    public function show(Request $request, $id)
    {
        $widget  = Widgets::find($id);
        $content = $this->api->be(auth()->user())->get('/api/dashboard-widget/'.$id.'/content');

The method user() does not seem to exist on object<Illuminate\Contracts\Auth\Factory>.

        return array('widget' => $widget, 'content' => $content);
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\Response|null?

     */
    public function edit($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        if ($request->input('settings'))
        {
            $users_widgets           = UsersWidgets::find($id);
            $users_widgets->settings = json_encode($request->input('settings'));
        }
        else {
            $users_widgets         = UsersWidgets::find($id);
            $users_widgets->col    = $request->input('x');
            $users_widgets->row    = $request->input('y');
            $users_widgets->size_x = $request->input('width');
            $users_widgets->size_y = $request->input('height');
        }

        if ($users_widgets->save())
        {
            return $this->response->array(array('statusText' => 'OK'));
        }
        else {
            return $this->response->errorInternal();
        }
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        if (UsersWidgets::destroy($id))
        {
            return $this->response->array(array('statusText' => 'OK'));
        }
        else {
            return $this->response->errorInternal();
        }
    }

    public function get_content($id)

The parameter $id is not used and could be removed.

This method is not in camel caps format.

    {
        $content[] = '<i class="fa fa-spinner fa-pulse fa-5x fa-fw margin-bottom"></i><span class="sr-only">Loading...</span>';

$content was never initialized. Although not strictly required by PHP, it is generally a good practice to add $content = array(); before regardless.

        return $this->response->array(array('statusText' => 'OK', 'content' => $content));
    }

}