AlertsDataTable::ajax() - Code Metrics - Inspection of "Merge pull request #98 from laf/alerts-page" - librenms/librenmsv2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( a4058d...a8d9bd )

by Tony

created 2016-04-23 16:24 UTC

AlertsDataTable::ajax() B

↳ Parent: AlertsDataTable

Complexity

Conditions	1
Paths	1

Size

Total Lines	24
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	2
Bugs	1	Features	1

Metric	Value
c	2
b	1
f	1
dl	0
loc	24
ccs	0
cts	13
cp	0
rs	8.9713
cc	1
eloc	11
nc	1
nop	0
crap	2

<?php
/**
 * app/DataTables/AlertsDataTable.php
 *
 * Datatable for alerts
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 * @package    LibreNMS
 * @link       http://librenms.org
 * @copyright  2016 Neil Lathwood
 * @author     Neil Lathwood <[email protected]>
 */

namespace App\DataTables;

use App\Models\Alerting\Alert;
use Yajra\Datatables\Services\DataTable;

class AlertsDataTable extends DataTable
{
    /**
     * Display ajax response.
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function ajax()
    {
        return $this->datatables
            ->eloquent($this->query())
            ->editColumn('state', '@if ($state == 0)
                                        <div class="label label-success">SUCCESS</div>
                                    @elseif ($state == 1)
                                        <div class="label label-danger">FAILED</div>
                                    @elseif ($state == 2)
                                        <div class="label label-warning">MUTED</div>
                                    @else
                                        <div class="label label-primary">UNKNOWN</div>
                                    @endif')
            ->editColumn('rule.name', function($this) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                return '<a href="'.url("alerting/rules/".$this['rule']['id']).'">'.$this['rule']['name'].'</a>';
            })
            ->editColumn('device.hostname', function($this) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                return '<a href="'.url("devices/".$this['device']['device_id']).'">'.$this['device']['hostname'].'</a>';
            })
            ->addColumn('actions', function() {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                return '';
            })
            ->make(true);
    }

    /**
     * Get the query object to be processed by datatables.
     *
     * @return \Illuminate\Database\Query\Builder|\Illuminate\Database\Eloquent\Builder
     */
    public function query()
    {
        $alerts = Alert::query()->where('state', '!=', '0')->with('device')->with('user')->with('rule')->select('alerts.*');
        return $this->applyScopes($alerts);
    }

    /**
     * Optional method if you want to use html builder.
     *
     * @return \Yajra\Datatables\Html\Builder
     */
    public function html()
    {
        return $this->builder()
                    ->columns($this->getColumns())
                    ->parameters($this->getBuilderParameters());
    }

    /**
     * Get columns.
     *
     * @return array
     */
    private function getColumns()
    {
        return [
            'state'     => [
                'title' => trans('alerting.alerts.text.state'),
            ],
            'rule.name' => [
                'title' => trans('alerting.alerts.text.rule'),
            ],
            'device.hostname' => [
                'title'       => trans('devices.label.hostname'),
            ],
            'timestamp',
            'rule.severity' => [
                'title'     => trans('alerting.alerts.text.severity'),
            ],
            'actions',
        ];
    }

    /**
     * Get filename for export.
     *
     * @return string
     */
    protected function filename()
    {
        return 'alerts';
    }

    /**
     * Get Builder Params
     *
     * @return array
     */
    protected function getBuilderParameters()
    {
        return [
            'dom' => 'Blfrtip',
            'lengthMenu' => [[25, 50, 100, -1], [25, 50, 100, "All"]],
            'buttons' => [
                'csv', 'excel', 'pdf', 'print', 'reset', 'reload',
            ],
        ];
    }

}


1		<?php
2		/**
3		* app/DataTables/AlertsDataTable.php
4		*
5		* Datatable for alerts
6		*
7		* This program is free software: you can redistribute it and/or modify
8		* it under the terms of the GNU General Public License as published by
9		* the Free Software Foundation, either version 3 of the License, or
10		* (at your option) any later version.
11		*
12		* This program is distributed in the hope that it will be useful,
13		* but WITHOUT ANY WARRANTY; without even the implied warranty of
14		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
15		* GNU General Public License for more details.
16		*
17		* You should have received a copy of the GNU General Public License
18		* along with this program. If not, see <http://www.gnu.org/licenses/>.
19		*
20		* @package LibreNMS
21		* @link http://librenms.org
22		* @copyright 2016 Neil Lathwood
23		* @author Neil Lathwood <[email protected]>
24		*/
25
26		namespace App\DataTables;
27
28		use App\Models\Alerting\Alert;
29		use Yajra\Datatables\Services\DataTable;
30
31		class AlertsDataTable extends DataTable
32		{
33		/**
34		* Display ajax response.
35		*
36		* @return \Illuminate\Http\JsonResponse
37		*/
38		public function ajax()
39		{
40		return $this->datatables
41		->eloquent($this->query())
42		->editColumn('state', '@if ($state == 0)
43		<div class="label label-success">SUCCESS</div>
44		@elseif ($state == 1)
45		<div class="label label-danger">FAILED</div>
46		@elseif ($state == 2)
47		<div class="label label-warning">MUTED</div>
48		@else
49		<div class="label label-primary">UNKNOWN</div>
50		@endif')
51		->editColumn('rule.name', function($this) {
		0 ignored issues – show Documentation introduced 2016-04-23 00:43 UTC by Report Bug Copy Issue Report `function ($this) { r...e']['name'] . '</a>'; }` is of type `object<Closure>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
52		return '<a href="'.url("alerting/rules/".$this['rule']['id']).'">'.$this['rule']['name'].'</a>';
53		})
54		->editColumn('device.hostname', function($this) {
		0 ignored issues – show Documentation introduced 2016-04-23 00:43 UTC by Report Bug Copy Issue Report `function ($this) { r...'hostname'] . '</a>'; }` is of type `object<Closure>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
55		return '<a href="'.url("devices/".$this['device']['device_id']).'">'.$this['device']['hostname'].'</a>';
56		})
57		->addColumn('actions', function() {
		0 ignored issues – show Documentation introduced 2016-04-23 15:17 UTC by Report Bug Copy Issue Report `function () { return ''; }` is of type `object<Closure>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
58		return '';
59		})
60		->make(true);
61		}
62
63		/**
64		* Get the query object to be processed by datatables.
65		*
66		* @return \Illuminate\Database\Query\Builder\|\Illuminate\Database\Eloquent\Builder
67		*/
68		public function query()
69		{
70		$alerts = Alert::query()->where('state', '!=', '0')->with('device')->with('user')->with('rule')->select('alerts.*');
71		return $this->applyScopes($alerts);
72		}
73
74		/**
75		* Optional method if you want to use html builder.
76		*
77		* @return \Yajra\Datatables\Html\Builder
78		*/
79	1	public function html()
80		{
81	1	return $this->builder()
82	1	->columns($this->getColumns())
83	1	->parameters($this->getBuilderParameters());
84		}
85
86		/**
87		* Get columns.
88		*
89		* @return array
90		*/
91	1	private function getColumns()
92		{
93		return [
94		'state' => [
95	1	'title' => trans('alerting.alerts.text.state'),
96	1	],
97		'rule.name' => [
98	1	'title' => trans('alerting.alerts.text.rule'),
99	1	],
100		'device.hostname' => [
101	1	'title' => trans('devices.label.hostname'),
102	1	],
103	1	'timestamp',
104		'rule.severity' => [
105	1	'title' => trans('alerting.alerts.text.severity'),
106	1	],
107	1	'actions',
108	1	];
109		}
110
111		/**
112		* Get filename for export.
113		*
114		* @return string
115		*/
116		protected function filename()
117		{
118		return 'alerts';
119		}
120
121		/**
122		* Get Builder Params
123		*
124		* @return array
125		*/
126	1	protected function getBuilderParameters()
127		{
128		return [
129	1	'dom' => 'Blfrtip',
130	1	'lengthMenu' => [[25, 50, 100, -1], [25, 50, 100, "All"]],
131		'buttons' => [
132	1	'csv', 'excel', 'pdf', 'print', 'reset', 'reload',
133	1	],
134	1	];
135		}
136
137		}
138

librenms / librenmsv2

Push — develop ( a4058d...a8d9bd )

AlertsDataTable::ajax() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like