librenms /
librenmsv2
| Conditions | 12 |
| Paths | 38 |
| Total Lines | 49 |
| Code Lines | 31 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 53 | public function handle() |
||
| 54 | { |
||
| 55 | $delete = $this->option('delete'); |
||
| 56 | if ($this->option('pop') || $delete) { |
||
| 57 | if ($delete) { |
||
| 58 | $device = Device::find($delete); |
||
| 59 | } else { |
||
| 60 | $device = Device::orderBy('device_id', 'desc')->first(); |
||
| 61 | } |
||
| 62 | |||
| 63 | $device->delete(); |
||
| 64 | return; |
||
| 65 | } |
||
| 66 | |||
| 67 | // Fire off an event, just randomly grabbing the first user for now |
||
| 68 | $id = $this->option('id'); |
||
| 69 | |||
| 70 | if ($id == 'all') { |
||
| 71 | $this->info('all'); |
||
| 72 | $devices = Device::all(); |
||
| 73 | } elseif ($this->option('push')) { |
||
| 74 | $this->info('push'); |
||
| 75 | $devices = [new Device(['hostname' => 'Mockery'])]; |
||
| 76 | } elseif ($id === null) { |
||
| 77 | $this->info('first'); |
||
| 78 | $devices = [Device::first()]; |
||
| 79 | } else { |
||
| 80 | $this->info('findOrNew'); |
||
| 81 | $devices = [Device::findOrNew($id)]; |
||
| 82 | } |
||
| 83 | |||
| 84 | /** @var Device $device */ |
||
| 85 | foreach ($devices as $device) { |
||
| 86 | if ($this->option('status') !== null) { |
||
| 87 | $device->status = $this->option('status'); |
||
| 88 | } |
||
| 89 | |||
| 90 | if ($this->option('uptime') !== null) { |
||
| 91 | $device->uptime = $this->option('uptime'); |
||
| 92 | } |
||
| 93 | |||
| 94 | $device->save(); |
||
| 95 | |||
| 96 | if (empty($device->hostname) || $device->hostname == 'Mockery') { |
||
| 97 | $device->hostname = 'Mockery'.$device->device_id; |
||
| 98 | $device->save(); |
||
| 99 | } |
||
| 100 | } |
||
| 101 | } |
||
| 102 | } |
||
| 103 |
