HomeController - Code Metrics - Inspection of "Overview page, widgets, dashboard inc testing" - librenms/librenmsv2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#76)

by Neil

created 2016-04-13 20:19 UTC

HomeController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	3
Bugs	0	Features	2

Metric	Value
wmc	7
lcom	1
cbo	6
dl	0
loc	49
rs	10
c	3
b	0
f	2

5 Methods

Rating	Name	Size	Complexity
A	__construct()	3	1
A	redirect()	13	2
A	index()	4	1
A	show()	15	2
A	about()	5	1

<?php

namespace App\Http\Controllers;

use Dingo\Api\Http;
use Dingo\Api\Routing\Helpers;
use Illuminate\Http\Request;
use App\Models\Dashboard;
use JWTAuth;
use Tymon\JWTAuth\Exceptions\JWTException;

class HomeController extends Controller
{
    use Helpers;

    public function __construct(Request $request) {

        $this->middleware('auth');
    }

    public function redirect(Request $request)
    {
        $dashboard = Dashboard::where('user_id', $request->user()->user_id)->first();
        if (empty($dashboard->dashboard_id))
        {
            $dashboard = new dashboard;
            $dashboard->user_id        = $request->user()->user_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $dashboard->dashboard_name = 'Default';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $dashboard->access         = 0;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $dashboard->save();
        }
        return redirect()->route('dashboard.show', ['id' => $dashboard->dashboard_id]);
    }

    public function index(Request $request) {
        $dashboards = $this->api->be(auth()->user())->get('/api/dashboard');

        return view('home', ['dashboards' => $dashboards, 'request' => $request]);
    }

    public function show(Request $request)
    {
        $token      = JWTAuth::fromUser(auth()->user());

        $dashboards = $this->api->be(auth()->user())->get('/api/dashboard');

        if (Dashboard::find($request->route('dashboard_id')))
        {
            $dash    = $this->api->be(auth()->user())->get('/api/dashboard/'.$request->route('dashboard_id'));

            $widgets = $this->api->be(auth()->user())->get('/api/widget');

        }
        else {
            $dash    = array();
            $widgets = array();
        }
        return view('home', ['dashboards' => $dashboards, 'request' => $request, 'dash_widgets' => $dash['widgets'], 'token' => $token, 'dash_details' => $dash['dashboard'], 'widgets' => $widgets]);
    }

    public function about() {
        $versions = $this->api->be(auth()->user())->get('/api/info');

        $stats    = $this->api->be(auth()->user())->get('/api/stats');

        return view('general.about', ['versions' => $versions, 'stats' => $stats]);
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use Dingo\Api\Http;
6			use Dingo\Api\Routing\Helpers;
7			use Illuminate\Http\Request;
8			use App\Models\Dashboard;
9			use JWTAuth;
10			use Tymon\JWTAuth\Exceptions\JWTException;
11
12			class HomeController extends Controller
13			{
14			use Helpers;
15
16			public function __construct(Request $request) {
			1 ignored issue – show Unused Code introduced 2016-02-23 18:21 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
17			$this->middleware('auth');
18			}
19
20			public function redirect(Request $request)
21			{
22			$dashboard = Dashboard::where('user_id', $request->user()->user_id)->first();
23			if (empty($dashboard->dashboard_id))
24			{
25			$dashboard = new dashboard;
26			$dashboard->user_id = $request->user()->user_id;
			0 ignored issues – show Documentation introduced 2016-04-13 20:27 UTC by Report Bug Copy Issue Report The property `user_id` does not exist on `object<App\Models\Dashboard>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
27			$dashboard->dashboard_name = 'Default';
			0 ignored issues – show Documentation introduced 2016-04-13 20:27 UTC by Report Bug Copy Issue Report The property `dashboard_name` does not exist on `object<App\Models\Dashboard>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
28			$dashboard->access = 0;
			0 ignored issues – show Documentation introduced 2016-04-13 20:27 UTC by Report Bug Copy Issue Report The property `access` does not exist on `object<App\Models\Dashboard>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
29			$dashboard->save();
30			}
31			return redirect()->route('dashboard.show', ['id' => $dashboard->dashboard_id]);
32			}
33
34			public function index(Request $request) {
35			$dashboards = $this->api->be(auth()->user())->get('/api/dashboard');
			0 ignored issues – show Bug introduced 2016-04-13 20:27 UTC by Report Bug Copy Issue Report The method `user()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
36			return view('home', ['dashboards' => $dashboards, 'request' => $request]);
37			}
38
39			public function show(Request $request)
40			{
41			$token = JWTAuth::fromUser(auth()->user());
			0 ignored issues – show Bug introduced 2016-04-13 20:27 UTC by Report Bug Copy Issue Report The method `user()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
42			$dashboards = $this->api->be(auth()->user())->get('/api/dashboard');
			0 ignored issues – show Bug introduced 2016-04-13 20:27 UTC by Report Bug Copy Issue Report The method `user()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
43			if (Dashboard::find($request->route('dashboard_id')))
44			{
45			$dash = $this->api->be(auth()->user())->get('/api/dashboard/'.$request->route('dashboard_id'));
			0 ignored issues – show Bug introduced 2016-04-13 20:27 UTC by Report Bug Copy Issue Report The method `user()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
46			$widgets = $this->api->be(auth()->user())->get('/api/widget');
			0 ignored issues – show Bug introduced 2016-04-13 20:27 UTC by Report Bug Copy Issue Report The method `user()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
47			}
48			else {
49			$dash = array();
50			$widgets = array();
51			}
52			return view('home', ['dashboards' => $dashboards, 'request' => $request, 'dash_widgets' => $dash['widgets'], 'token' => $token, 'dash_details' => $dash['dashboard'], 'widgets' => $widgets]);
53			}
54
55			public function about() {
56			$versions = $this->api->be(auth()->user())->get('/api/info');
			0 ignored issues – show Bug introduced 2016-02-25 09:52 UTC by Report Bug Copy Issue Report The method `user()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
57			$stats = $this->api->be(auth()->user())->get('/api/stats');
			0 ignored issues – show Bug introduced 2016-02-26 17:12 UTC by Report Bug Copy Issue Report The method `user()` does not seem to exist on `object<Illuminate\Contracts\Auth\Factory>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
58			return view('general.about', ['versions' => $versions, 'stats' => $stats]);
59			}
60			}
61

librenms / librenmsv2

Pull Request — develop (#76)

HomeController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like