App\Api\Controllers\NotificationController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	6
Bugs	1	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	2	1
A	index()	0	11	2
B	update()	0	23	5

<?php

namespace App\Api\Controllers;

use Dingo\Api\Http;
use Dingo\Api\Routing\Helpers;
use App\Notification;
use App\NotificationAttrib;
use Illuminate\Http\Request;

class NotificationController extends Controller
{

    use Helpers;

    public function __construct() {
    }

    /**
     * Display a listing of all notifications
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request, $type = null)
    {
        if ($type === 'archive')
        {
            $notifications = Notification::IsArchived($request)->get();

The method IsArchived() does not exist on App\Notification. Did you maybe mean scopeIsArchived()?

        }
        else {
            $notifications = Notification::IsUnread()->get();

The method IsUnread() does not exist on App\Notification. Did you maybe mean scopeIsUnread()?

        }
        return $notifications;
    }

    public function update(Request $request, $id, $action)

The parameter $request is not used and could be removed.

    {

        $notification = Notification::find($id);
        $enable = strpos($action, 'un') === false;
        if(!$enable) {
            $action = substr($action, 2);
        }

        if ($action == 'read') {
           $result = $notification->markRead($enable);
        }
        elseif ($action == 'sticky') {
           $result = $notification->markSticky(false);
        }

        if ($result === false) {

The variable $result does not seem to be defined for all execution paths leading up to this point.

            return $this->response->errorInternal();
        }
        else {
            return $this->response->array(array('statusText'=>'OK'));
        }
    }

}