MigrateSettings::handle() - Code Metrics - Inspection of "Merge pull request #128 from murrant/settings" - librenms/librenmsv2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( c61736...9994ff )

by Neil

created 2016-05-14 15:38 UTC

MigrateSettings::handle() C

↳ Parent: MigrateSettings

Complexity

Conditions	8
Paths	21

Size

Total Lines	38
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	38
rs	5.3846
cc	8
eloc	21
nc	21
nop	0

<?php
/**
 * MigrateSettings.php
 *
 * Command line to migrate settings from LibreNMS v1
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 * @package    LibreNMS
 * @link       http://librenms.org
 * @copyright  2016 Tony Murray
 * @author     Tony Murray <[email protected]>
 */

namespace App\Console\Commands;

use App\Models\DbConfig;
use Config;
use Illuminate\Console\Command;
use Settings;

class MigrateSettings extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'librenms:migrate-settings
    {--force} : Force the migration. WARNING: May lose some of your settings.
    {--dry-run} : Print changes that would be made, but do not commit them.';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Import settings from config.php that existed in the database previously into the database.  (The database now overrides config.php)';

    /**
     * Create a new command instance.
     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        if (Settings::get('settings.migrated')) {
            $this->info(trans('commands.migrate-settings.migrated'));

            if (!$this->option('force')) {
                return;
            }
            $this->warn(trans('commands.migrate-settings.migrated_warning'));

        }

        $settings = DbConfig::pluck('config_name');

        foreach ($settings as $key) {
            $config_key = '_config.'.$key;

            if (Config::has($config_key)) {
                $old = Settings::get($key);
                $new = Config::get($config_key);

                if ($old !== $new) {
                    $this->info(trans('commands.migrate-settings.migrating', ['setting' => $key, 'old' => $old, 'new' => $new]));


                    if (!$this->option('dry-run')) {
                        // we aren't authenticated so we can't write through the Settings facade
                        DbConfig::updateOrCreate(['config_name' => $key], ['config_value' => $new]);
                    }
                }
            }
        }

        if ($this->option('dry-run')) {
            $this->warn(trans('commands.migrate-settings.nochanges'));

        }
        else {
            Settings::flush();  // clear the settings cache
            DbConfig::updateOrCreate(['config_name' => 'settings.migrated'], ['config_value' => true]);
        }
    }
}


1			<?php
2			/**
3			* MigrateSettings.php
4			*
5			* Command line to migrate settings from LibreNMS v1
6			*
7			* This program is free software: you can redistribute it and/or modify
8			* it under the terms of the GNU General Public License as published by
9			* the Free Software Foundation, either version 3 of the License, or
10			* (at your option) any later version.
11			*
12			* This program is distributed in the hope that it will be useful,
13			* but WITHOUT ANY WARRANTY; without even the implied warranty of
14			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
15			* GNU General Public License for more details.
16			*
17			* You should have received a copy of the GNU General Public License
18			* along with this program. If not, see <http://www.gnu.org/licenses/>.
19			*
20			* @package LibreNMS
21			* @link http://librenms.org
22			* @copyright 2016 Tony Murray
23			* @author Tony Murray <[email protected]>
24			*/
25
26			namespace App\Console\Commands;
27
28			use App\Models\DbConfig;
29			use Config;
30			use Illuminate\Console\Command;
31			use Settings;
32
33			class MigrateSettings extends Command
34			{
35			/**
36			* The name and signature of the console command.
37			*
38			* @var string
39			*/
40			protected $signature = 'librenms:migrate-settings
41			{--force} : Force the migration. WARNING: May lose some of your settings.
42			{--dry-run} : Print changes that would be made, but do not commit them.';
43
44			/**
45			* The console command description.
46			*
47			* @var string
48			*/
49			protected $description = 'Import settings from config.php that existed in the database previously into the database. (The database now overrides config.php)';
50
51			/**
52			* Create a new command instance.
53			*/
54			public function __construct()
55			{
56			parent::__construct();
57			}
58
59			/**
60			* Execute the console command.
61			*
62			* @return mixed
63			*/
64			public function handle()
65			{
66			if (Settings::get('settings.migrated')) {
67			$this->info(trans('commands.migrate-settings.migrated'));
			1 ignored issue – show Bug introduced 2016-05-14 13:50 UTC by Report Bug Copy Issue Report It seems like `trans('commands.migrate-settings.migrated')` targeting `trans()` can also be of type `object<Symfony\Component...on\TranslatorInterface>`; however, `Illuminate\Console\Command::info()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
68			if (!$this->option('force')) {
69			return;
70			}
71			$this->warn(trans('commands.migrate-settings.migrated_warning'));
			1 ignored issue – show Bug introduced 2016-05-14 13:50 UTC by Report Bug Copy Issue Report It seems like `trans('commands.migrate-...ings.migrated_warning')` targeting `trans()` can also be of type `object<Symfony\Component...on\TranslatorInterface>`; however, `Illuminate\Console\Command::warn()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
72			}
73
74			$settings = DbConfig::pluck('config_name');
75
76			foreach ($settings as $key) {
77			$config_key = '_config.'.$key;
78
79			if (Config::has($config_key)) {
80			$old = Settings::get($key);
81			$new = Config::get($config_key);
82
83			if ($old !== $new) {
84			$this->info(trans('commands.migrate-settings.migrating', ['setting' => $key, 'old' => $old, 'new' => $new]));
			1 ignored issue – show Bug introduced 2016-05-14 13:50 UTC by Report Bug Copy Issue Report It seems like `trans('commands.migrate-...> $old, 'new' => $new))` targeting `trans()` can also be of type `object<Symfony\Component...on\TranslatorInterface>`; however, `Illuminate\Console\Command::info()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
85
86			if (!$this->option('dry-run')) {
87			// we aren't authenticated so we can't write through the Settings facade
88			DbConfig::updateOrCreate(['config_name' => $key], ['config_value' => $new]);
89			}
90			}
91			}
92			}
93
94			if ($this->option('dry-run')) {
95			$this->warn(trans('commands.migrate-settings.nochanges'));
			1 ignored issue – show Bug introduced 2016-05-14 14:09 UTC by Report Bug Copy Issue Report It seems like `trans('commands.migrate-settings.nochanges')` targeting `trans()` can also be of type `object<Symfony\Component...on\TranslatorInterface>`; however, `Illuminate\Console\Command::warn()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
96			}
97			else {
98			Settings::flush(); // clear the settings cache
99			DbConfig::updateOrCreate(['config_name' => 'settings.migrated'], ['config_value' => true]);
100			}
101			}
102			}
103

librenms / librenmsv2

Push — develop ( c61736...9994ff )

MigrateSettings::handle() C

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like