App\Http\Controllers\PortController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	56
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	3	3	1
A	index()	5	5	1
A	show()	4	4	1
A	edit()	4	4	1
A	update()	4	4	1

<?php

namespace App\Http\Controllers;

use Dingo\Api\Http;
use Dingo\Api\Routing\Router;
use Dingo\Api\Routing\Helpers;
use App\Http\Requests;
use Illuminate\Http\Request;
use JWTAuth;

class PortController extends Controller

This class seems to be duplicated in your project.

{
    use Helpers;

    /**
     * Constructor
     */
    public function __construct(Request $request) {

The parameter $request is not used and could be removed.

        $this->middleware('auth');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $ports = $this->api->be(auth()->user())->get('/api/ports');

The method user() does not seem to exist on object<Illuminate\Contracts\Auth\Factory>.

        return view('ports.list', ['ports'=>$ports]);
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)

The parameter $id is not used and could be removed.

    {
        // show a single device
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)

The parameter $id is not used and could be removed.

    {
        //edit device form??
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)

The parameter $request is not used and could be removed.

The parameter $id is not used and could be removed.

    {
        //process device modify
    }
}