DeleteUser::handle() - Code Metrics - Inspection of "user:delete command" - librenms/librenmsv2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#69)

unknown

created 2016-04-07 14:22 UTC

DeleteUser::handle() B

↳ Parent: DeleteUser

Complexity

Conditions	5
Paths	9

Size

Total Lines	24
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
c	4
b	0
f	0
dl	0
loc	24
rs	8.5125
cc	5
eloc	16
nc	9
nop	0

<?php

namespace App\Console\Commands;

use App\Models\User;
use Illuminate\Console\Command;

class DeleteUser extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'user:delete
                            {user : The user to search}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Remove a user';

    /**
     * Create a new command instance.
     *
     * @return void

     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $user = $this->argument('user');
        $user_list = User::select('username')->where('username', 'like', '%'.$user.'%')->orWhere('realname','like', '%'.$user.'%')->get();
        $names = [];

        if (count($user_list) < 1 ) {
            $this->info('No user found.');
            return;
        }
        foreach ($user_list as $i) {
            array_push($names,$i->username);
        }
        if (count($names) > 1) {
            $name = $this->choice('Who would you like to remove?',$names, false);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        else {
            $name = $names[0];
        }
        if ($this->confirm('Do you wish to remove '.$name.'?')) {
            $remove_user = User::select('user_id')->where('username', $name)->delete();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $this->info('User deleted.');
        }
    }
}


1			<?php
2
3			namespace App\Console\Commands;
4
5			use App\Models\User;
6			use Illuminate\Console\Command;
7
8			class DeleteUser extends Command
9			{
10			/**
11			* The name and signature of the console command.
12			*
13			* @var string
14			*/
15			protected $signature = 'user:delete
16			{user : The user to search}';
17
18			/**
19			* The console command description.
20			*
21			* @var string
22			*/
23			protected $description = 'Remove a user';
24
25			/**
26			* Create a new command instance.
27			*
28			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-04-04 12:56 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
29			*/
30			public function __construct()
31			{
32			parent::__construct();
33			}
34
35			/**
36			* Execute the console command.
37			*
38			* @return mixed
39			*/
40			public function handle()
41			{
42			$user = $this->argument('user');
43			$user_list = User::select('username')->where('username', 'like', '%'.$user.'%')->orWhere('realname','like', '%'.$user.'%')->get();
44			$names = [];
45
46			if (count($user_list) < 1 ) {
47			$this->info('No user found.');
48			return;
49			}
50			foreach ($user_list as $i) {
51			array_push($names,$i->username);
52			}
53			if (count($names) > 1) {
54			$name = $this->choice('Who would you like to remove?',$names, false);
			0 ignored issues – show Documentation introduced 2016-04-04 12:56 UTC by Report Bug Copy Issue Report `false` is of type `boolean`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
55			}
56			else {
57			$name = $names[0];
58			}
59			if ($this->confirm('Do you wish to remove '.$name.'?')) {
60			$remove_user = User::select('user_id')->where('username', $name)->delete();
			0 ignored issues – show Unused Code introduced 2016-04-04 15:08 UTC by Report Bug Copy Issue Report `$remove_user` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
61			$this->info('User deleted.');
62			}
63			}
64			}
65

librenms / librenmsv2

Pull Request — develop (#69)

DeleteUser::handle() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like