Completed
Pull Request — develop (#143)
by Tony
04:52
created
app/Http/Controllers/DeviceGroupController.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -195,7 +195,8 @@
 block discarded – undo
195 195
         $user = \Auth::user();
196 196
         if (!is_null($user) && $user->isAdmin()) {
197 197
             return false;
198
-        } else {
198
+        }
199
+        else {
199 200
             return 'auth';
200 201
         }
201 202
     }
Please login to merge, or discard this patch.
app/Http/Controllers/DeviceController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -18,10 +18,10 @@
 block discarded – undo
18 18
      *
19 19
      * @return \Illuminate\Http\JsonResponse|\Illuminate\View\View
20 20
      */
21
-    public function index(DeviceDataTable $dataTable, $group_id=-1)
21
+    public function index(DeviceDataTable $dataTable, $group_id = -1)
22 22
     {
23 23
         $group_name = "";
24
-        if($group_id >= 0) {
24
+        if ($group_id >= 0) {
25 25
             $dataTable->addScope(new \App\DataTables\Scopes\DeviceGroup($group_id));
26 26
             $group_name = DeviceGroup::find($group_id)->name;
27 27
         }
Please login to merge, or discard this patch.
app/Models/DeviceGroup.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
211 211
         }
212 212
 
213 213
         foreach (Settings::get('alert.macros.group', []) as $macro => $value) {
214
-            $value = str_replace(['%', '&&', '||'], ['', 'AND', 'OR'], $value);  // this might need something more complex
214
+            $value = str_replace(['%', '&&', '||'], ['', 'AND', 'OR'], $value); // this might need something more complex
215 215
             if (!str_contains($macro, ' ')) {
216 216
                 $pattern = str_replace('macros.'.$macro, '('.$value.')', $pattern);
217 217
             }
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
         $related = $this->getRelation('deviceCountRelation')->first();
261 261
 
262 262
         // then return the count directly
263
-        return ($related) ? (int)$related->count : 0;
263
+        return ($related) ? (int) $related->count : 0;
264 264
     }
265 265
 
266 266
     /**
Please login to merge, or discard this patch.
Braces   +16 added lines, -8 removed lines patch added patch discarded remove patch
@@ -97,7 +97,8 @@  discard block
 block discarded – undo
97 97
         $query = null;
98 98
         if (count($tables) == 1) {
99 99
             $query = DB::table($tables[0])->select('device_id')->distinct();
100
-        } else {
100
+        }
101
+        else {
101 102
             $query = DB::table('devices')->select('devices.device_id')->distinct();
102 103
 
103 104
             foreach ($tables as $table) {
@@ -136,7 +137,8 @@  discard block
 block discarded – undo
136 137
             if (starts_with($cur, '%')) {
137 138
                 // table and column or macro
138 139
                 $out .= substr($cur, 1).' ';
139
-            } elseif (substr($cur, -1) == '~') {
140
+            }
141
+            elseif (substr($cur, -1) == '~') {
140 142
                 // like operator
141 143
                 $content = $parts[++$i]; // grab the content so we can format it
142 144
 
@@ -147,14 +149,18 @@  discard block
 block discarded – undo
147 149
 
148 150
                 $out .= "LIKE('".$this->convertRegexToLike($content)."') ";
149 151
 
150
-            } elseif ($cur == '&&') {
152
+            }
153
+            elseif ($cur == '&&') {
151 154
                 $out .= 'AND ';
152
-            } elseif ($cur == '||') {
155
+            }
156
+            elseif ($cur == '||') {
153 157
                 $out .= 'OR ';
154
-            } elseif (in_array($cur, $ops)) {
158
+            }
159
+            elseif (in_array($cur, $ops)) {
155 160
                 // pass-through operators
156 161
                 $out .= $cur.' ';
157
-            } else {
162
+            }
163
+            else {
158 164
                 // user supplied input
159 165
                 $out .= "'".trim($cur, '"\'')."' "; // TODO: remove trim, only needed with invalid input
160 166
             }
@@ -185,7 +191,8 @@  discard block
 block discarded – undo
185 191
         // add ends appropriately
186 192
         if ($startAnchor && !$endAnchor) {
187 193
             $pattern .= '%';
188
-        } elseif (!$startAnchor && $endAnchor) {
194
+        }
195
+        elseif (!$startAnchor && $endAnchor) {
189 196
             $pattern = '%'.$pattern;
190 197
         }
191 198
 
@@ -220,7 +227,8 @@  discard block
 block discarded – undo
220 227
         if (str_contains($pattern, 'macros.')) {
221 228
             if (++$x < 30) {
222 229
                 $pattern = self::applyGroupMacros($pattern, $x);
223
-            } else {
230
+            }
231
+            else {
224 232
                 return false;
225 233
             }
226 234
         }
Please login to merge, or discard this patch.