AbstractOS - Code Metrics - Inspection of "WIP Device List + OS" - librenms/librenmsv2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#44)

by Daniel

created 2016-03-05 12:54 UTC

AbstractOS A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
wmc	6
c	1
b	0
f	1
lcom	0
cbo	0
dl	0
loc	33
rs	10

3 Methods

Rating	Name	Size	Complexity
A	__construct()	3	1
A	__get()	10	3
A	__isset()	3	2

<?php
namespace App\OS;

class AbstractOS {
    /**
     * Constructor
     */
    final public function __construct(\App\Device $device) {
        $this->device = $device;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Get Magic Function
     * @param mixed $e Element to return
     * @return mixed
     */
    final public function __get($e) {
        if( isset($this->$e) ) {
            list($tmp) = explode(" ",$this->device->features);
            if( isset($this->derivates[$tmp][$e]) ) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                return $this->derivates[$tmp][$e];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
            return $this->$e;
        }
        return NULL;
    }

    /**
     * Isset Magic Function
     * @param mixed $e Element to check
     * @return boolean
     */
    final public function __isset($e) {
        return isset($this->$e) ? true : false;
    }
}


1			<?php
2			namespace App\OS;
3
4			class AbstractOS {
5			/**
6			* Constructor
7			*/
8			final public function __construct(\App\Device $device) {
9			$this->device = $device;
			0 ignored issues – show Bug introduced 2016-03-05 12:46 UTC by Report Bug Copy Issue Report The property `device` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
10			}
11
12			/**
13			* Get Magic Function
14			* @param mixed $e Element to return
15			* @return mixed
16			*/
17			final public function __get($e) {
18			if( isset($this->$e) ) {
19			list($tmp) = explode(" ",$this->device->features);
20			if( isset($this->derivates[$tmp][$e]) ) {
			0 ignored issues – show Documentation introduced 2016-03-05 12:46 UTC by Report Bug Copy Issue Report The property `derivates` does not exist on `object<App\OS\AbstractOS>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
21			return $this->derivates[$tmp][$e];
			0 ignored issues – show Documentation introduced 2016-03-05 12:46 UTC by Report Bug Copy Issue Report The property `derivates` does not exist on `object<App\OS\AbstractOS>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
22			}
23			return $this->$e;
24			}
25			return NULL;
26			}
27
28			/**
29			* Isset Magic Function
30			* @param mixed $e Element to check
31			* @return boolean
32			*/
33			final public function __isset($e) {
34			return isset($this->$e) ? true : false;
35			}
36			}
37

librenms / librenmsv2

Pull Request — develop (#44)

AbstractOS A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like