App\Api\Controllers\DeviceController

Complexity

Total Complexity

13

Size/Duplication

Total Lines	100
Duplicated Lines	25 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	2
Bugs	1	Features	1

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	index()	15	15	4
A	create()	0	4	1
A	store()	0	4	1
A	show()	10	10	3
A	edit()	0	4	1
A	update()	0	4	1
A	destroy()	0	4	1

<?php

namespace App\Api\Controllers;

use App\User;
use App\Device;
use App\Port;
use Illuminate\Http\Request;

class DeviceController extends Controller
{
    public function __construct() {

    }

    /**
     * Display a listing of all authorized devices
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)

This method seems to be duplicated in your project.

    {
        // fetch devices from the database
        if ($request->user()->level >= 10 || $request->user()->level == 5) {
            $devices = Device::all();
        }
        else {
            $devices = User::find($request->user()->user_id)->devices()->get();
        }
        // morph the data as required
        if ($request->query('displayFormat') == 'human') {

This if statement is empty and can be removed.

        }

       return $devices;
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        //
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)

The parameter $request is not used and could be removed.

    {
        //
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show(Request $request, $id)

This method seems to be duplicated in your project.

    {
        if ($request->user()->level >= 10 || $request->user()->level == 5) {
            return Device::find($id);
        }
        else {
            $user = User::find($request->user()->user_id);
            return $user->devices()->find($id);
        }
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)

The parameter $request is not used and could be removed.

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)

The parameter $id is not used and could be removed.

    {
        //
    }

}