UserController::preferences() - Code Metrics - Inspection of "Merge pull request #124 from murrant/user-manageme..." - librenms/librenmsv2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 1eb861...f7494f )

by Neil

created 2016-05-12 16:19 UTC

UserController::preferences() A

↳ Parent: UserController

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	9
rs	9.6666
ccs	0
cts	0
cp	0
cc	1
eloc	5
nc	1
nop	0
crap	2

<?php

namespace App\Http\Controllers;

use App\DataTables\General\UserDataTable;
use App\Http\Requests\CreateUserRequest;
use App\Http\Requests\DeleteUserRequest;
use App\Http\Requests\UpdateUserRequest;
use App\Models\User;
use Auth;
use Dingo\Api\Http;
use Dingo\Api\Routing\Helpers;
use Illuminate\Http\Request;

class UserController extends Controller
{
    use Helpers;

    /**
     * Constructor
     */
    public function __construct(Request $request)
    {
        $this->middleware('auth');
    }

    /**
     * Display a listing of the resource.
     *
     * @param UserDataTable $dataTable
     * @return \Illuminate\Http\Response

     */
    public function index(UserDataTable $dataTable)
    {
        if (Auth::user()->isAdmin()) {
            return $dataTable->render('users.manage');
        }
        return redirect('preferences');
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response

     */
    public function create()
    {
        return view('users.create');
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param CreateUserRequest $request
     * @return \Illuminate\Http\Response

     */
    public function store(CreateUserRequest $request)
    {
        $user = User::create($request->all());

        return response()->json(['message' => trans('user.text.created', ['username' => $user->username])]);
    }

    /**
     * Display the specified resource.
     *
     * @param  int $user_id
     * @return \Illuminate\Http\Response

     */
    public function show($user_id)

    {
        // show read only view of user info here
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int $user_id
     * @return \Illuminate\Http\Response
     */
    public function edit($user_id)
    {
        $user = User::with('devices', 'ports')->findOrFail($user_id);

        if (Auth::user()->isAdmin()) {
            return view('users.edit')->withUser($user);
        }

        return redirect('preferences');
    }

    /**
     * Show the user's preference page
     *
     * @return \Illuminate\Http\Response

     */
    public function preferences()
    {
        $user = Auth::user();

        $device_count = $user->devices()->count();
        $port_count = $user->ports()->count();

        return view('users.preferences', compact('device_count', 'port_count'));
    }

    /**
     * Update the specified resource in storage.
     *
     * @param UpdateUserRequest|Request $request
     * @param $user_id
     * @return \Illuminate\Http\Response
     */
    public function update(UpdateUserRequest $request, $user_id)
    {
        $user = User::find($user_id);
        $user->update($request->all());
        if ($request->input('update') == 'password') {
            $message = trans('user.text.pwdupdated');
        }
        else {
            $message = trans('user.text.updated', ['username' => $user->username]);
        }

        return redirect()->back()->with(['type' => 'success', 'message' => $message]);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int $user_id
     * @return \Illuminate\Http\Response

     */
    public function destroy(DeleteUserRequest $request, $user_id)
    {
        $user = User::find($user_id);
        $user->delete();

        return response()->json(['message' => trans('user.text.deleted', ['username' => $user->username])]);
    }
}


1		<?php
2
3		namespace App\Http\Controllers;
4
5		use App\DataTables\General\UserDataTable;
6		use App\Http\Requests\CreateUserRequest;
7		use App\Http\Requests\DeleteUserRequest;
8		use App\Http\Requests\UpdateUserRequest;
9		use App\Models\User;
10		use Auth;
11		use Dingo\Api\Http;
12		use Dingo\Api\Routing\Helpers;
13		use Illuminate\Http\Request;
14
15	4	class UserController extends Controller
16	4	{
17	4	use Helpers;
18
19	4	/**
20		* Constructor
21	4	*/
22	4	public function __construct(Request $request)
23	4	{
24	4	$this->middleware('auth');
25	2	}
26	2
27	2	/**
28		* Display a listing of the resource.
29	2	*
30	2	* @param UserDataTable $dataTable
31		* @return \Illuminate\Http\Response
		0 ignored issues – show Documentation introduced 2016-05-12 00:17 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\Http\JsonRes...e\Http\RedirectResponse`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
32		*/
33	4	public function index(UserDataTable $dataTable)
34	4	{
35		if (Auth::user()->isAdmin()) {
36		return $dataTable->render('users.manage');
37		}
38		return redirect('preferences');
39		}
40
41		/**
42		* Show the form for creating a new resource.
43		*
44		* @return \Illuminate\Http\Response
		0 ignored issues – show Documentation introduced 2016-05-12 00:17 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\View\View\|\I...\Contracts\View\Factory`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
45		*/
46		public function create()
47		{
48		return view('users.create');
49		}
50
51	4	/**
52		* Store a newly created resource in storage.
53		*
54		* @param CreateUserRequest $request
55		* @return \Illuminate\Http\Response
		0 ignored issues – show Documentation introduced 2016-05-12 00:17 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\Http\JsonResponse`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
56		*/
57		public function store(CreateUserRequest $request)
58		{
59		$user = User::create($request->all());
60
61		return response()->json(['message' => trans('user.text.created', ['username' => $user->username])]);
62		}
63
64		/**
65		* Display the specified resource.
66		*
67		* @param int $user_id
68		* @return \Illuminate\Http\Response
		0 ignored issues – show Documentation introduced 2016-05-12 00:17 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\Http\Response\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
69		*/
70		public function show($user_id)
		0 ignored issues – show Unused Code introduced 2016-05-12 00:17 UTC by Report Bug Copy Issue Report The parameter `$user_id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
71		{
72		// show read only view of user info here
73		}
74
75		/**
76		* Show the form for editing the specified resource.
77		*
78		* @param int $user_id
79		* @return \Illuminate\Http\Response
80		*/
81		public function edit($user_id)
82		{
83		$user = User::with('devices', 'ports')->findOrFail($user_id);
84
85		if (Auth::user()->isAdmin()) {
86		return view('users.edit')->withUser($user);
87		}
88
89		return redirect('preferences');
90		}
91
92		/**
93		* Show the user's preference page
94		*
95		* @return \Illuminate\Http\Response
		0 ignored issues – show Documentation introduced 2016-05-12 00:17 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\View\View\|\I...\Contracts\View\Factory`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
96		*/
97		public function preferences()
98		{
99		$user = Auth::user();
100
101		$device_count = $user->devices()->count();
102		$port_count = $user->ports()->count();
103
104		return view('users.preferences', compact('device_count', 'port_count'));
105		}
106
107		/**
108		* Update the specified resource in storage.
109		*
110		* @param UpdateUserRequest\|Request $request
111		* @param $user_id
112		* @return \Illuminate\Http\Response
113		*/
114		public function update(UpdateUserRequest $request, $user_id)
115		{
116		$user = User::find($user_id);
117		$user->update($request->all());
118		if ($request->input('update') == 'password') {
119		$message = trans('user.text.pwdupdated');
120		}
121		else {
122		$message = trans('user.text.updated', ['username' => $user->username]);
123		}
124
125		return redirect()->back()->with(['type' => 'success', 'message' => $message]);
126		}
127
128		/**
129		* Remove the specified resource from storage.
130		*
131		* @param int $user_id
132		* @return \Illuminate\Http\Response
		0 ignored issues – show Documentation introduced 2016-05-12 00:17 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\Http\JsonResponse`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
133		*/
134		public function destroy(DeleteUserRequest $request, $user_id)
135		{
136		$user = User::find($user_id);
137		$user->delete();
138
139		return response()->json(['message' => trans('user.text.deleted', ['username' => $user->username])]);
140		}
141		}
142

librenms / librenmsv2

Push — develop ( 1eb861...f7494f )

UserController::preferences() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like