UserDeviceController::store() - Code Metrics - librenms/librenmsv2 - Measure and Improve Code Quality continuously with Scrutinizer

UserDeviceController::store() A
last analyzed 2017-06-15 16:09 UTC

↳ Parent: UserDeviceController

Complexity

Conditions	4
Paths	3

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.2
c	0
b	0
f	0
cc	4
eloc	9
nc	3
nop	2

<?php
/**
 * UserDeviceController.php
 *
 * Controls the user device relationship
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 * @package    LibreNMS
 * @link       http://librenms.org
 * @copyright  2016 Tony Murray
 * @author     Tony Murray <[email protected]>
 */

namespace App\Http\Controllers;

use App\Http\Requests\AdminOnlyRequest;
use App\Models\Device;
use App\Models\User;

class UserDeviceController extends Controller
{
    public function create(AdminOnlyRequest $request, $user_id)
    {
        $user = User::with('devices')->find($user_id);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return view('users.devices-create')->withUser($user);
    }

    /**
     * @param AdminOnlyRequest $request
     * @param $user_id
     * @return mixed
     */
    public function store(AdminOnlyRequest $request, $user_id)
    {
        $user = User::find($user_id);

        $device_ids = $request->input('devices');

        if (!is_array($device_ids) || count($device_ids) == 0) {
            return redirect()->back();
        }

        foreach ($device_ids as $device_id) {
            $device = Device::find($device_id);
            $user->devices()->attach($device);
        }
        return redirect()->back()->with(['type' => 'success', 'message' => trans('user.text.devicesadded')]);
    }

    /**
     * @param AdminOnlyRequest $request
     * @param $user_id
     * @param $device_id
     * @return mixed
     */
    public function destroy(AdminOnlyRequest $request, $user_id, $device_id)
    {
        $user = User::find($user_id);
        $device = Device::find($device_id);
        $user->devices()->detach($device);
        return redirect()->back()->with(['type' => 'success', 'message' => trans('user.text.deviceremoved', ['hostname' => $device->hostname])]);
    }
}


1			<?php
2			/**
3			* UserDeviceController.php
4			*
5			* Controls the user device relationship
6			*
7			* This program is free software: you can redistribute it and/or modify
8			* it under the terms of the GNU General Public License as published by
9			* the Free Software Foundation, either version 3 of the License, or
10			* (at your option) any later version.
11			*
12			* This program is distributed in the hope that it will be useful,
13			* but WITHOUT ANY WARRANTY; without even the implied warranty of
14			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
15			* GNU General Public License for more details.
16			*
17			* You should have received a copy of the GNU General Public License
18			* along with this program. If not, see <http://www.gnu.org/licenses/>.
19			*
20			* @package LibreNMS
21			* @link http://librenms.org
22			* @copyright 2016 Tony Murray
23			* @author Tony Murray <[email protected]>
24			*/
25
26			namespace App\Http\Controllers;
27
28			use App\Http\Requests\AdminOnlyRequest;
29			use App\Models\Device;
30			use App\Models\User;
31
32			class UserDeviceController extends Controller
33			{
34			public function create(AdminOnlyRequest $request, $user_id)
35			{
36			$user = User::with('devices')->find($user_id);
			0 ignored issues – show Bug introduced 2016-08-06 05:46 UTC by Report Bug Copy Issue Report The method `find` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
37
38			return view('users.devices-create')->withUser($user);
39			}
40
41			/**
42			* @param AdminOnlyRequest $request
43			* @param $user_id
44			* @return mixed
45			*/
46			public function store(AdminOnlyRequest $request, $user_id)
47			{
48			$user = User::find($user_id);
49
50			$device_ids = $request->input('devices');
51
52			if (!is_array($device_ids) \|\| count($device_ids) == 0) {
53			return redirect()->back();
54			}
55
56			foreach ($device_ids as $device_id) {
57			$device = Device::find($device_id);
58			$user->devices()->attach($device);
59			}
60			return redirect()->back()->with(['type' => 'success', 'message' => trans('user.text.devicesadded')]);
61			}
62
63			/**
64			* @param AdminOnlyRequest $request
65			* @param $user_id
66			* @param $device_id
67			* @return mixed
68			*/
69			public function destroy(AdminOnlyRequest $request, $user_id, $device_id)
70			{
71			$user = User::find($user_id);
72			$device = Device::find($device_id);
73			$user->devices()->detach($device);
74			return redirect()->back()->with(['type' => 'success', 'message' => trans('user.text.deviceremoved', ['hostname' => $device->hostname])]);
75			}
76			}
77

librenms / librenmsv2

UserDeviceController::store() A last analyzed 2017-06-15 16:09 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

UserDeviceController::store() A
last analyzed 2017-06-15 16:09 UTC