UserPortController   A
last analyzed

Complexity

Total Complexity 6

Size/Duplication

Total Lines 50
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 5

Importance

Changes 0
Metric Value
dl 0
loc 50
rs 10
c 0
b 0
f 0
wmc 6
lcom 0
cbo 5

3 Methods

Rating   Name   Duplication   Size   Complexity  
A create() 0 5 1
A store() 0 16 4
A destroy() 0 7 1
1
<?php
2
/**
3
 * UserPortController.php
4
 *
5
 * Controls the user port relationship
6
 *
7
 * This program is free software: you can redistribute it and/or modify
8
 * it under the terms of the GNU General Public License as published by
9
 * the Free Software Foundation, either version 3 of the License, or
10
 * (at your option) any later version.
11
 *
12
 * This program is distributed in the hope that it will be useful,
13
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
15
 * GNU General Public License for more details.
16
 *
17
 * You should have received a copy of the GNU General Public License
18
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
19
 *
20
 * @package    LibreNMS
21
 * @link       http://librenms.org
22
 * @copyright  2016 Tony Murray
23
 * @author     Tony Murray <[email protected]>
24
 */
25
26
namespace App\Http\Controllers;
27
28
use App\Http\Requests\AdminOnlyRequest;
29
use App\Models\Port;
30
use App\Models\User;
31
32
class UserPortController extends Controller
33
{
34
    /**
35
     * @param AdminOnlyRequest $request
36
     * @param $user_id
37
     * @return mixed
38
     */
39
    public function create(AdminOnlyRequest $request, $user_id)
40
    {
41
        $user = User::with('ports')->find($user_id);
0 ignored issues
show
Bug introduced by
The method find does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloquent\Model.

It seems like the method you are trying to call exists only in some of the possible types.

Let’s take a look at an example:

class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

Available Fixes

  1. Add an additional type-check:

    /**
     * @param A|B $x
     */
    function someFunction($x)
    {
        $x->foo();
    
        if ($x instanceof B) {
            $x->bar();
        }
    }
    
  2. Only allow a single type to be passed if the variable comes from a parameter:

    function someFunction(B $x) { /** ... */ }
    
Loading history...
42
        return view('users.ports-create')->withUser($user);
43
    }
44
45
    /**
46
     * @param AdminOnlyRequest $request
47
     * @param $user_id
48
     * @param $port_id
49
     * @return mixed
50
     */
51
    public function store(AdminOnlyRequest $request, $user_id)
52
    {
53
        $user = User::find($user_id);
54
55
        $port_ids = $request->input('ports');
56
57
        if (!is_array($port_ids) || count($port_ids) == 0) {
58
            return redirect()->back();
59
        }
60
61
        foreach ($port_ids as $port_id) {
62
            $port = Port::find($port_id);
63
            $user->ports()->attach($port);
64
        }
65
        return redirect()->back()->with(['type' => 'success', 'message' => trans('user.text.portsadded')]);
66
    }
67
68
    /**
69
     * @param AdminOnlyRequest $request
70
     * @param $user_id
71
     * @param $port_id
72
     * @return mixed
73
     */
74
    public function destroy(AdminOnlyRequest $request, $user_id, $port_id)
75
    {
76
        $user = User::find($user_id);
77
        $port = Port::find($port_id);
78
        $user->ports()->detach($port);
79
        return redirect()->back()->with(['type' => 'success', 'message' => trans('user.text.portremoved', ['label' => $port->getLabel()])]);
80
    }
81
}
82