Issues (2963)

includes/snmptrap.inc.php (1 issue)

1
<?php
2
3
use LibreNMS\Config;
0 ignored issues
show
This use statement conflicts with another class in this namespace, Config. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
4
5
function process_trap($device, $entry)
6
{
7
    $oid = trim(strstr($entry[3], ' '));
8
    $oid = str_replace('::', '', strstr($oid, '::'));
9
10
    $file = Config::get('install_dir') . '/includes/snmptrap/' . $oid . '.inc.php';
11
    if (is_file($file)) {
12
        include $file;
13
    } else {
14
        echo "unknown trap ($file)";
15
    }
16
}
17