View GitHub Repository librenms

Schedule Inspection
Subscribe

Issues (2963)

includes/polling/os/samsungprinter.inc.php (1 issue)

← previous file next file →
1 
<?php
2 

            


            
                                                        
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
// private::enterprises.236.11.5.11.53.31.1.4.0 = STRING: "CLX-3170 Series"

            


            
                                                        
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                
$hardware = trim(snmp_get($device, '1.3.6.1.4.1.236.11.5.11.53.31.1.4.0', '-OQv', '', ''), '" ');

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                        

                                        
It seems like snmp_get($device, '1.3.6...1.4.0', '-OQv', '', '') can also be of type false; however, parameter $string of trim() does only seem to accept string, maybe add an additional type check?
                                                                                                                                                                                           (
                                     Ignorable by Annotation
                                )
                                

                                    
 If this is a false-positive, you can also ignore this issue in your code via the ignore-type   annotation

                                    

                                        

                                            4
                                            
                                                
$hardware = trim(/** @scrutinizer ignore-type */ snmp_get($device, '1.3.6.1.4.1.236.11.5.11.53.31.1.4.0', '-OQv', '', ''), '" ');

                                        

                                                                            

                                

                                                                                                                                                                                                                                                                                        

                    
                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
// mgnt::mib-2.1.1 = STRING: "Samsung CLX-3170 Series;V1.00.01.64 Sep-27-2010;Engine 1.77.81;NIC V4.01.20(CLX-3170) 02-05-2010;S/N JFJIUTM748HJGK983"

            


            
                                                        
            
                                    
            
            

                
                    6