Issues in squid.inc.php (master) - Issues in master - librenms/librenms - Measure and Improve Code Quality continuously with Scrutinizer

Issues (2963)

includes/polling/applications/squid.inc.php (1 issue)

Labels

Bug 1

Severity

Minor 1

SourceDoctor 1

<?php

use LibreNMS\RRD\RrdDefinition;

$name = 'squid';

$app_id = $app['app_id'];

$oids = [

    '.1.3.6.1.4.1.3495.1.2.5.1.0',

    '.1.3.6.1.4.1.3495.1.2.5.2.0',

    '.1.3.6.1.4.1.3495.1.2.5.3.0',

    '.1.3.6.1.4.1.3495.1.2.5.4.0',

    '.1.3.6.1.4.1.3495.1.3.1.1.0',

    '.1.3.6.1.4.1.3495.1.3.1.2.0',

    '.1.3.6.1.4.1.3495.1.3.1.3.0',

    '.1.3.6.1.4.1.3495.1.3.1.4.0',

    '.1.3.6.1.4.1.3495.1.3.1.5.0',

    '.1.3.6.1.4.1.3495.1.3.1.6.0',

    '.1.3.6.1.4.1.3495.1.3.1.7.0',

    '.1.3.6.1.4.1.3495.1.3.1.8.0',

    '.1.3.6.1.4.1.3495.1.3.1.9.0',

    '.1.3.6.1.4.1.3495.1.3.1.10.0',

    '.1.3.6.1.4.1.3495.1.3.1.11.0',

    '.1.3.6.1.4.1.3495.1.3.1.12.0',

    '.1.3.6.1.4.1.3495.1.3.1.13.0',

    '.1.3.6.1.4.1.3495.1.3.2.1.1.0',

    '.1.3.6.1.4.1.3495.1.3.2.1.2.0',

    '.1.3.6.1.4.1.3495.1.3.2.1.3.0',

    '.1.3.6.1.4.1.3495.1.3.2.1.4.0',

    '.1.3.6.1.4.1.3495.1.3.2.1.5.0',

    '.1.3.6.1.4.1.3495.1.3.2.1.6.0',

    '.1.3.6.1.4.1.3495.1.3.2.1.7.0',

    '.1.3.6.1.4.1.3495.1.3.2.1.8.0',

    '.1.3.6.1.4.1.3495.1.3.2.1.9.0',

    '.1.3.6.1.4.1.3495.1.3.2.1.10.0',

    '.1.3.6.1.4.1.3495.1.3.2.1.11.0',

    '.1.3.6.1.4.1.3495.1.3.2.1.12.0',

    '.1.3.6.1.4.1.3495.1.3.2.1.13.0',

    '.1.3.6.1.4.1.3495.1.3.2.1.14.0',

    '.1.3.6.1.4.1.3495.1.3.2.1.15.0',

    '.1.3.6.1.4.1.3495.1.3.2.2.1.9.1',

    '.1.3.6.1.4.1.3495.1.3.2.2.1.9.5',

    '.1.3.6.1.4.1.3495.1.3.2.2.1.9.60',

    '.1.3.6.1.4.1.3495.1.3.2.2.1.10.1',

    '.1.3.6.1.4.1.3495.1.3.2.2.1.10.5',

    '.1.3.6.1.4.1.3495.1.3.2.2.1.10.60',

];

$returnedoids = snmp_get_multi_oid($device, $oids);

$memmaxsize = $returnedoids['.1.3.6.1.4.1.3495.1.2.5.1.0'];

$swapmaxsize = $returnedoids['.1.3.6.1.4.1.3495.1.2.5.2.0'];

$swaphighwm = $returnedoids['.1.3.6.1.4.1.3495.1.2.5.3.0'];

$swaplowwm = $returnedoids['.1.3.6.1.4.1.3495.1.2.5.4.0'];

$syspagefaults = $returnedoids['.1.3.6.1.4.1.3495.1.3.1.1.0'];

$sysnumreads = $returnedoids['.1.3.6.1.4.1.3495.1.3.1.2.0'];

$memusage = $returnedoids['.1.3.6.1.4.1.3495.1.3.1.3.0'];

$cputime = $returnedoids['.1.3.6.1.4.1.3495.1.3.1.4.0'];

$cpuusage = $returnedoids['.1.3.6.1.4.1.3495.1.3.1.5.0'];

$maxressize = $returnedoids['.1.3.6.1.4.1.3495.1.3.1.6.0'];

$numobjcount = $returnedoids['.1.3.6.1.4.1.3495.1.3.1.7.0'];

$currentlruexpiration = $returnedoids['.1.3.6.1.4.1.3495.1.3.1.8.0'];

$currentunlinkrequests = $returnedoids['.1.3.6.1.4.1.3495.1.3.1.9.0'];

$currentunusedfdescrcnt = $returnedoids['.1.3.6.1.4.1.3495.1.3.1.10.0'];

$currentresfiledescrcnt = $returnedoids['.1.3.6.1.4.1.3495.1.3.1.11.0'];

$currentfiledescrcnt = $returnedoids['.1.3.6.1.4.1.3495.1.3.1.12.0'];

$currentfiledescrmax = $returnedoids['.1.3.6.1.4.1.3495.1.3.1.13.0'];

$protoclienthttprequests = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.1.1.0'];

$httphits = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.1.2.0'];

$httperrors = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.1.3.0'];

$httpinkb = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.1.4.0'];

$httpoutkb = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.1.5.0'];

$icppktssent = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.1.6.0'];

$icppktsrecv = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.1.7.0'];

$icpkbsent = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.1.8.0'];

$icpkbrecv = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.1.9.0'];

$serverrequests = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.1.10.0'];

$servererrors = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.1.11.0'];

$serverinkb = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.1.12.0'];

$serveroutkb = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.1.13.0'];

$currentswapsize = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.1.14.0'];

$clients = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.1.15.0'];

$requesthitratio1 = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.2.1.9.1'];

$requesthitratio5 = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.2.1.9.5'];

$requesthitratio60 = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.2.1.9.60'];

$requestbyteratio1 = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.2.1.10.1'];

$requestbyteratio5 = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.2.1.10.5'];

$requestbyteratio60 = $returnedoids['.1.3.6.1.4.1.3495.1.3.2.2.1.10.60'];

$rrd_name = ['app', $name, $app_id];

$rrd_def = RrdDefinition::make()

    ->addDataset('memmaxsize', 'GAUGE', 0)

    ->addDataset('swapmaxsize', 'GAUGE', 0)

    ->addDataset('swaphighwm', 'GAUGE', 0)

    ->addDataset('swaplowwm', 'GAUGE', 0)

    ->addDataset('syspagefaults', 'COUNTER', 0)

    ->addDataset('sysnumreads', 'COUNTER', 0)

    ->addDataset('memusage', 'GAUGE', 0)

    ->addDataset('cputime', 'GAUGE', 0)

100

    ->addDataset('cpuusage', 'GAUGE', 0)

101

    ->addDataset('maxressize', 'GAUGE', 0)

102

    ->addDataset('numobjcount', 'GAUGE', 0)

103

    ->addDataset('curunlinkreq', 'GAUGE', 0)

104

    ->addDataset('curunusedfdescrcnt', 'GAUGE', 0)

105

    ->addDataset('curresfiledescrcnt', 'GAUGE', 0)

106

    ->addDataset('curfiledescrcnt', 'GAUGE', 0)

107

    ->addDataset('curfiledescrmax', 'GAUGE', 0)

108

    ->addDataset('protoclienthttpreq', 'COUNTER', 0)

109

    ->addDataset('httphits', 'COUNTER', 0)

110

    ->addDataset('httperrors', 'COUNTER', 0)

111

    ->addDataset('httpinkb', 'COUNTER', 0)

112

    ->addDataset('httpoutkb', 'COUNTER', 0)

113

    ->addDataset('icppktssent', 'COUNTER', 0)

114

    ->addDataset('icppktsrecv', 'COUNTER', 0)

115

    ->addDataset('icpkbsent', 'COUNTER', 0)

116

    ->addDataset('icpkbrecv', 'COUNTER', 0)

117

    ->addDataset('serverrequests', 'COUNTER', 0)

118

    ->addDataset('servererrors', 'COUNTER', 0)

119

    ->addDataset('serverinkb', 'COUNTER', 0)

120

    ->addDataset('serveroutkb', 'COUNTER', 0)

121

    ->addDataset('currentswapsize', 'GAUGE', 0)

122

    ->addDataset('clients', 'GAUGE', 0)

123

    ->addDataset('reqhitratio1', 'GAUGE', 0)

124

    ->addDataset('reqhitratio5', 'GAUGE', 0)

125

    ->addDataset('reqhitratio60', 'GAUGE', 0)

126

    ->addDataset('reqbyteratio1', 'GAUGE', 0)

127

    ->addDataset('reqbyteratio5', 'GAUGE', 0)

128

    ->addDataset('reqbyteratio60', 'GAUGE', 0);

129

130

$memmaxsize = $memmaxsize * 1000;

131

$swapmaxsize = $swapmaxsize * 1000;

132

$swaphighwm = $swaphighwm * 1000;

133

$swaplowwm = $swaplowwm * 1000;

134

135

$fields = [

136

    'memmaxsize' => $memmaxsize,

137

    'swapmaxsize' => $swapmaxsize,

138

    'swaphighwm' => $swaphighwm,

139

    'swaplowwm' => $swaplowwm,

140

    'syspagefaults' => $syspagefaults,

141

    'sysnumreads' => $sysnumreads,

142

    'memusage' => $memusage,

143

    'cputime' => $cputime,

144

    'cpuusage' => $cpuusage,

145

    'maxressize' => $maxressize,

146

    'numobjcount' => $numobjcount,

147

    'curunlinkreq' => $currentunlinkrequests,

148

    'curunusedfdescrcnt' => $currentunusedfdescrcnt,

149

    'curresfiledescrcnt' => $currentresfiledescrcnt,

150

    'curfiledescrcnt' => $currentfiledescrcnt,

151

    'curfiledescrmax' => $currentfiledescrmax,

152

    'protoclienthttpreq' => $protoclienthttprequests,

153

    'httphits' => $httphits,

154

    'httperrors' => $httperrors,

155

    'httpinkb' => $httpinkb,

156

    'httpoutkb' => $httpoutkb,

157

    'icppktssent' => $icppktssent,

158

    'icppktsrecv' => $icppktsrecv,

159

    'icpkbsent' => $icpkbsent,

160

    'icpkbrecv' => $icpkbrecv,

161

    'serverrequests' => $serverrequests,

162

    'servererrors' => $servererrors,

163

    'serverinkb' => $serverinkb,

164

    'serveroutkb' => $serveroutkb,

165

    'currentswapsize' => $currentswapsize,

166

    'clients' => $clients,

167

    'reqhitratio1' => $requesthitratio1,

168

    'reqhitratio5' => $requesthitratio5,

169

    'reqhitratio60' => $requesthitratio60,

170

    'reqbyteratio1' => $requestbyteratio1,

171

    'reqbyteratio5' => $requestbyteratio5,

172

    'reqbyteratio60' => $requestbyteratio60,

173

];

174

175

$tags = ['name' => $name, 'app_id' => $app_id, 'rrd_def' => $rrd_def, 'rrd_name' => $rrd_name];

176

data_update($device, 'app', $tags, $fields);

177

178

$squid_app_status = ($returnedoids == false) ? false : 'Data ok';

179

update_application($app, $squid_app_status, $fields);

Bug introduced 2020-06-14 10:07 UTC by

It seems like $squid_app_status can also be of type false; however, parameter $response of update_application() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

180

librenms / librenms

Issues (2963)

includes/polling/applications/squid.inc.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like