librenms / librenms

includes/discovery/sensors/voltage/eltex-mes.inc.php

<?php
/*
 * LibreNMS discovery module for Eltex-MES SFP Voltage
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 *
 * @package    LibreNMS
 * @link       https://www.librenms.org
 *
 * @author     Peca Nesovanovic <peca.nesovanovic@sattrakt.com>
 */

$low_limit = $low_warn_limit = 3;
$high_warn_limit = $high_limit = 4;
$divisor = 1000000;

$oids = snmp_walk($device, '1.3.6.1.4.1.89.90.1.2.1.3', '-Osqn', '');
$oids = trim($oids);

if ($oids) {
    echo "Eltex-MES Voltage:\n";

    foreach (explode("\n", $oids) as $data) {
        if ($data) {
            print_r($data);
            echo "\n";
            $split = trim(explode(' ', $data)[0]);
            $value = trim(explode(' ', $data)[1]);
            $ifIndex = explode('.', $split)[13];
            $type = explode('.', $split)[14];

            // type6 = voltage
            if ($type == 6) {
                $descr_oid = '1.0.8802.1.1.2.1.3.7.1.3.' . $ifIndex;
                $descr = trim(snmp_get($device, $descr_oid, '-Oqv', ''), '"');

It seems like snmp_get($device, $descr_oid, '-Oqv', '') can also be of type false; however, parameter $string of trim() does only seem to accept string, maybe add an additional type check?

                $value = $value / $divisor;
                discover_sensor($valid['sensor'], 'voltage', $device, $split, 'SfpVolt' . $ifIndex, 'eltex-mes', 'SfpVolt-' . $descr, $divisor, '1', $low_limit, $low_warn_limit, $high_warn_limit, $high_limit, $value);
            }
        }
    }
}