librenms / librenms

html/data.php

<?php

/**
 * LibreNMS
 *
 *   This file is part of LibreNMS.
 *
 * @copyright  (C) 2006 - 2012 Adam Armstrong
 */
$init_modules = ['web', 'auth'];
require realpath(__DIR__ . '/..') . '/includes/init.php';

if (is_numeric($_GET['id']) && (\LibreNMS\Config::get('allow_unauth_graphs') || port_permitted($_GET['id']))) {
    $port = cleanPort(get_port_by_id($_GET['id']));

It seems like get_port_by_id($_GET['id']) can also be of type false; however, parameter $interface of cleanPort() does only seem to accept array, maybe add an additional type check?

    $device = device_by_id_cache($port['device_id']);
    $title = generate_device_link($device);
    $title .= ' :: Port  ' . generate_port_link($port);

Are you sure generate_port_link($port) of type array|string can be used in concatenation?

    $auth = true;

    $in = snmp_get($device, 'ifHCInOctets.' . $port['ifIndex'], '-OUqnv', 'IF-MIB');
    if (empty($in)) {
        $in = snmp_get($device, 'ifInOctets.' . $port['ifIndex'], '-OUqnv', 'IF-MIB');
    }

    $out = snmp_get($device, 'ifHCOutOctets.' . $port['ifIndex'], '-OUqnv', 'IF-MIB');
    if (empty($out)) {
        $out = snmp_get($device, 'ifOutOctets.' . $port['ifIndex'], '-OUqnv', 'IF-MIB');
    }

    $time = microtime(true);

    printf("%lf|%s|%s\n", $time, $in, $out);

It seems like $in can also be of type false; however, parameter $values of printf() does only seem to accept double|integer|string, maybe add an additional type check?

}