librenms / librenms

app/Console/Commands/SchemaDumpCommand.php

<?php

namespace App\Console\Commands;

use Illuminate\Contracts\Events\Dispatcher;
use Illuminate\Database\ConnectionResolverInterface;
use Illuminate\Database\Console\DumpCommand;
use LibreNMS\DB\Schema;
use Symfony\Component\Console\Output\StreamOutput;
use Symfony\Component\Yaml\Yaml;

class SchemaDumpCommand extends DumpCommand
{
    /**
     * Create a new command instance.
     *
     * @return void
     */
    public function __construct()
    {
        $this->signature .= '{--snapshots : Dump snapshots to reduce initial migration time}';
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return int
     */
    public function handle(ConnectionResolverInterface $connections, Dispatcher $dispatcher)
    {
        $database = $this->option('database');

        if ($this->option('snapshots')) {
            $databases = $database ? [$database] : ['mysql', 'testing', 'testing_persistent'];
            foreach ($databases as $database) {
                $this->line("Database: $database");
                $this->input->setOption('database', $database);
                parent::handle($connections, $dispatcher);
            }

            // in memory db doesn't dump right, copy the sqlite on-disk dump
            $persistent_dump_file = base_path('/database/schema/testing_persistent-schema.dump');
            if (in_array('testing_persistent', $databases) && file_exists($persistent_dump_file)) {
                copy($persistent_dump_file, base_path('/database/schema/testing_memory-schema.dump'));
            }

            return 0;
        }

        $stdout = new StreamOutput(fopen('php://stdout', 'w'));
        $parameters = ['--force' => true, '--ansi' => true];
        if ($database) {
            $parameters['--database'] = $database;
        }

        \Artisan::call('migrate', $parameters, $stdout);

        $file = $this->option('path') ?: base_path('/misc/db_schema.yaml');
        $yaml = Yaml::dump(Schema::dump($database), 3, 2);

It seems like $database can also be of type string[]; however, parameter $connection of LibreNMS\DB\Schema::dump() does only seem to accept string, maybe add an additional type check?

        if (file_put_contents($file, $yaml)) {
            $this->info(basename($file) . ' updated!');

            return 0;
        }

        $this->error('Failed to write file ' . $file);

Are you sure $file of type string|string[]|true can be used in concatenation?

        return 1;
    }
}