librenms / librenms

app/Console/Commands/GetConfigCommand.php

<?php

namespace App\Console\Commands;

use App\Console\Commands\Traits\CompletesConfigArgument;
use App\Console\LnmsCommand;
use LibreNMS\Config;
use LibreNMS\Util\OS;
use Symfony\Component\Console\Input\InputArgument;

class GetConfigCommand extends LnmsCommand
{
    use CompletesConfigArgument;

    protected $name = 'config:get';

    /**
     * Create a new command instance.
     *
     * @return void
     */
    public function __construct()
    {
        parent::__construct();

        $this->addArgument('setting', InputArgument::OPTIONAL);
        $this->addOption('dump');
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $setting = $this->argument('setting');

        // load os definition if requested, and remove special definition_loaded key
        if (preg_match('/^os\.(?<os>[^.]+)/', $setting, $matches)) {

It seems like $setting can also be of type null and string[]; however, parameter $subject of preg_match() does only seem to accept string, maybe add an additional type check?

            OS::loadDefinition($matches['os']);
            Config::forget("os.{$matches['os']}.definition_loaded");
        }

        if ($this->option('dump')) {
            $this->line($setting ? json_encode(Config::get($setting)) : Config::toJson());

It seems like $setting can also be of type string[]; however, parameter $key of LibreNMS\Config::get() does only seem to accept string, maybe add an additional type check?

            return 0;
        }

        if (! $setting) {
            throw new \RuntimeException('Not enough arguments (missing: "setting").');
        }

        if (Config::has($setting)) {

It seems like $setting can also be of type string[]; however, parameter $key of LibreNMS\Config::has() does only seem to accept string, maybe add an additional type check?

            $output = Config::get($setting);
            if (! is_string($output)) {
                $output = json_encode($output, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES);
            }

            $this->line($output);

            return 0;
        }

        return 1;
    }
}