Issues in AdvaNetworkElementAlmTrapTest.php - All Issues - Inspection of "Update VMWare guest IDs (#10338)" - librenms/librenms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 0baeb0...d4017c )

by Tony

created 2019-06-15 03:27 UTC

SnmpTraps/AdvaNetworkElementAlmTrapTest.php (1 issue)

Labels

Bug 1

Severity

Major 1

h-barnhart 1

<?php
/**
 * AdvaNetworkElementAlmTest.php
 *
 * -Description-
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 *
 * @package    LibreNMS
 * @link       http://librenms.org
 * @copyright  2019 Heath Barnhart
 * @author     Heath Barnhart <[email protected]>
 */

namespace LibreNMS\Tests\Feature\SnmpTraps;

use App\Models\Device;
use Illuminate\Foundation\Testing\DatabaseTransactions;
use LibreNMS\Snmptrap\Dispatcher;
use LibreNMS\Snmptrap\Trap;
use LibreNMS\Tests\LaravelTestCase;

class AdvaNetworkElementAlmTest extends LaravelTestCase
{
    use DatabaseTransactions;


    public function testElementAlarmCleared()
    {
        $device = factory(Device::class)->create();

        $trapText = "$device->hostname
UDP: [$device->ip]:57602->[192.168.5.5]:162
DISMAN-EVENT-MIB::sysUpTimeInstance 26:19:43:37.24
SNMPv2-MIB::snmpTrapOID.0 CM-ALARM-MIB::cmNetworkElementAlmTrap
CM-ALARM-MIB::cmAlmIndex.0 30
CM-ALARM-MIB::cmNetworkElementAlmNotifCode.1.30 cleared
CM-ALARM-MIB::cmNetworkElementAlmType.1.30 lnkdown
CM-ALARM-MIB::cmNetworkElementAlmSrvEff.1.30 serviceAffecting
CM-ALARM-MIB::cmNetworkElementAlmTime.1.30 2018-12-10,11:1:43.0,-6:0
CM-ALARM-MIB::cmNetworkElementAlmLocation.1.30 nearEnd
CM-ALARM-MIB::cmNetworkElementAlmDirection.1.30 receiveDirectionOnly
CM-ALARM-MIB::cmNetworkElementAlmDescr.1.30 \"Test Alarm Cleared\"
CM-ALARM-MIB::cmNetworkElementAlmObject.1.30 CM-FACILITY-MIB::cmEthernetNetPortIndex.1.1.1.2
CM-ALARM-MIB::cmNetworkElementAlmObjectName.1.30 NETWORK PORT-1-1-1-2
CM-ALARM-MIB::cmNetworkElementAlmAdditionalInfoObject.1.30 SNMPv2-SMI::zeroDotZero
CM-ALARM-MIB::cmNetworkElementAlmAdditionalInfoName.1.30 
RMON2-MIB::probeDateTime.0 \"07 E2 0C 0A 0B 01 2B 00 2D 06 00 \"
ADVA-MIB::neEventLogIndex.231 231
ADVA-MIB::neEventLogTimeStamp.231 2018-12-10,11:1:43.3,-6:0";

        $trap = new Trap($trapText);

        $message = "Alarming Element: NETWORK PORT-1-1-1-2 Description: Test Alarm Cleared Severity: cleared";
        \Log::shouldReceive('event')->once()->with($message, $device->device_id, 'trap', 1);

        $this->assertTrue(Dispatcher::handle($trap), 'Could not handle cmNetworkElementAlmTrap cleared');
    }

    public function testElementAlarmMinor()
    {
        $device = factory(Device::class)->create();

        $trapText = "$device->hostname
UDP: [$device->ip]:57602->[192.168.5.5]:162
DISMAN-EVENT-MIB::sysUpTimeInstance 26:19:43:37.24
SNMPv2-MIB::snmpTrapOID.0 CM-ALARM-MIB::cmNetworkElementAlmTrap
CM-ALARM-MIB::cmAlmIndex.0 30
CM-ALARM-MIB::cmNetworkElementAlmNotifCode.1.30 minor
CM-ALARM-MIB::cmNetworkElementAlmType.1.30 lnkdown
CM-ALARM-MIB::cmNetworkElementAlmSrvEff.1.30 serviceAffecting
CM-ALARM-MIB::cmNetworkElementAlmTime.1.30 2018-12-10,11:1:43.0,-6:0
CM-ALARM-MIB::cmNetworkElementAlmLocation.1.30 nearEnd
CM-ALARM-MIB::cmNetworkElementAlmDirection.1.30 receiveDirectionOnly
CM-ALARM-MIB::cmNetworkElementAlmDescr.1.30 \"Test Alarm Minor\"
CM-ALARM-MIB::cmNetworkElementAlmObject.1.30 CM-FACILITY-MIB::cmEthernetNetPortIndex.1.1.1.2
CM-ALARM-MIB::cmNetworkElementAlmObjectName.1.30 NETWORK PORT-1-1-1-2
CM-ALARM-MIB::cmNetworkElementAlmAdditionalInfoObject.1.30 SNMPv2-SMI::zeroDotZero
CM-ALARM-MIB::cmNetworkElementAlmAdditionalInfoName.1.30 
RMON2-MIB::probeDateTime.0 \"07 E2 0C 0A 0B 01 2B 00 2D 06 00 \"
ADVA-MIB::neEventLogIndex.231 231
ADVA-MIB::neEventLogTimeStamp.231 2018-12-10,11:1:43.3,-6:0";

        $trap = new Trap($trapText);

        $message = "Alarming Element: NETWORK PORT-1-1-1-2 Description: Test Alarm Minor Severity: minor";
        \Log::shouldReceive('event')->once()->with($message, $device->device_id, 'trap', 3);

        $this->assertTrue(Dispatcher::handle($trap), 'Could not handle cmNetworkElementAlmTrap minor');
    }

    public function testElementAlarmMajor()
    {
        $device = factory(Device::class)->create();

        $trapText = "$device->hostname
UDP: [$device->ip]:57602->[192.168.5.5]:162
DISMAN-EVENT-MIB::sysUpTimeInstance 26:19:43:37.24
SNMPv2-MIB::snmpTrapOID.0 CM-ALARM-MIB::cmNetworkElementAlmTrap
CM-ALARM-MIB::cmAlmIndex.0 30
CM-ALARM-MIB::cmNetworkElementAlmNotifCode.1.30 major
CM-ALARM-MIB::cmNetworkElementAlmType.1.30 lnkdown
CM-ALARM-MIB::cmNetworkElementAlmSrvEff.1.30 serviceAffecting
CM-ALARM-MIB::cmNetworkElementAlmTime.1.30 2018-12-10,11:1:43.0,-6:0
CM-ALARM-MIB::cmNetworkElementAlmLocation.1.30 nearEnd
CM-ALARM-MIB::cmNetworkElementAlmDirection.1.30 receiveDirectionOnly
CM-ALARM-MIB::cmNetworkElementAlmDescr.1.30 \"Test Alarm Major\"
CM-ALARM-MIB::cmNetworkElementAlmObject.1.30 CM-FACILITY-MIB::cmEthernetNetPortIndex.1.1.1.2
CM-ALARM-MIB::cmNetworkElementAlmObjectName.1.30 NETWORK PORT-1-1-1-2
CM-ALARM-MIB::cmNetworkElementAlmAdditionalInfoObject.1.30 SNMPv2-SMI::zeroDotZero
CM-ALARM-MIB::cmNetworkElementAlmAdditionalInfoName.1.30 
RMON2-MIB::probeDateTime.0 \"07 E2 0C 0A 0B 01 2B 00 2D 06 00 \"
ADVA-MIB::neEventLogIndex.231 231
ADVA-MIB::neEventLogTimeStamp.231 2018-12-10,11:1:43.3,-6:0";

        $trap = new Trap($trapText);

        $message = "Alarming Element: NETWORK PORT-1-1-1-2 Description: Test Alarm Major Severity: major";
        \Log::shouldReceive('event')->once()->with($message, $device->device_id, 'trap', 4);

        $this->assertTrue(Dispatcher::handle($trap), 'Could not handle cmNetworkElementAlmTrap major');
    }

    public function testElementAlarmCritical()
    {
        $device = factory(Device::class)->create();

        $trapText = "$device->hostname
UDP: [$device->ip]:57602->[192.168.5.5]:162
DISMAN-EVENT-MIB::sysUpTimeInstance 26:19:43:37.24
SNMPv2-MIB::snmpTrapOID.0 CM-ALARM-MIB::cmNetworkElementAlmTrap
CM-ALARM-MIB::cmAlmIndex.0 30
CM-ALARM-MIB::cmNetworkElementAlmNotifCode.1.30 critical
CM-ALARM-MIB::cmNetworkElementAlmType.1.30 lnkdown
CM-ALARM-MIB::cmNetworkElementAlmSrvEff.1.30 serviceAffecting
CM-ALARM-MIB::cmNetworkElementAlmTime.1.30 2018-12-10,11:1:43.0,-6:0
CM-ALARM-MIB::cmNetworkElementAlmLocation.1.30 nearEnd
CM-ALARM-MIB::cmNetworkElementAlmDirection.1.30 receiveDirectionOnly
CM-ALARM-MIB::cmNetworkElementAlmDescr.1.30 \"Test Alarm Critical\"
CM-ALARM-MIB::cmNetworkElementAlmObject.1.30 CM-FACILITY-MIB::cmEthernetNetPortIndex.1.1.1.2
CM-ALARM-MIB::cmNetworkElementAlmObjectName.1.30 NETWORK PORT-1-1-1-2
CM-ALARM-MIB::cmNetworkElementAlmAdditionalInfoObject.1.30 SNMPv2-SMI::zeroDotZero
CM-ALARM-MIB::cmNetworkElementAlmAdditionalInfoName.1.30 
RMON2-MIB::probeDateTime.0 \"07 E2 0C 0A 0B 01 2B 00 2D 06 00 \"
ADVA-MIB::neEventLogIndex.231 231
ADVA-MIB::neEventLogTimeStamp.231 2018-12-10,11:1:43.3,-6:0";

        $trap = new Trap($trapText);

        $message = "Alarming Element: NETWORK PORT-1-1-1-2 Description: Test Alarm Critical Severity: critical";
        \Log::shouldReceive('event')->once()->with($message, $device->device_id, 'trap', 5);

        $this->assertTrue(Dispatcher::handle($trap), 'Could not handle cmNetworkElementAlmTrap critical');
    }
}


1			<?php
2			/**
3			* AdvaNetworkElementAlmTest.php
4			*
5			* -Description-
6			*
7			* This program is free software: you can redistribute it and/or modify
8			* it under the terms of the GNU General Public License as published by
9			* the Free Software Foundation, either version 3 of the License, or
10			* (at your option) any later version.
11			*
12			* This program is distributed in the hope that it will be useful,
13			* but WITHOUT ANY WARRANTY; without even the implied warranty of
14			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
15			* GNU General Public License for more details.
16			*
17			* You should have received a copy of the GNU General Public License
18			* along with this program. If not, see <http://www.gnu.org/licenses/>.
19			*
20			* @package LibreNMS
21			* @link http://librenms.org
22			* @copyright 2019 Heath Barnhart
23			* @author Heath Barnhart <[email protected]>
24			*/
25
26			namespace LibreNMS\Tests\Feature\SnmpTraps;
27
28			use App\Models\Device;
29			use Illuminate\Foundation\Testing\DatabaseTransactions;
30			use LibreNMS\Snmptrap\Dispatcher;
31			use LibreNMS\Snmptrap\Trap;
32			use LibreNMS\Tests\LaravelTestCase;
33
34			class AdvaNetworkElementAlmTest extends LaravelTestCase
35			{
36			use DatabaseTransactions;
			0 ignored issues – show Bug introduced 2019-04-11 20:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The trait `Illuminate\Foundation\Testing\DatabaseTransactions` requires the property `$connectionsToTransact` which is not provided by `LibreNMS\Tests\Feature\S...vaNetworkElementAlmTest`. Loading history...
37
38			public function testElementAlarmCleared()
39			{
40			$device = factory(Device::class)->create();
41
42			$trapText = "$device->hostname
43			UDP: [$device->ip]:57602->[192.168.5.5]:162
44			DISMAN-EVENT-MIB::sysUpTimeInstance 26:19:43:37.24
45			SNMPv2-MIB::snmpTrapOID.0 CM-ALARM-MIB::cmNetworkElementAlmTrap
46			CM-ALARM-MIB::cmAlmIndex.0 30
47			CM-ALARM-MIB::cmNetworkElementAlmNotifCode.1.30 cleared
48			CM-ALARM-MIB::cmNetworkElementAlmType.1.30 lnkdown
49			CM-ALARM-MIB::cmNetworkElementAlmSrvEff.1.30 serviceAffecting
50			CM-ALARM-MIB::cmNetworkElementAlmTime.1.30 2018-12-10,11:1:43.0,-6:0
51			CM-ALARM-MIB::cmNetworkElementAlmLocation.1.30 nearEnd
52			CM-ALARM-MIB::cmNetworkElementAlmDirection.1.30 receiveDirectionOnly
53			CM-ALARM-MIB::cmNetworkElementAlmDescr.1.30 \"Test Alarm Cleared\"
54			CM-ALARM-MIB::cmNetworkElementAlmObject.1.30 CM-FACILITY-MIB::cmEthernetNetPortIndex.1.1.1.2
55			CM-ALARM-MIB::cmNetworkElementAlmObjectName.1.30 NETWORK PORT-1-1-1-2
56			CM-ALARM-MIB::cmNetworkElementAlmAdditionalInfoObject.1.30 SNMPv2-SMI::zeroDotZero
57			CM-ALARM-MIB::cmNetworkElementAlmAdditionalInfoName.1.30
58			RMON2-MIB::probeDateTime.0 \"07 E2 0C 0A 0B 01 2B 00 2D 06 00 \"
59			ADVA-MIB::neEventLogIndex.231 231
60			ADVA-MIB::neEventLogTimeStamp.231 2018-12-10,11:1:43.3,-6:0";
61
62			$trap = new Trap($trapText);
63
64			$message = "Alarming Element: NETWORK PORT-1-1-1-2 Description: Test Alarm Cleared Severity: cleared";
65			\Log::shouldReceive('event')->once()->with($message, $device->device_id, 'trap', 1);
66
67			$this->assertTrue(Dispatcher::handle($trap), 'Could not handle cmNetworkElementAlmTrap cleared');
68			}
69
70			public function testElementAlarmMinor()
71			{
72			$device = factory(Device::class)->create();
73
74			$trapText = "$device->hostname
75			UDP: [$device->ip]:57602->[192.168.5.5]:162
76			DISMAN-EVENT-MIB::sysUpTimeInstance 26:19:43:37.24
77			SNMPv2-MIB::snmpTrapOID.0 CM-ALARM-MIB::cmNetworkElementAlmTrap
78			CM-ALARM-MIB::cmAlmIndex.0 30
79			CM-ALARM-MIB::cmNetworkElementAlmNotifCode.1.30 minor
80			CM-ALARM-MIB::cmNetworkElementAlmType.1.30 lnkdown
81			CM-ALARM-MIB::cmNetworkElementAlmSrvEff.1.30 serviceAffecting
82			CM-ALARM-MIB::cmNetworkElementAlmTime.1.30 2018-12-10,11:1:43.0,-6:0
83			CM-ALARM-MIB::cmNetworkElementAlmLocation.1.30 nearEnd
84			CM-ALARM-MIB::cmNetworkElementAlmDirection.1.30 receiveDirectionOnly
85			CM-ALARM-MIB::cmNetworkElementAlmDescr.1.30 \"Test Alarm Minor\"
86			CM-ALARM-MIB::cmNetworkElementAlmObject.1.30 CM-FACILITY-MIB::cmEthernetNetPortIndex.1.1.1.2
87			CM-ALARM-MIB::cmNetworkElementAlmObjectName.1.30 NETWORK PORT-1-1-1-2
88			CM-ALARM-MIB::cmNetworkElementAlmAdditionalInfoObject.1.30 SNMPv2-SMI::zeroDotZero
89			CM-ALARM-MIB::cmNetworkElementAlmAdditionalInfoName.1.30
90			RMON2-MIB::probeDateTime.0 \"07 E2 0C 0A 0B 01 2B 00 2D 06 00 \"
91			ADVA-MIB::neEventLogIndex.231 231
92			ADVA-MIB::neEventLogTimeStamp.231 2018-12-10,11:1:43.3,-6:0";
93
94			$trap = new Trap($trapText);
95
96			$message = "Alarming Element: NETWORK PORT-1-1-1-2 Description: Test Alarm Minor Severity: minor";
97			\Log::shouldReceive('event')->once()->with($message, $device->device_id, 'trap', 3);
98
99			$this->assertTrue(Dispatcher::handle($trap), 'Could not handle cmNetworkElementAlmTrap minor');
100			}
101
102			public function testElementAlarmMajor()
103			{
104			$device = factory(Device::class)->create();
105
106			$trapText = "$device->hostname
107			UDP: [$device->ip]:57602->[192.168.5.5]:162
108			DISMAN-EVENT-MIB::sysUpTimeInstance 26:19:43:37.24
109			SNMPv2-MIB::snmpTrapOID.0 CM-ALARM-MIB::cmNetworkElementAlmTrap
110			CM-ALARM-MIB::cmAlmIndex.0 30
111			CM-ALARM-MIB::cmNetworkElementAlmNotifCode.1.30 major
112			CM-ALARM-MIB::cmNetworkElementAlmType.1.30 lnkdown
113			CM-ALARM-MIB::cmNetworkElementAlmSrvEff.1.30 serviceAffecting
114			CM-ALARM-MIB::cmNetworkElementAlmTime.1.30 2018-12-10,11:1:43.0,-6:0
115			CM-ALARM-MIB::cmNetworkElementAlmLocation.1.30 nearEnd
116			CM-ALARM-MIB::cmNetworkElementAlmDirection.1.30 receiveDirectionOnly
117			CM-ALARM-MIB::cmNetworkElementAlmDescr.1.30 \"Test Alarm Major\"
118			CM-ALARM-MIB::cmNetworkElementAlmObject.1.30 CM-FACILITY-MIB::cmEthernetNetPortIndex.1.1.1.2
119			CM-ALARM-MIB::cmNetworkElementAlmObjectName.1.30 NETWORK PORT-1-1-1-2
120			CM-ALARM-MIB::cmNetworkElementAlmAdditionalInfoObject.1.30 SNMPv2-SMI::zeroDotZero
121			CM-ALARM-MIB::cmNetworkElementAlmAdditionalInfoName.1.30
122			RMON2-MIB::probeDateTime.0 \"07 E2 0C 0A 0B 01 2B 00 2D 06 00 \"
123			ADVA-MIB::neEventLogIndex.231 231
124			ADVA-MIB::neEventLogTimeStamp.231 2018-12-10,11:1:43.3,-6:0";
125
126			$trap = new Trap($trapText);
127
128			$message = "Alarming Element: NETWORK PORT-1-1-1-2 Description: Test Alarm Major Severity: major";
129			\Log::shouldReceive('event')->once()->with($message, $device->device_id, 'trap', 4);
130
131			$this->assertTrue(Dispatcher::handle($trap), 'Could not handle cmNetworkElementAlmTrap major');
132			}
133
134			public function testElementAlarmCritical()
135			{
136			$device = factory(Device::class)->create();
137
138			$trapText = "$device->hostname
139			UDP: [$device->ip]:57602->[192.168.5.5]:162
140			DISMAN-EVENT-MIB::sysUpTimeInstance 26:19:43:37.24
141			SNMPv2-MIB::snmpTrapOID.0 CM-ALARM-MIB::cmNetworkElementAlmTrap
142			CM-ALARM-MIB::cmAlmIndex.0 30
143			CM-ALARM-MIB::cmNetworkElementAlmNotifCode.1.30 critical
144			CM-ALARM-MIB::cmNetworkElementAlmType.1.30 lnkdown
145			CM-ALARM-MIB::cmNetworkElementAlmSrvEff.1.30 serviceAffecting
146			CM-ALARM-MIB::cmNetworkElementAlmTime.1.30 2018-12-10,11:1:43.0,-6:0
147			CM-ALARM-MIB::cmNetworkElementAlmLocation.1.30 nearEnd
148			CM-ALARM-MIB::cmNetworkElementAlmDirection.1.30 receiveDirectionOnly
149			CM-ALARM-MIB::cmNetworkElementAlmDescr.1.30 \"Test Alarm Critical\"
150			CM-ALARM-MIB::cmNetworkElementAlmObject.1.30 CM-FACILITY-MIB::cmEthernetNetPortIndex.1.1.1.2
151			CM-ALARM-MIB::cmNetworkElementAlmObjectName.1.30 NETWORK PORT-1-1-1-2
152			CM-ALARM-MIB::cmNetworkElementAlmAdditionalInfoObject.1.30 SNMPv2-SMI::zeroDotZero
153			CM-ALARM-MIB::cmNetworkElementAlmAdditionalInfoName.1.30
154			RMON2-MIB::probeDateTime.0 \"07 E2 0C 0A 0B 01 2B 00 2D 06 00 \"
155			ADVA-MIB::neEventLogIndex.231 231
156			ADVA-MIB::neEventLogTimeStamp.231 2018-12-10,11:1:43.3,-6:0";
157
158			$trap = new Trap($trapText);
159
160			$message = "Alarming Element: NETWORK PORT-1-1-1-2 Description: Test Alarm Critical Severity: critical";
161			\Log::shouldReceive('event')->once()->with($message, $device->device_id, 'trap', 5);
162
163			$this->assertTrue(Dispatcher::handle($trap), 'Could not handle cmNetworkElementAlmTrap critical');
164			}
165			}
166

librenms / librenms

Push — master ( 0baeb0...d4017c )

SnmpTraps/AdvaNetworkElementAlmTrapTest.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like